From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id F4209CCA48C for ; Tue, 26 Jul 2022 10:25:17 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233133AbiGZKZQ (ORCPT ); Tue, 26 Jul 2022 06:25:16 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54486 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233109AbiGZKZO (ORCPT ); Tue, 26 Jul 2022 06:25:14 -0400 Received: from mail-lf1-x12f.google.com (mail-lf1-x12f.google.com [IPv6:2a00:1450:4864:20::12f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id ED48A3204F for ; Tue, 26 Jul 2022 03:25:05 -0700 (PDT) Received: by mail-lf1-x12f.google.com with SMTP id y11so21827116lfs.6 for ; Tue, 26 Jul 2022 03:25:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=x+nskSevu+BnV44CpZIDNQEifjnEzcirOFZu/6Dy2ww=; b=f7cF7eFX0+s6Ge80wf+LWz2MZcY6cVEabODf33OiVdmR3hiXwsFE2kBrycyvMAv3ml dr5S4BwlNUXJNsVhOTt1qqDRzR3/kyH9Ab23mD1hGr1nkMJvGfqGoIf9JtZ8r2Yf16kJ tO8c5vm5uk2DUShQgk1L9lI2DL2pS6vmycdihdtk3ZsgUkD40eJmwZvC6Gqql5S8fWXW BTeinqhzrMNQAsl8A2VrvUvmWUdAuwcistWRht0Dc3hawdcMlhcKpG98OVFf2ZI576vK B+xTg+Fo6eLd1oVpC6P/DQ/GG8NpNW7pMfv2nNnrco+GEoaK86MpZ6inM5bFG6ll0MPF vg7g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=x+nskSevu+BnV44CpZIDNQEifjnEzcirOFZu/6Dy2ww=; b=HuVVi6i70Gmphik6O24dZq4C9aVi35HzCtdfZUAubrCPHZqYidmTH1a4t6TY7ytBM8 EhsXUVcTZjFse81d2XCAz/uMbViEmImYOZ8QJUi5SLI7NMeTCxUgCyx0cflxL8NMebmP YakKsB3L8wDs7a+5zcqBxjssOnQv+u/cuBqvEAS6Ylkm9mLmgylgzPKZ7a940UcGHRAA waaaCxhaUSUJZYiSn9oTXkmo9xyqtq2AcoxZB74gSREW1YhlK0pM6lm+Rd+GbpNYjEsz zGR8UN1mVDv6wmYWrCIhsM+zM1vynPUlrN6Ey3W6t5iCNikf2upjrTN/KmzwHfw02ZCw gKnA== X-Gm-Message-State: AJIora/kLMHnCujzzFzNLH1alaSaaVBvi6KP+op6lu0uCnQt9Fmy76yS RJroHnXvuH5PLEPEaiRxBgNkCg== X-Google-Smtp-Source: AGRyM1sYAdgHN8tBKjKpSNdBNjl4YXX//x0wnnc1Dmy6k6JC6knN15yFRPQ3AvGS+PFPLiiSsfim2Q== X-Received: by 2002:a05:6512:33c3:b0:48a:83a9:52e1 with SMTP id d3-20020a05651233c300b0048a83a952e1mr4730137lfg.344.1658831104304; Tue, 26 Jul 2022 03:25:04 -0700 (PDT) Received: from [192.168.3.197] (78-26-46-173.network.trollfjord.no. [78.26.46.173]) by smtp.gmail.com with ESMTPSA id b9-20020a056512070900b00489c8c6c055sm516654lfs.50.2022.07.26.03.25.03 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 26 Jul 2022 03:25:03 -0700 (PDT) Message-ID: Date: Tue, 26 Jul 2022 12:25:02 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.12.0 Subject: Re: [PATCH v4 1/2] dt-bindings: power: reset: qcom-pon: update "reg" property details Content-Language: en-US To: Anjelique Melendez , corbet@lwn.net, sre@kernel.org, robh+dt@kernel.org, agross@kernel.org, bjorn.andersson@linaro.org Cc: krzysztof.kozlowski+dt@linaro.org, vkoul@kernel.org, linux-doc@vger.kernel.org, linux-pm@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, David Collins References: <20220725191314.19456-1-quic_amelende@quicinc.com> <20220725191314.19456-2-quic_amelende@quicinc.com> From: Krzysztof Kozlowski In-Reply-To: <20220725191314.19456-2-quic_amelende@quicinc.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 25/07/2022 21:13, Anjelique Melendez wrote: > From: David Collins > > Update the description of "reg" property to add the PON_PBS base > address along with PON_HLOS base address. Also add "reg-names" > property constraints. > > Signed-off-by: David Collins > Signed-off-by: Anjelique Melendez > --- > Documentation/devicetree/bindings/power/reset/qcom,pon.yaml | 50 +++++++++++++++++++++++++++--- > 1 file changed, 46 insertions(+), 4 deletions(-) > > diff --git a/Documentation/devicetree/bindings/power/reset/qcom,pon.yaml b/Documentation/devicetree/bindings/power/reset/qcom,pon.yaml > index 353f155d..d7b6b875 100644 > --- a/Documentation/devicetree/bindings/power/reset/qcom,pon.yaml > +++ b/Documentation/devicetree/bindings/power/reset/qcom,pon.yaml > @@ -15,18 +15,27 @@ description: | > > This DT node has pwrkey and resin as sub nodes. > > -allOf: > - - $ref: reboot-mode.yaml# > - > properties: > compatible: > enum: > - qcom,pm8916-pon > - qcom,pms405-pon > - qcom,pm8998-pon > + - qcom,pmk8350-pon > > reg: > - maxItems: 1 > + description: | > + Specifies the SPMI base address for the PON (power-on) peripheral. For > + PMICs that have the PON peripheral (GEN3) split into PON_HLOS and PON_PBS > + (e.g. PMK8350), this can hold addresses of both PON_HLOS and PON_PBS > + peripherals. In that case, the PON_PBS address needs to be specified to > + facilitate software debouncing on some PMIC. > + minItems: 1 > + maxItems: 2 > + > + reg-names: > + minItems: 1 > + maxItems: 2 > > pwrkey: > type: object > @@ -42,6 +51,39 @@ required: > > unevaluatedProperties: false > > +allOf: > + - $ref: reboot-mode.yaml# > + - if: > + properties: > + compatible: > + contains: > + enum: > + - qcom,pm8916-pon > + - qcom,pms405-pon > + - qcom,pm8998-pon > + then: > + properties: > + reg: > + maxItems: 1 > + reg-names: > + items: > + - const: pon All your previous patches were actually missing (in commit msg, in the code) that piece of information which you add here. You now add reg-names with "pon" for older devices. I assumed previous that it is somehow needed, so I gave you the hints how it should be coded. But I don't understand - why are you doing it? This should be explained in commit msg. To me it is not needed at all... unless you want to mark that first address space is entirely different for other devices? > + - if: > + properties: > + compatible: > + contains: > + const: qcom,pmk8350-pon > + then: > + properties: > + reg: > + minItems: 1 > + maxItems: 2 > + reg-names: > + minItems: 1 > + items: > + - const: hlos > + - const: pbs > + > examples: > - | > #include Best regards, Krzysztof