From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Puranjay Mohan <p-mohan@ti.com>, linux-kernel@vger.kernel.org
Cc: davem@davemloft.net, edumazet@google.com,
krzysztof.kozlowski+dt@linaro.org, netdev@vger.kernel.org,
devicetree@vger.kernel.org, nm@ti.com, ssantosh@kernel.org,
s-anna@ti.com, linux-arm-kernel@lists.infradead.org,
rogerq@kernel.org, grygorii.strashko@ti.com, vigneshr@ti.com,
kishon@ti.com, robh+dt@kernel.org, afd@ti.com, andrew@lunn.ch
Subject: Re: [PATCH v2 1/2] dt-bindings: net: Add ICSSG Ethernet Driver bindings
Date: Tue, 31 May 2022 13:48:44 +0200 [thread overview]
Message-ID: <a47f5d18-9ecc-a679-b407-799e4a15c6cf@linaro.org> (raw)
In-Reply-To: <faff79c9-7e1e-a69b-f314-6c00dedf1722@ti.com>
On 31/05/2022 13:27, Puranjay Mohan wrote:
>>> +examples:
>>> + - |
>>> +
>>> + /* Example k3-am654 base board SR2.0, dual-emac */
>>> + pruss2_eth: pruss2_eth {
>>> + compatible = "ti,am654-icssg-prueth";
>>
>> Again missed Rob's comment.
>
> One of Rob's comment was to make the indentation as 4 which I have done.
I clearly do not see indentation of 4, but there is 8 instead.
Let's count:
+ pruss2_eth: pruss2_eth {
+ compatible = "ti,am654-icssg-prueth";
12345678^
It's 8...
>
> The second comment was about 'ti,prus'.
>
> So, ti,prus , firmware-name, and ti,pruss-gp-mux-sel are a part of
> remoteproc/ti,pru-consumer.yaml which I have included with
>
> allOf:
> - $ref: /schemas/remoteproc/ti,pru-consumer.yaml#
>
> So, I thought it is not required to add them again.
>
> I will add it in next version, if that is how it should be done.
I was referring to the indentation.
Krzysztof
next prev parent reply other threads:[~2022-05-31 11:48 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-31 9:51 [PATCH v2 0/2] Introduce ICSSG based ethernet Driver Puranjay Mohan
2022-05-31 9:51 ` [PATCH v2 1/2] dt-bindings: net: Add ICSSG Ethernet Driver bindings Puranjay Mohan
2022-05-31 10:08 ` Krzysztof Kozlowski
2022-05-31 11:27 ` Puranjay Mohan
2022-05-31 11:48 ` Krzysztof Kozlowski [this message]
2022-05-31 11:59 ` Puranjay Mohan
2022-05-31 12:01 ` Krzysztof Kozlowski
2022-06-01 4:28 ` Puranjay Mohan
2022-06-05 15:11 ` Andrew Lunn
2022-11-04 7:28 ` Md Danish Anwar
2022-11-04 12:57 ` Krzysztof Kozlowski
2022-05-31 13:21 ` Rob Herring
2022-05-31 9:51 ` [PATCH v2 2/2] net: ti: icssg-prueth: Add ICSSG ethernet driver Puranjay Mohan
2022-05-31 10:20 ` Krzysztof Kozlowski
2022-05-31 11:23 ` Paolo Abeni
2022-11-04 8:29 ` Md Danish Anwar
2022-05-31 13:11 ` Randy Dunlap
2022-06-05 15:37 ` Andrew Lunn
2022-11-04 10:26 ` Md Danish Anwar
2022-06-05 16:24 ` Christophe JAILLET
2022-11-04 9:50 ` Md Danish Anwar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a47f5d18-9ecc-a679-b407-799e4a15c6cf@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=afd@ti.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=edumazet@google.com \
--cc=grygorii.strashko@ti.com \
--cc=kishon@ti.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=nm@ti.com \
--cc=p-mohan@ti.com \
--cc=robh+dt@kernel.org \
--cc=rogerq@kernel.org \
--cc=s-anna@ti.com \
--cc=ssantosh@kernel.org \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).