[PATCH next] dt-bindings:spi: Fix test error for sp7021.

[PATCH next] dt-bindings:spi: Fix test error for sp7021.

[Li-hao Kuo]

Remove the include path and modify parameters for fix error for bt binding test

Fixes: a708078eeb99  ("spi: Add Sunplus SP7021 schema")
Signed-off-by: Li-hao Kuo <lhjeff911@gmail.com>
---
 Documentation/devicetree/bindings/spi/spi-sunplus-sp7021.yaml | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

diff --git a/Documentation/devicetree/bindings/spi/spi-sunplus-sp7021.yaml b/Documentation/devicetree/bindings/spi/spi-sunplus-sp7021.yaml
index 38589fd..298eac2 100644
--- a/Documentation/devicetree/bindings/spi/spi-sunplus-sp7021.yaml
+++ b/Documentation/devicetree/bindings/spi/spi-sunplus-sp7021.yaml
@@ -59,8 +59,6 @@ unevaluatedProperties: false
 
 examples:
   - |
-    #include <dt-bindings/clock/sp-sp7021.h>
-    #include <dt-bindings/reset/sp-sp7021.h>
     #include <dt-bindings/interrupt-controller/irq.h>
     spi@9C002D80 {
         compatible = "sunplus,sp7021-spi";
@@ -73,8 +71,8 @@ examples:
         interrupts = <144 IRQ_TYPE_LEVEL_HIGH>,
                      <146 IRQ_TYPE_LEVEL_HIGH>,
                      <145 IRQ_TYPE_LEVEL_HIGH>;
-        clocks = <&clkc SPI_COMBO_0>;
-        resets = <&rstc RST_SPI_COMBO_0>;
+        clocks = <&clkc 0x32>;
+        resets = <&rstc 0x22>;
         pinctrl-names = "default";
         pinctrl-0 = <&pins_spi0>;
     };
-- 
2.7.4

Re: [PATCH next] dt-bindings:spi: Fix test error for sp7021.

[Krzysztof Kozlowski]

On 07/02/2022 02:46, Li-hao Kuo wrote:
> Remove the include path and modify parameters for fix error for bt binding test

1. No trailing dots in commit title. Space after each ":".
2. s/bt/dt/
3. Wrap the commit msg:
https://elixir.bootlin.com/linux/v5.13/source/Documentation/process/submitting-patches.rst#L124

4. What is exactly the error you are fixing?

> 
> Fixes: a708078eeb99  ("spi: Add Sunplus SP7021 schema")

5. Only one space after SHA.

6. Wasn't it reported to you? Looks like it was, so you need to add
"Reported-by" tag:
https://lore.kernel.org/all/CAL_JsqKwg_bzJmehTG8tR2cpr+HwwvpF_cpoESidZouc_SpKcQ@mail.gmail.com/

> Signed-off-by: Li-hao Kuo <lhjeff911@gmail.com>
> ---
>  Documentation/devicetree/bindings/spi/spi-sunplus-sp7021.yaml | 6 ++----
>  1 file changed, 2 insertions(+), 4 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/spi/spi-sunplus-sp7021.yaml b/Documentation/devicetree/bindings/spi/spi-sunplus-sp7021.yaml
> index 38589fd..298eac2 100644
> --- a/Documentation/devicetree/bindings/spi/spi-sunplus-sp7021.yaml
> +++ b/Documentation/devicetree/bindings/spi/spi-sunplus-sp7021.yaml
> @@ -59,8 +59,6 @@ unevaluatedProperties: false
>  
>  examples:
>    - |
> -    #include <dt-bindings/clock/sp-sp7021.h>
> -    #include <dt-bindings/reset/sp-sp7021.h>
>      #include <dt-bindings/interrupt-controller/irq.h>
>      spi@9C002D80 {
>          compatible = "sunplus,sp7021-spi";
> @@ -73,8 +71,8 @@ examples:
>          interrupts = <144 IRQ_TYPE_LEVEL_HIGH>,
>                       <146 IRQ_TYPE_LEVEL_HIGH>,
>                       <145 IRQ_TYPE_LEVEL_HIGH>;
> -        clocks = <&clkc SPI_COMBO_0>;
> -        resets = <&rstc RST_SPI_COMBO_0>;
> +        clocks = <&clkc 0x32>;
> +        resets = <&rstc 0x22>;
>          pinctrl-names = "default";
>          pinctrl-0 = <&pins_spi0>;
>      };


Best regards,
Krzysztof

Re: [PATCH next] dt-bindings:spi: Fix test error for sp7021.

[Mark Brown]

On Mon, 7 Feb 2022 09:46:34 +0800, Li-hao Kuo wrote:
> Remove the include path and modify parameters for fix error for bt binding test
> 
> 

Applied to

   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git for-next

Thanks!

[1/1] dt-bindings:spi: Fix test error for sp7021.
      commit: 3b8ab4da3405d07ddfe434f17f9014740b30a19c

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark

Re: [PATCH next] dt-bindings:spi: Fix test error for sp7021.

[Rob Herring]

On Sun, Feb 6, 2022 at 7:46 PM Li-hao Kuo <lhjeff911@gmail.com> wrote:
>
> Remove the include path and modify parameters for fix error for bt binding test
>
> Fixes: a708078eeb99  ("spi: Add Sunplus SP7021 schema")
> Signed-off-by: Li-hao Kuo <lhjeff911@gmail.com>
> ---
>  Documentation/devicetree/bindings/spi/spi-sunplus-sp7021.yaml | 6 ++----
>  1 file changed, 2 insertions(+), 4 deletions(-)

Unfortunately, this fix exposes another issue:

/builds/robherring/linux-dt/Documentation/devicetree/bindings/spi/spi-sunplus-sp7021.example.dt.yaml:
spi@9C002D80: 'clocks-names' is a required property
From schema: /builds/robherring/linux-dt/Documentation/devicetree/bindings/spi/spi-sunplus-sp7021.yaml

Please test your stuff!

Rob

RE: [PATCH next] dt-bindings:spi: Fix test error for sp7021.

[Lh Kuo 郭力豪]

Thanks for your comment. I have sent a patch to fix it.