From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Andrew Halaney <ahalaney@redhat.com>,
agross@kernel.org, andersson@kernel.org,
konrad.dybcio@somainline.org, lgirdwood@gmail.com,
broonie@kernel.org, robh+dt@kernel.org,
krzysztof.kozlowski+dt@linaro.org
Cc: linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org,
devicetree@vger.kernel.org, dianders@chromium.org,
johan@kernel.org
Subject: Re: [PATCH 2/3] regulator: dt-bindings: qcom,rpmh: Specify supply property
Date: Mon, 5 Sep 2022 18:47:35 +0200 [thread overview]
Message-ID: <a49fad1a-f7fb-921e-d0f5-e1edb3f86f7c@linaro.org> (raw)
In-Reply-To: <20220902185148.635292-3-ahalaney@redhat.com>
On 02/09/2022 20:51, Andrew Halaney wrote:
> The top level RPMh nodes have a supply property, make sure to specify it
> so the patternProperties later that are keyed off of the PMIC version
> are properly honored. Without this, and the dt-binding containing
> additionalProperties: false, you will see the following when running
> make dt_binding_check:
>
> DTEX Documentation/devicetree/bindings/regulator/qcom,rpmh-regulator.example.dts
> DTC Documentation/devicetree/bindings/regulator/qcom,rpmh-regulator.example.dtb
> CHECK Documentation/devicetree/bindings/regulator/qcom,rpmh-regulator.example.dtb
> /mnt/extrassd/git/linux-next/Documentation/devicetree/bindings/regulator/qcom,rpmh-regulator.example.dtb: pm8998-rpmh-regulators: 'vdd-l7-l12-l14-l15-supply' does not match any of the regexes: '^(smps|ldo|lvs)[0-9]+$', 'pinctrl-[0-9]+'
> From schema: /mnt/extrassd/git/linux-next/Documentation/devicetree/bindings/regulator/qcom,rpmh-regulator.yaml
>
> That supply pattern is intended to be considered correct for the
> qcom,pm8998-rpmh-regulators compatible, and is no longer complained
> about with the supply property described.
Which supply pattern?
>
> Unfortunately this pattern is wide enough that it no longer complains
> when you bork the expected supply for a compatible. I.e. for
> qcom,pm8998-rpmh-regulators, if I change the example usage in the
> binding to:
>
> vdd-l0-l12-l14-l15-supply = <&pm8998_s5>;
>
> I get no warning, when really it should be of the pattern:
>
> vdd-l7-l12-l14-l15-supply = <&pm8998_s5>;
>
> Signed-off-by: Andrew Halaney <ahalaney@redhat.com>
No, you basically reverse the change I did, without actually addressing
my intentions in that commit. If you want to revert it, please make a
proper revert and explain why such revert is needed.
Best regards,
Krzysztof
next prev parent reply other threads:[~2022-09-05 16:47 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-02 18:51 [PATCH 0/3] regulator: dt-bindings: qcom,rpmh: dt-binding fixups Andrew Halaney
2022-09-02 18:51 ` [PATCH 1/3] regulator: dt-bindings: qcom,rpmh: Use additionalProperties Andrew Halaney
2022-09-02 21:34 ` Rob Herring
2022-09-05 16:45 ` Krzysztof Kozlowski
2022-09-05 16:53 ` Krzysztof Kozlowski
2022-09-06 14:32 ` Andrew Halaney
2022-09-02 18:51 ` [PATCH 2/3] regulator: dt-bindings: qcom,rpmh: Specify supply property Andrew Halaney
2022-09-05 16:47 ` Krzysztof Kozlowski [this message]
2022-09-02 18:51 ` [PATCH 3/3] regulator: dt-bindings: qcom,rpmh: Indicate regulator-allow-set-load dependencies Andrew Halaney
2022-09-05 16:50 ` Krzysztof Kozlowski
2022-09-06 14:41 ` Andrew Halaney
2022-09-08 10:23 ` Krzysztof Kozlowski
2022-09-06 20:25 ` [PATCH 0/3] regulator: dt-bindings: qcom,rpmh: dt-binding fixups Andrew Halaney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a49fad1a-f7fb-921e-d0f5-e1edb3f86f7c@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=agross@kernel.org \
--cc=ahalaney@redhat.com \
--cc=andersson@kernel.org \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dianders@chromium.org \
--cc=johan@kernel.org \
--cc=konrad.dybcio@somainline.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).