Re: [PATCH V2 2/2] arm64: dts: broadcom: add BCM4908 and Asus GT-AC5300 early DTS files

[Florian Fainelli <f.fainelli@gmail.com>]

On 11/5/2020 12:54 AM, Rafał Miłecki wrote:
> From: Rafał Miłecki <rafal@milecki.pl>
> 
> They don't descibe hardware fully yet but it's enough to boot a system.
> 
> Some missing blocks:
> 1. PMC (Power Management Controller?)
> 2. Ethernet
> 3. Crypto
> 4. Thermal
> 
> Asus DTS is missing defining full NAND partitions layout and buttons.
> 
> Further changes will fill those gaps as soon as required bindings will
> be found / tested / added.
> 
> Signed-off-by: Rafał Miłecki <rafal@milecki.pl>

We would need a board/SoC binding document under
Documentation/devicetree/bindings/arm/bcm/ which describes the 4908 SoC
and its possible boards at least.

[snip]
h
> +
> +&nandcs {
> +	nand-ecc-strength = <4>;
> +	nand-ecc-step-size = <512>;
> +	nand-on-flash-bbt;
> +	brcm,nand-has-wp;
> +
> +	#address-cells = <1>;
> +	#size-cells = <0>;
> +
> +	partitions {
> +		compatible = "fixed-partitions";
> +		#address-cells = <1>;
> +		#size-cells = <1>;
> +
> +		partition@0 {
> +			label = "cferom";
> +			reg = <0x000000000000 0x000000100000>;

You can probably trim the leading zeroes.

> +		};
> +	};
> +};
> diff --git a/arch/arm64/boot/dts/broadcom/bcm4908/bcm4908.dtsi b/arch/arm64/boot/dts/broadcom/bcm4908/bcm4908.dtsi
> new file mode 100644
> index 000000000000..3bbefc86b978
> --- /dev/null
> +++ b/arch/arm64/boot/dts/broadcom/bcm4908/bcm4908.dtsi
> @@ -0,0 +1,188 @@
> +// SPDX-License-Identifier: GPL-2.0-or-later OR MIT
> +
> +#include <dt-bindings/interrupt-controller/irq.h>
> +#include <dt-bindings/interrupt-controller/arm-gic.h>
> +
> +/dts-v1/;
> +
> +/ {
> +	interrupt-parent = <&gic>;
> +
> +	#address-cells = <2>;
> +	#size-cells = <2>;
> +
> +	aliases {
> +		serial0 = &uart0;
> +	};
> +
> +	chosen {
> +		bootargs = "earlycon=bcm63xx_uart,0xff800640";

We talked about it before, but the earlycon should be dropped from the
.dtsi file, it does not really belong there.

The rest looks good to me!
-- 
Florian