From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.1 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 04C04C388F7 for ; Wed, 11 Nov 2020 01:04:32 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 9CC7321D93 for ; Wed, 11 Nov 2020 01:04:31 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="rstR4NoO" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731805AbgKKBEa (ORCPT ); Tue, 10 Nov 2020 20:04:30 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47020 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730894AbgKKBE3 (ORCPT ); Tue, 10 Nov 2020 20:04:29 -0500 Received: from mail-pf1-x443.google.com (mail-pf1-x443.google.com [IPv6:2607:f8b0:4864:20::443]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9EE56C0613D1 for ; Tue, 10 Nov 2020 17:04:28 -0800 (PST) Received: by mail-pf1-x443.google.com with SMTP id y7so466147pfq.11 for ; Tue, 10 Nov 2020 17:04:28 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=rQTT04wcfpF7QK3jMNSOeddpWQqsTYbtkHPF2TgnhDw=; b=rstR4NoObJzeoh+3p/JZ53mnW/kAlu+1apkEbE1fD9J5w+fxgAaUW4nBT0Qbz07+Te OqmJJzaSzoKgR4OYO8VFRtlxL4rh9QuIukY7tHjv30R4N30bcUwmN2WdzQE7y9Yx851D KMNj8MbF51ymPuL4xJz2DiaN/KaR26DKXFNMXFeqWIKYtmnz81xql0Wlony23a9bTjuG 02iiYcXNjjRDsg3l2kiK7SGySVAqfNgNMfgoeTHHhYhpmhZsWpGv/Jr6FHjfZA9BXCS3 bjd1vfo8sJgNDFJ8CpjxGRCbdbINNdhvOJ+HHWtFfhJWKV1n7n24AakwN3Yf2FDihXB+ IMwQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=rQTT04wcfpF7QK3jMNSOeddpWQqsTYbtkHPF2TgnhDw=; b=NPMsAyVJnFS4RWVr3dyOQ5gNtTqraTA6uN6xe9aQndFmGoahQhC2IrX4MVQiTuTGJI U5h0ptfxw3jAo4grNzAlKm6H0IhT8xRV20Zoc9YJzkPT1fxAFXQMDe14+DQhRCl3XqGY U0e/LD6T1ECus1yyt50AdMEuVCet1q5hbZObypPHAZ5mks+eOQj7tX4Ss8Rlk7WP4VLU YkW4Ey4X6n3nInHFcZa1tKH39zIxFX7YGvMdozTxwghD5VZitaqqEWQ03Uc0V3ZjPmyp jR16sWHsdGhG866t6CLbeIl8M0hsnC7gCXiGi49eH83ogPR7EnEUqScdvqbnN1BqQ5U8 bj1w== X-Gm-Message-State: AOAM531YCySVJ0Ejiyzhnz4xsO3XwYFQpwXI9/fVxnAr52uxvRNiK0VP GsI5oqZbT9KtluwcUcHygWk= X-Google-Smtp-Source: ABdhPJxhG5chZ2tKt1wDz5JBCkRGdM/AGvYGGjlnMRg3hkAzNvxoqiN7lYUBq0ijd1Zgf7MmnG3ivg== X-Received: by 2002:aa7:8586:0:b029:18c:3aa6:b8bb with SMTP id w6-20020aa785860000b029018c3aa6b8bbmr7828086pfn.39.1605056668116; Tue, 10 Nov 2020 17:04:28 -0800 (PST) Received: from [192.168.1.3] (ip68-111-84-250.oc.oc.cox.net. [68.111.84.250]) by smtp.gmail.com with ESMTPSA id i3sm244193pjd.33.2020.11.10.17.04.25 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 10 Nov 2020 17:04:26 -0800 (PST) Subject: Re: [PATCH V2 2/2] arm64: dts: broadcom: add BCM4908 and Asus GT-AC5300 early DTS files To: =?UTF-8?B?UmFmYcWCIE1pxYJlY2tp?= , Florian Fainelli Cc: Catalin Marinas , Will Deacon , Rob Herring , linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, bcm-kernel-feedback-list@broadcom.com, =?UTF-8?B?UmFmYcWCIE1pxYJlY2tp?= References: <20201105085458.21121-1-zajec5@gmail.com> <20201105085458.21121-2-zajec5@gmail.com> From: Florian Fainelli Message-ID: Date: Tue, 10 Nov 2020 17:04:25 -0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Firefox/78.0 Thunderbird/78.4.1 MIME-Version: 1.0 In-Reply-To: <20201105085458.21121-2-zajec5@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 11/5/2020 12:54 AM, Rafał Miłecki wrote: > From: Rafał Miłecki > > They don't descibe hardware fully yet but it's enough to boot a system. > > Some missing blocks: > 1. PMC (Power Management Controller?) > 2. Ethernet > 3. Crypto > 4. Thermal > > Asus DTS is missing defining full NAND partitions layout and buttons. > > Further changes will fill those gaps as soon as required bindings will > be found / tested / added. > > Signed-off-by: Rafał Miłecki We would need a board/SoC binding document under Documentation/devicetree/bindings/arm/bcm/ which describes the 4908 SoC and its possible boards at least. [snip] h > + > +&nandcs { > + nand-ecc-strength = <4>; > + nand-ecc-step-size = <512>; > + nand-on-flash-bbt; > + brcm,nand-has-wp; > + > + #address-cells = <1>; > + #size-cells = <0>; > + > + partitions { > + compatible = "fixed-partitions"; > + #address-cells = <1>; > + #size-cells = <1>; > + > + partition@0 { > + label = "cferom"; > + reg = <0x000000000000 0x000000100000>; You can probably trim the leading zeroes. > + }; > + }; > +}; > diff --git a/arch/arm64/boot/dts/broadcom/bcm4908/bcm4908.dtsi b/arch/arm64/boot/dts/broadcom/bcm4908/bcm4908.dtsi > new file mode 100644 > index 000000000000..3bbefc86b978 > --- /dev/null > +++ b/arch/arm64/boot/dts/broadcom/bcm4908/bcm4908.dtsi > @@ -0,0 +1,188 @@ > +// SPDX-License-Identifier: GPL-2.0-or-later OR MIT > + > +#include > +#include > + > +/dts-v1/; > + > +/ { > + interrupt-parent = <&gic>; > + > + #address-cells = <2>; > + #size-cells = <2>; > + > + aliases { > + serial0 = &uart0; > + }; > + > + chosen { > + bootargs = "earlycon=bcm63xx_uart,0xff800640"; We talked about it before, but the earlycon should be dropped from the .dtsi file, it does not really belong there. The rest looks good to me! -- Florian