From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>,
Andy Gross <agross@kernel.org>,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konrad.dybcio@linaro.org>,
Stephen Boyd <sboyd@kernel.org>,
Michael Turquette <mturquette@baylibre.com>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Taniya Das <quic_tdas@quicinc.com>,
Jassi Brar <jassisinghbrar@gmail.com>
Cc: linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 3/6] dt-bindings: mailbox: qcom: correct the list of platforms using clocks
Date: Wed, 18 Jan 2023 14:08:28 +0100 [thread overview]
Message-ID: <a4a39197-a58b-df5b-1dc8-fa9fd520bbc2@linaro.org> (raw)
In-Reply-To: <f575e888-b2ee-6568-7e63-708ad016ac5f@linaro.org>
On 18/01/2023 14:04, Dmitry Baryshkov wrote:
> On 18/01/2023 13:41, Krzysztof Kozlowski wrote:
>> On 17/01/2023 23:30, Dmitry Baryshkov wrote:
>>> Only three platforms require `pll' and `aux' clocks: msm8916, msm8939
>>> and qcs404. Correct the list of platforms in the corresponding clause.
>>>
>>> Fixes: 0d17014e9189 ("dt-bindings: mailbox: Add binding for SDX55 APCS")
>>> Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
>>> ---
>>> .../mailbox/qcom,apcs-kpss-global.yaml | 33 ++++++++++++++-----
>>> 1 file changed, 25 insertions(+), 8 deletions(-)
>>>
>>> diff --git a/Documentation/devicetree/bindings/mailbox/qcom,apcs-kpss-global.yaml b/Documentation/devicetree/bindings/mailbox/qcom,apcs-kpss-global.yaml
>>> index ecc286ab49ef..7d8de7a16984 100644
>>> --- a/Documentation/devicetree/bindings/mailbox/qcom,apcs-kpss-global.yaml
>>> +++ b/Documentation/devicetree/bindings/mailbox/qcom,apcs-kpss-global.yaml
>>> @@ -72,15 +72,8 @@ allOf:
>>> compatible:
>>> enum:
>>> - qcom,msm8916-apcs-kpss-global
>>> - - qcom,msm8994-apcs-kpss-global
>>> - - qcom,msm8996-apcs-hmss-global
>>> - - qcom,msm8998-apcs-hmss-global
>>> + - qcom,msm8939-apcs-kpss-global
>>> - qcom,qcs404-apcs-apps-global
>>> - - qcom,sc7180-apss-shared
>>> - - qcom,sdm660-apcs-hmss-global
>>> - - qcom,sdm845-apss-shared
>>> - - qcom,sm6125-apcs-hmss-global
>>> - - qcom,sm8150-apss-shared
>>> then:
>>> properties:
>>> clocks:
>>> @@ -124,6 +117,30 @@ allOf:
>>> items:
>>> - const: pll
>>> - const: xo
>>> +
>>> + - if:
>>> + properties:
>>> + compatible:
>>> + enum:
>>> + - qcom,msm8953-apcs-kpss-global
>>> + - qcom,msm8976-apcs-kpss-global
>>> + - qcom,msm8994-apcs-kpss-global
>>> + - qcom,msm8996-apcs-hmss-global
>>> + - qcom,msm8998-apcs-hmss-global
>>> + - qcom,qcm2290-apcs-hmss-global
>>> + - qcom,sc7180-apss-shared
>>> + - qcom,sc8180x-apss-shared
>>> + - qcom,sdm660-apcs-hmss-global
>>> + - qcom,sdm845-apss-shared
>>> + - qcom,sm4250-apcs-hmss-global
>>> + - qcom,sm6115-apcs-hmss-global
>>> + - qcom,sm6125-apcs-hmss-global
>>> + - qcom,sm8150-apss-shared
>>
>> Isn't this in multiple places now? This doesn't match what you remove
>> either.
>
> Yes, I addsd several platforms. I can split this into two patches: one
> moving the platforms and another one adding missing platforms. Would you
> prefer it?
Yes, plus you now duplicated entries, didn't you? As I pointed - some of
them are in multiple places now.
Best regards,
Krzysztof
next prev parent reply other threads:[~2023-01-18 13:39 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-17 22:30 [PATCH v3 0/6] clk: qcom: msm8996: add APCS clock driver Dmitry Baryshkov
2023-01-17 22:30 ` [PATCH v3 1/6] dt-bindings: mailbox: qcom: add SDX55 compatible Dmitry Baryshkov
2023-01-18 11:40 ` Krzysztof Kozlowski
2023-01-17 22:30 ` [PATCH v3 2/6] dt-bindings: mailbox: qcom: enable syscon compatible for msm8976 Dmitry Baryshkov
2023-01-18 11:40 ` Krzysztof Kozlowski
2023-01-17 22:30 ` [PATCH v3 3/6] dt-bindings: mailbox: qcom: correct the list of platforms using clocks Dmitry Baryshkov
2023-01-18 11:41 ` Krzysztof Kozlowski
2023-01-18 13:04 ` Dmitry Baryshkov
2023-01-18 13:08 ` Krzysztof Kozlowski [this message]
2023-01-17 22:30 ` [PATCH v3 4/6] dt-bindings: mailbox: qcom: add #clock-cells to msm8996 example Dmitry Baryshkov
2023-01-18 11:42 ` Krzysztof Kozlowski
2023-01-17 22:30 ` [PATCH v3 5/6] mailbox: qcom-apcs-ipc: enable APCS clock device for MSM8996 Dmitry Baryshkov
2023-01-17 22:30 ` [PATCH v3 6/6] clk: qcom: add the driver for the MSM8996 APCS clocks Dmitry Baryshkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a4a39197-a58b-df5b-1dc8-fa9fd520bbc2@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.baryshkov@linaro.org \
--cc=jassisinghbrar@gmail.com \
--cc=konrad.dybcio@linaro.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=quic_tdas@quicinc.com \
--cc=robh+dt@kernel.org \
--cc=sboyd@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).