Re: [PATCH v2 1/4] regulator: dt-bindings: Add TI LM51772 support

[Krzysztof Kozlowski <krzk@kernel.org>]

On 29/10/2026 10:05, Paul Louvel wrote:
> Hi Krzysztof,
> 
> On Thu Oct 29, 2026 at 9:41 AM CET, Krzysztof Kozlowski wrote:
>> On Tue, Oct 27, 2026 at 10:39:23AM +0100, Paul Louvel wrote:
>>> +          regulator-temp-warn-kelvin:
>>> +            enum: [0, 1, 368, 383, 398, 413]
>>> +
>>> +          regulator-ramp-delay:
>>> +            enum: [40000, 20000, 1000, 500]
>>> +
>>> +          regulator-min-microvolt:
>>> +            minimum: 1000000
>>> +            maximum: 48000000
>>> +
>>> +          regulator-max-microvolt:
>>> +            minimum: 1000000
>>> +            maximum: 48000000
>>> +
>>> +          regulator-min-microamp:
>>> +            minimum: 500000
>>> +            maximum: 7000000
>>> +
>>> +          regulator-max-microamp:
>>> +            minimum: 500000
>>> +            maximum: 7000000
>>> +
>>> +        unevaluatedProperties: false
>>
>> Place this line after description, that's the convention for child nodes
>> for readability.
>>
>>> +
>>> +      vcc1:
>>> +        type: object
>>> +        $ref: regulator.yaml#
>>> +        description: |
>>> +          LDO regulator for auxiliary use.
>>> +          It can used to power, for example, a PD controller that will drive this PMIC.
>>> +
>>> +        properties:
>>> +          regulator-min-microvolt:
>>> +            minimum: 5000000
>>> +            maximum: 5000000
>>> +
>>> +          regulator-max-microvolt:
>>> +            minimum: 5000000
>>> +            maximum: 5000000
>>> +
>>> +        unevaluatedProperties: false
>>
>> Place this line after description, that's the convention for child nodes
>> for readability.
>>
>>> +
>>> +    additionalProperties: false
>>
>> Place this line after description (for relevant block), that's the
>> convention for child nodes for readability.
>>
>>> +
>>> +  ti,sync-pin:
>>> +    description: |
>>> +      Selects the function of the SYNC pin, used when several converters
>>> +      operate in parallel.
>>> +    $ref: /schemas/types.yaml#/definitions/string
>>> +    enum: [input-rising, input-falling, output-rising, output-falling]
>>> +    default: input-rising
>>> +
>>> +  ti,ivp-thres-microvolt:
>>
>> Use either existing over-voltage-threshold-microvolt from battery schema
>> or ti,ovp-microvolt from the other TI binding.
> 
> IVP is not the same as OVP.

... because? OVP is overv-oltage protection, so ivp is not input
over-voltage protection?

Best regards,
Krzysztof