Re: [PATCH v3 2/2] interconnect: qcom: Add MSM8953 driver

[barnabas.czeman@mainlining.org]

On 2024-06-28 20:39, Georgi Djakov wrote:
> Hi Barnabás,
> 
> Thank you for the patches!
> 
> On 28.06.24 17:01, Barnabás Czémán wrote:
>> From: Vladimir Lypak <vladimir.lypak@gmail.com>
>> 
>> Add driver for interconnect busses found in MSM8953 based platforms.
>> The topology consists of four NoCs that are partially controlled by a
>> RPM processor.
>> 
>> Note that one of NoCs (System NoC) has a counterpart (System NoC MM)
>> that is modelled as child device to avoid resource conflicts, since it
>> uses same MMIO space for configuration.
>> 
>> Signed-off-by: Vladimir Lypak <vladimir.lypak@gmail.com>
>> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>> Signed-off-by: Barnabás Czémán <barnabas.czeman@mainlining.org>
>> ---
>>   drivers/interconnect/qcom/Kconfig   |    9 +
>>   drivers/interconnect/qcom/Makefile  |    2 +
>>   drivers/interconnect/qcom/msm8953.c | 1321 
>> +++++++++++++++++++++++++++++++++++
>>   3 files changed, 1332 insertions(+)
> [..]
>> +++ b/drivers/interconnect/qcom/msm8953.c
> [..]
>> +static const struct of_device_id msm8953_noc_of_match[] = {
>> +	{ .compatible = "qcom,msm8953-bimc", .data = &msm8953_bimc },
>> +	{ .compatible = "qcom,msm8953-pcnoc", .data = &msm8953_pcnoc },
>> +	{ .compatible = "qcom,msm8953-snoc", .data = &msm8953_snoc },
>> +	{ .compatible = "qcom,msm8953-snoc-mm", .data = &msm8953_snoc_mm },
>> +	{ }
>> +};
>> +
>> +static struct platform_driver msm8953_noc_driver = {
>> +	.probe = qnoc_probe,
>> +	.remove_new = qnoc_remove,
>> +	.driver = {
>> +		.name = "qnoc-msm8953",
>> +		.of_match_table = msm8953_noc_of_match,
> 
> Why no .sync_state?
Because there is no cpufreq upstreamed
> 
> BR,
> Georgi