From: Krzysztof Kozlowski <krzk@kernel.org>
To: Vishwaroop A <va@nvidia.com>,
broonie@kernel.org, robh@kernel.org, krzk+dt@kernel.org,
conor+dt@kernel.org, thierry.reding@gmail.com,
jonathanh@nvidia.com, skomatineni@nvidia.com,
ldewangan@nvidia.com, kyarlagadda@nvidia.com,
smangipudi@nvidia.com, linux-spi@vger.kernel.org,
devicetree@vger.kernel.org, linux-tegra@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] dt-bindings: spi: nvidia,tegra210-quad: Add IOMMU property for Tegra234
Date: Tue, 6 May 2025 20:14:25 +0200 [thread overview]
Message-ID: <a4c935a7-0723-46c9-8f85-09f5c895833d@kernel.org> (raw)
In-Reply-To: <20250506180848.3430191-1-va@nvidia.com>
On 06/05/2025 20:08, Vishwaroop A wrote:
> The Tegra210 Quad SPI controller uses internal DMA engines to efficiently
> transfer data between system memory and the SPI bus. On Tegra234 platform,
> DMA transactions must be properly mapped and protected through IOMMU to
> ensure system security and functional correctness. Tegra241 uses external
> DMA and doesn't require IOMMU.
>
> Add the iommus property to the device tree binding, making it required
> only for Tegra234 platform while explicitly disallowing it for other
> platforms including Tegra241.
>
> Signed-off-by: Vishwaroop A <va@nvidia.com>
That's another v2? I reviewed one. Some of my comments are still valid.
Can you slow down with new versions and spend some time to read the
feedback you receive?
Best regards,
Krzysztof
next prev parent reply other threads:[~2025-05-06 18:14 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-06 18:08 [PATCH v2] dt-bindings: spi: nvidia,tegra210-quad: Add IOMMU property for Tegra234 Vishwaroop A
2025-05-06 18:14 ` Krzysztof Kozlowski [this message]
2025-05-14 19:01 ` Rob Herring
-- strict thread matches above, loose matches on Subject: below --
2025-05-06 17:58 Vishwaroop A
2025-05-06 18:12 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a4c935a7-0723-46c9-8f85-09f5c895833d@kernel.org \
--to=krzk@kernel.org \
--cc=broonie@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=jonathanh@nvidia.com \
--cc=krzk+dt@kernel.org \
--cc=kyarlagadda@nvidia.com \
--cc=ldewangan@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=robh@kernel.org \
--cc=skomatineni@nvidia.com \
--cc=smangipudi@nvidia.com \
--cc=thierry.reding@gmail.com \
--cc=va@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox