From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?UTF-8?Q?Andreas_F=c3=a4rber?= Subject: Re: [PATCH v11 4/6] ARM: dts: imx6q-evi: support altera-ps-spi Date: Fri, 2 Jun 2017 18:30:12 +0200 Message-ID: References: <20170525172911.11467-1-stillcompiling@gmail.com> <20170525172911.11467-5-stillcompiling@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Return-path: In-Reply-To: <20170525172911.11467-5-stillcompiling-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> Content-Language: en-US Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Joshua Clayton , Rob Herring Cc: Alan Tull , Moritz Fischer , Anatolij Gustschin , Bastian Stender , Shawn Guo , Mark Rutland , devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-fpga-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Russell King , linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Sascha Hauer , Fabio Estevam , linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org List-Id: devicetree@vger.kernel.org Hi, Am 25.05.2017 um 19:29 schrieb Joshua Clayton: > Add support for Altera V FPGA connected to an spi port Did you mean "Altera Cyclone V"? > to the evi devicetree file > > Signed-off-by: Joshua Clayton > --- > arch/arm/boot/dts/imx6q-evi.dts | 16 ++++++++++++++++ > 1 file changed, 16 insertions(+) > > diff --git a/arch/arm/boot/dts/imx6q-evi.dts b/arch/arm/boot/dts/imx6q-evi.dts > index 24fe093a66db..a0cbb2d84803 100644 > --- a/arch/arm/boot/dts/imx6q-evi.dts > +++ b/arch/arm/boot/dts/imx6q-evi.dts > @@ -82,6 +82,15 @@ > pinctrl-names = "default"; > pinctrl-0 = <&pinctrl_ecspi1 &pinctrl_ecspi1cs>; > status = "okay"; > + > + fpga_spi: cyclonespi@0 { "cyclonespi" does not strike me as the best node name. I am guessing this is a sub-node of a SPI controller node, so no need to repeat "spi", and Cyclone seems more or less implied by "altr,fpga-". Note that the example in the bindings doc uses "evi-fpga-spi". Nodes don't need to be (shouldn't be?) prefixed with the board. Note that bindings examples tend to get copied a lot. Any reason not to just use "fpga@0" in both places for simplicity? > + compatible = "altr,fpga-passive-serial"; > + spi-max-frequency = <20000000>; > + reg = <0>; > + pinctrl-0 = <&pinctrl_fpgaspi>; > + nconfig-gpios = <&gpio4 9 GPIO_ACTIVE_LOW>; > + nstat-gpios = <&gpio4 11 GPIO_ACTIVE_LOW>; > + }; > }; > > &ecspi3 { [snip] Regards, Andreas -- SUSE Linux GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG Nürnberg) -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html