Re: [PATCH 1/3] dt-bindings: display: panel: Rename WL-355608-A8 panel

[Neil Armstrong <neil.armstrong@linaro.org>]

On 26/06/2024 13:17, Ryan Walklin wrote:
> The WL-355608-A8 is a 3.5" 640x480@60Hz RGB LCD display from an unknown
> OEM used in a number of handheld gaming devices made by Anbernic.
> Previously committed using the OEM serial without a vendor prefix,
> however the preference is to use the integrating device vendor and name
> where the OEM is unknown.
> 
> Alter the filename and compatible string to reflect the convention.
> 
> Fixes: f08aac40639c ("drm: panel: nv3052c: Add WL-355608-A8 panel")
> Signed-off-by: Ryan Walklin <ryan@testtoast.com>
> ---
>   .../{wl-355608-a8.yaml => anbernic,rg35xx-panel.yaml}     | 8 ++++----
>   1 file changed, 4 insertions(+), 4 deletions(-)
>   rename Documentation/devicetree/bindings/display/panel/{wl-355608-a8.yaml => anbernic,rg35xx-panel.yaml} (81%)
> 
> diff --git a/Documentation/devicetree/bindings/display/panel/wl-355608-a8.yaml b/Documentation/devicetree/bindings/display/panel/anbernic,rg35xx-panel.yaml
> similarity index 81%
> rename from Documentation/devicetree/bindings/display/panel/wl-355608-a8.yaml
> rename to Documentation/devicetree/bindings/display/panel/anbernic,rg35xx-panel.yaml
> index 397c26be9bda5..a7d5ad0f29389 100644
> --- a/Documentation/devicetree/bindings/display/panel/wl-355608-a8.yaml
> +++ b/Documentation/devicetree/bindings/display/panel/anbernic,rg35xx-panel.yaml
> @@ -1,10 +1,10 @@
>   # SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
>   %YAML 1.2
>   ---
> -$id: http://devicetree.org/schemas/display/panel/wl-355608-a8.yaml#
> +$id: http://devicetree.org/schemas/display/panel/anbernic,rg35xx-panel.yaml#
>   $schema: http://devicetree.org/meta-schemas/core.yaml#
>   
> -title: WL-355608-A8 3.5" (640x480 pixels) 24-bit IPS LCD panel
> +title: Anbernic RG35XX (WL-355608-A8) 3.5" 640x480 24-bit IPS LCD panel
>   
>   maintainers:
>     - Ryan Walklin <ryan@testtoast.com>
> @@ -15,7 +15,7 @@ allOf:
>   
>   properties:
>     compatible:
> -    const: wl-355608-a8
> +    const: anbernic,rg35xx-panel
>   
>     reg:
>       maxItems: 1
> @@ -41,7 +41,7 @@ examples:
>           #size-cells = <0>;
>   
>           panel@0 {
> -            compatible = "wl-355608-a8";
> +            compatible = "anbernic,rg35xx-panel";

Can it be more specific ? because there's a lot of rg35xx defined in bindings:
  anbernic,rg351m
  anbernic,rg351v
  anbernic,rg353p
  anbernic,rg353ps
  anbernic,rg353v
  anbernic,rg353vs
  anbernic,rg35xx-2024
  anbernic,rg35xx-plus
  anbernic,rg35xx-h

Neil

>               reg = <0>;
>   
>               spi-3wire;