From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Boyd Subject: Re: [PATCH v3 1/4] dt-bindings: phy: Add support for QUSB2 phy Date: Tue, 27 Dec 2016 17:13:27 -0800 Message-ID: References: <1482253431-23160-1-git-send-email-vivek.gautam@codeaurora.org> <1482253431-23160-2-git-send-email-vivek.gautam@codeaurora.org> <20161222211633.ldk3ykqiat6peyw7@rob-hp-laptop> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: Sender: linux-arm-msm-owner@vger.kernel.org To: Vivek Gautam , Rob Herring Cc: kishon , "linux-kernel@vger.kernel.org" , "devicetree@vger.kernel.org" , Mark Rutland , Srinivas Kandagatla , linux-arm-msm@vger.kernel.org List-Id: devicetree@vger.kernel.org On 12/22/2016 08:52 PM, Vivek Gautam wrote: > >>> + >>> +Optional properties: >>> + - nvmem-cells: a list of phandles to nvmem cells that contain fused >>> + tuning parameters for qusb2 phy, one for each entry >>> + in nvmem-cell-names. >>> + - nvmem-cell-names: must be "tune2_hstx_trim" for cell containing >>> + HS Tx trim value. >> ditto. > nvmem doesn't allow, at this point, to get the cells by index. > Its APIs take 'const char' cell id and get the cell. > > We should add this support to get the cell by index. > Will create a patch for that, and drop the '-names' property from bindings. > If we introduce a cells based API just for this case of one phandle it may make sense to allow the cell id to be NULL and default to whatever cell is there without a names property. We do something similar with clks where a NULL connection id defaults to the first phandle in the list. Then we can avoid having a new set of DT specific APIs here. Of course, documentation should be updated to indicate that a NULL cell_id means use index 0 with DT. -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project