Re: [PATCH] arm64: dts: imx8mn: specify #sound-dai-cells for SAI nodes

[Marek Vasut <marex@denx.de>]

On 2/27/23 20:01, Marco Felsch wrote:
> Hi Marek,
> 
> On 23-02-27, Marek Vasut wrote:
>> Add #sound-dai-cells properties to SAI nodes.
>>
>> Signed-off-by: Marek Vasut <marex@denx.de>
>> ---
>> Cc: Abel Vesa <abelvesa@kernel.org>
>> Cc: Alexander Stein <alexander.stein@ew.tq-group.com>
>> Cc: Fabio Estevam <festevam@gmail.com>
>> Cc: Jacky Bai <ping.bai@nxp.com>
>> Cc: Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>
>> Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
>> Cc: Luca Ceresoli <luca.ceresoli@bootlin.com>
>> Cc: Lucas Stach <l.stach@pengutronix.de>
>> Cc: Marco Felsch <m.felsch@pengutronix.de>
>> Cc: Michael Turquette <mturquette@baylibre.com>
>> Cc: NXP Linux Team <linux-imx@nxp.com>
>> Cc: Peng Fan <peng.fan@nxp.com>
>> Cc: Pengutronix Kernel Team <kernel@pengutronix.de>
>> Cc: Richard Cochran <richardcochran@gmail.com>
>> Cc: Rob Herring <robh+dt@kernel.org>
>> Cc: Sascha Hauer <s.hauer@pengutronix.de>
>> Cc: Shawn Guo <shawnguo@kernel.org>
>> Cc: Stephen Boyd <sboyd@kernel.org>
>> Cc: devicetree@vger.kernel.org
>> Cc: linux-arm-kernel@lists.infradead.org
>> Cc: linux-clk@vger.kernel.org
>> ---
>>   arch/arm64/boot/dts/freescale/imx8mn.dtsi | 5 +++++
>>   1 file changed, 5 insertions(+)
>>
>> diff --git a/arch/arm64/boot/dts/freescale/imx8mn.dtsi b/arch/arm64/boot/dts/freescale/imx8mn.dtsi
>> index ed9ac6c5047c0..bbec860ef8548 100644
>> --- a/arch/arm64/boot/dts/freescale/imx8mn.dtsi
>> +++ b/arch/arm64/boot/dts/freescale/imx8mn.dtsi
>> @@ -294,6 +294,7 @@ spba2: spba-bus@30000000 {
>>   				ranges;
>>   
>>   				sai2: sai@30020000 {
>> +					#sound-dai-cells = <0>;
> 
> Please don't add it in front of the compatible and the reg property.

The #address-cells and #size-cells are also always on top, why should 
the #sound-dai-cells be any different ? Where should they be ?