* [PATCH v2 0/2] sdm845: Use definitions and deduplicate
@ 2025-08-01 8:21 David Heidelberg via B4 Relay
2025-08-01 8:21 ` [PATCH v2 1/2] arm64: dts: qcom: sdm845*: Use definition for msm-id David Heidelberg via B4 Relay
` (2 more replies)
0 siblings, 3 replies; 8+ messages in thread
From: David Heidelberg via B4 Relay @ 2025-08-01 8:21 UTC (permalink / raw)
To: Bjorn Andersson, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski,
Conor Dooley
Cc: linux-arm-msm, devicetree, linux-kernel, David Heidelberg
Small cleanup.
Signed-off-by: David Heidelberg <david@ixit.cz>
---
Changes in v2:
- Added missing include.
- Link to v1: https://lore.kernel.org/r/20250731-sdm845-msmid-v1-0-98489ece786e@ixit.cz
---
David Heidelberg (2):
arm64: dts: qcom: sdm845*: Use definition for msm-id
arm64: dts: qcom: sdm845-oneplus: Deduplicate shared entries
arch/arm64/boot/dts/qcom/sdm845-db845c.dts | 3 ++-
arch/arm64/boot/dts/qcom/sdm845-oneplus-common.dtsi | 4 ++++
arch/arm64/boot/dts/qcom/sdm845-oneplus-enchilada.dts | 2 --
arch/arm64/boot/dts/qcom/sdm845-oneplus-fajita.dts | 2 --
arch/arm64/boot/dts/qcom/sdm845-shift-axolotl.dts | 3 ++-
arch/arm64/boot/dts/qcom/sdm845-sony-xperia-tama.dtsi | 3 ++-
arch/arm64/boot/dts/qcom/sdm845-xiaomi-beryllium-common.dtsi | 3 ++-
arch/arm64/boot/dts/qcom/sdm845-xiaomi-polaris.dts | 3 ++-
8 files changed, 14 insertions(+), 9 deletions(-)
---
base-commit: 84b92a499e7eca54ba1df6f6c6e01766025943f1
change-id: 20250731-sdm845-msmid-4b08871728dc
Best regards,
--
David Heidelberg <david@ixit.cz>
^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH v2 1/2] arm64: dts: qcom: sdm845*: Use definition for msm-id
2025-08-01 8:21 [PATCH v2 0/2] sdm845: Use definitions and deduplicate David Heidelberg via B4 Relay
@ 2025-08-01 8:21 ` David Heidelberg via B4 Relay
2025-08-01 9:08 ` Krzysztof Kozlowski
2025-08-01 8:21 ` [PATCH v2 2/2] arm64: dts: qcom: sdm845-oneplus: Deduplicate shared entries David Heidelberg via B4 Relay
2025-08-12 3:04 ` [PATCH v2 0/2] sdm845: Use definitions and deduplicate Bjorn Andersson
2 siblings, 1 reply; 8+ messages in thread
From: David Heidelberg via B4 Relay @ 2025-08-01 8:21 UTC (permalink / raw)
To: Bjorn Andersson, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski,
Conor Dooley
Cc: linux-arm-msm, devicetree, linux-kernel, David Heidelberg
From: David Heidelberg <david@ixit.cz>
For all boards it's QCOM_ID_SDM845 except Dragonboard, where it's
QCOM_ID_SDA845.
Except for OnePlus 6 / 6T, which is handled in following commit.
Signed-off-by: David Heidelberg <david@ixit.cz>
---
arch/arm64/boot/dts/qcom/sdm845-db845c.dts | 3 ++-
arch/arm64/boot/dts/qcom/sdm845-shift-axolotl.dts | 3 ++-
arch/arm64/boot/dts/qcom/sdm845-sony-xperia-tama.dtsi | 3 ++-
arch/arm64/boot/dts/qcom/sdm845-xiaomi-beryllium-common.dtsi | 3 ++-
arch/arm64/boot/dts/qcom/sdm845-xiaomi-polaris.dts | 3 ++-
5 files changed, 10 insertions(+), 5 deletions(-)
diff --git a/arch/arm64/boot/dts/qcom/sdm845-db845c.dts b/arch/arm64/boot/dts/qcom/sdm845-db845c.dts
index b5c63fa0365d28fdc4a61dfe67ab6a184e748473..3ec2c7864f1ebb596f1ac2644de58d2f7a2b6faa 100644
--- a/arch/arm64/boot/dts/qcom/sdm845-db845c.dts
+++ b/arch/arm64/boot/dts/qcom/sdm845-db845c.dts
@@ -5,6 +5,7 @@
/dts-v1/;
+#include <dt-bindings/arm/qcom,ids.h>
#include <dt-bindings/leds/common.h>
#include <dt-bindings/pinctrl/qcom,pmic-gpio.h>
#include <dt-bindings/regulator/qcom,rpmh-regulator.h>
@@ -18,7 +19,7 @@
/ {
model = "Thundercomm Dragonboard 845c";
compatible = "thundercomm,db845c", "qcom,sdm845";
- qcom,msm-id = <341 0x20001>;
+ qcom,msm-id = <QCOM_ID_SDA845 0x20001>;
qcom,board-id = <8 0>;
aliases {
diff --git a/arch/arm64/boot/dts/qcom/sdm845-shift-axolotl.dts b/arch/arm64/boot/dts/qcom/sdm845-shift-axolotl.dts
index 2cf7b5e1243caca6a6a0b0beebf52d5f354fe56f..87e913343cbbe7b0d7e0c5b96775b8e759a3a2c6 100644
--- a/arch/arm64/boot/dts/qcom/sdm845-shift-axolotl.dts
+++ b/arch/arm64/boot/dts/qcom/sdm845-shift-axolotl.dts
@@ -7,6 +7,7 @@
/dts-v1/;
+#include <dt-bindings/arm/qcom,ids.h>
#include <dt-bindings/gpio/gpio.h>
#include <dt-bindings/leds/common.h>
#include <dt-bindings/regulator/qcom,rpmh-regulator.h>
@@ -17,7 +18,7 @@
/ {
model = "SHIFT SHIFT6mq";
compatible = "shift,axolotl", "qcom,sdm845";
- qcom,msm-id = <321 0x20001>;
+ qcom,msm-id = <QCOM_ID_SDM845 0x20001>;
qcom,board-id = <11 0>;
aliases {
diff --git a/arch/arm64/boot/dts/qcom/sdm845-sony-xperia-tama.dtsi b/arch/arm64/boot/dts/qcom/sdm845-sony-xperia-tama.dtsi
index a3a304e1ac8737ea2330bfe0ba92008e9fbba6af..f3f4c0900572a85ec173539f09074ae9c1025591 100644
--- a/arch/arm64/boot/dts/qcom/sdm845-sony-xperia-tama.dtsi
+++ b/arch/arm64/boot/dts/qcom/sdm845-sony-xperia-tama.dtsi
@@ -3,6 +3,7 @@
* Copyright (c) 2021, Konrad Dybcio <konrad.dybcio@somainline.org>
*/
+#include <dt-bindings/arm/qcom,ids.h>
#include <dt-bindings/input/input.h>
#include <dt-bindings/pinctrl/qcom,pmic-gpio.h>
#include <dt-bindings/regulator/qcom,rpmh-regulator.h>
@@ -12,7 +13,7 @@
#include "pmi8998.dtsi"
/ {
- qcom,msm-id = <321 0x20001>; /* SDM845 v2.1 */
+ qcom,msm-id = <QCOM_ID_SDM845 0x20001>; /* SDM845 v2.1 */
qcom,board-id = <8 0>;
aliases {
diff --git a/arch/arm64/boot/dts/qcom/sdm845-xiaomi-beryllium-common.dtsi b/arch/arm64/boot/dts/qcom/sdm845-xiaomi-beryllium-common.dtsi
index 7810b0ce7591ecc29e62116a859dcc6b93185b0c..7480c8d7ac5b7f84a742dc6c77943c547c49fafb 100644
--- a/arch/arm64/boot/dts/qcom/sdm845-xiaomi-beryllium-common.dtsi
+++ b/arch/arm64/boot/dts/qcom/sdm845-xiaomi-beryllium-common.dtsi
@@ -2,6 +2,7 @@
/dts-v1/;
+#include <dt-bindings/arm/qcom,ids.h>
#include <dt-bindings/leds/common.h>
#include <dt-bindings/pinctrl/qcom,pmic-gpio.h>
#include <dt-bindings/regulator/qcom,rpmh-regulator.h>
@@ -32,7 +33,7 @@ / {
/* required for bootloader to select correct board */
qcom,board-id = <69 0>;
- qcom,msm-id = <321 0x20001>;
+ qcom,msm-id = <QCOM_ID_SDM845 0x20001>;
aliases {
serial1 = &uart6;
diff --git a/arch/arm64/boot/dts/qcom/sdm845-xiaomi-polaris.dts b/arch/arm64/boot/dts/qcom/sdm845-xiaomi-polaris.dts
index 63cf879a7a297e161c57ba5256d52c9d6cfe9767..1c50a0563bc4728e67fa2dca76bdb6a503ebf102 100644
--- a/arch/arm64/boot/dts/qcom/sdm845-xiaomi-polaris.dts
+++ b/arch/arm64/boot/dts/qcom/sdm845-xiaomi-polaris.dts
@@ -6,6 +6,7 @@
/dts-v1/;
+#include <dt-bindings/arm/qcom,ids.h>
#include <dt-bindings/gpio/gpio.h>
#include <dt-bindings/pinctrl/qcom,pmic-gpio.h>
#include <dt-bindings/regulator/qcom,rpmh-regulator.h>
@@ -38,7 +39,7 @@ / {
chassis-type = "handset";
/* required for bootloader to select correct board */
- qcom,msm-id = <0x141 0x20001>;
+ qcom,msm-id = <QCOM_ID_SDM845 0x20001>;
qcom,board-id = <0x2a 0x0>;
aliases {
--
2.50.1
^ permalink raw reply related [flat|nested] 8+ messages in thread
* [PATCH v2 2/2] arm64: dts: qcom: sdm845-oneplus: Deduplicate shared entries
2025-08-01 8:21 [PATCH v2 0/2] sdm845: Use definitions and deduplicate David Heidelberg via B4 Relay
2025-08-01 8:21 ` [PATCH v2 1/2] arm64: dts: qcom: sdm845*: Use definition for msm-id David Heidelberg via B4 Relay
@ 2025-08-01 8:21 ` David Heidelberg via B4 Relay
2025-08-01 9:08 ` Krzysztof Kozlowski
2025-08-12 3:04 ` [PATCH v2 0/2] sdm845: Use definitions and deduplicate Bjorn Andersson
2 siblings, 1 reply; 8+ messages in thread
From: David Heidelberg via B4 Relay @ 2025-08-01 8:21 UTC (permalink / raw)
To: Bjorn Andersson, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski,
Conor Dooley
Cc: linux-arm-msm, devicetree, linux-kernel, David Heidelberg
From: David Heidelberg <david@ixit.cz>
Use the definition for qcom,msm-id and put them into the common dtsi.
Signed-off-by: David Heidelberg <david@ixit.cz>
---
arch/arm64/boot/dts/qcom/sdm845-oneplus-common.dtsi | 4 ++++
arch/arm64/boot/dts/qcom/sdm845-oneplus-enchilada.dts | 2 --
arch/arm64/boot/dts/qcom/sdm845-oneplus-fajita.dts | 2 --
3 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/arch/arm64/boot/dts/qcom/sdm845-oneplus-common.dtsi b/arch/arm64/boot/dts/qcom/sdm845-oneplus-common.dtsi
index b118d666e535a433f44b66c71b36e55df2ce5c80..dcfffb271fcf3146aeabda8fc19e61b456b76887 100644
--- a/arch/arm64/boot/dts/qcom/sdm845-oneplus-common.dtsi
+++ b/arch/arm64/boot/dts/qcom/sdm845-oneplus-common.dtsi
@@ -7,6 +7,7 @@
/dts-v1/;
+#include <dt-bindings/arm/qcom,ids.h>
#include <dt-bindings/input/linux-event-codes.h>
#include <dt-bindings/leds/common.h>
#include <dt-bindings/regulator/qcom,rpmh-regulator.h>
@@ -21,6 +22,9 @@
/delete-node/ &rmtfs_mem;
/ {
+ chassis-type = "handset";
+ qcom,msm-id = <QCOM_ID_SDM845 0x20001>;
+
aliases {
serial0 = &uart9;
serial1 = &uart6;
diff --git a/arch/arm64/boot/dts/qcom/sdm845-oneplus-enchilada.dts b/arch/arm64/boot/dts/qcom/sdm845-oneplus-enchilada.dts
index 4005e04d998a40d25a64d652a526bf93efc20332..cd5546b69d13d8d7f29373aebab1cfda79666900 100644
--- a/arch/arm64/boot/dts/qcom/sdm845-oneplus-enchilada.dts
+++ b/arch/arm64/boot/dts/qcom/sdm845-oneplus-enchilada.dts
@@ -10,8 +10,6 @@
/ {
model = "OnePlus 6";
compatible = "oneplus,enchilada", "qcom,sdm845";
- chassis-type = "handset";
- qcom,msm-id = <0x141 0x20001>;
qcom,board-id = <8 0 17819 22>;
battery: battery {
diff --git a/arch/arm64/boot/dts/qcom/sdm845-oneplus-fajita.dts b/arch/arm64/boot/dts/qcom/sdm845-oneplus-fajita.dts
index 9471ada0d6ad8bd44cc58a6efa07f7eb27921af9..b4212626b42954e10974ec087db2b42b07979f72 100644
--- a/arch/arm64/boot/dts/qcom/sdm845-oneplus-fajita.dts
+++ b/arch/arm64/boot/dts/qcom/sdm845-oneplus-fajita.dts
@@ -10,8 +10,6 @@
/ {
model = "OnePlus 6T";
compatible = "oneplus,fajita", "qcom,sdm845";
- chassis-type = "handset";
- qcom,msm-id = <0x141 0x20001>;
qcom,board-id = <8 0 18801 41>;
battery: battery {
--
2.50.1
^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [PATCH v2 2/2] arm64: dts: qcom: sdm845-oneplus: Deduplicate shared entries
2025-08-01 8:21 ` [PATCH v2 2/2] arm64: dts: qcom: sdm845-oneplus: Deduplicate shared entries David Heidelberg via B4 Relay
@ 2025-08-01 9:08 ` Krzysztof Kozlowski
2025-08-01 9:38 ` David Heidelberg
2025-08-01 10:31 ` Konrad Dybcio
0 siblings, 2 replies; 8+ messages in thread
From: Krzysztof Kozlowski @ 2025-08-01 9:08 UTC (permalink / raw)
To: david, Bjorn Andersson, Konrad Dybcio, Rob Herring,
Krzysztof Kozlowski, Conor Dooley
Cc: linux-arm-msm, devicetree, linux-kernel
On 01/08/2025 10:21, David Heidelberg via B4 Relay wrote:
> From: David Heidelberg <david@ixit.cz>
>
> Use the definition for qcom,msm-id and put them into the common dtsi.
>
> Signed-off-by: David Heidelberg <david@ixit.cz>
Interesting that they use same ID...
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH v2 1/2] arm64: dts: qcom: sdm845*: Use definition for msm-id
2025-08-01 8:21 ` [PATCH v2 1/2] arm64: dts: qcom: sdm845*: Use definition for msm-id David Heidelberg via B4 Relay
@ 2025-08-01 9:08 ` Krzysztof Kozlowski
0 siblings, 0 replies; 8+ messages in thread
From: Krzysztof Kozlowski @ 2025-08-01 9:08 UTC (permalink / raw)
To: david, Bjorn Andersson, Konrad Dybcio, Rob Herring,
Krzysztof Kozlowski, Conor Dooley
Cc: linux-arm-msm, devicetree, linux-kernel
On 01/08/2025 10:21, David Heidelberg via B4 Relay wrote:
> From: David Heidelberg <david@ixit.cz>
>
> For all boards it's QCOM_ID_SDM845 except Dragonboard, where it's
> QCOM_ID_SDA845.
>
> Except for OnePlus 6 / 6T, which is handled in following commit.
>
> Signed-off-by: David Heidelberg <david@ixit.cz>
> ---
> arch/arm64/boot/dts/qcom/sdm845-db845c.dts | 3 ++-
> arch/arm64/boot/dts/qcom/sdm845-shift-axolotl.dts | 3 ++-
> arch/arm64/boot/dts/qcom/sdm845-sony-xperia-tama.dtsi | 3 ++-
> arch/arm64/boot/dts/qcom/sdm845-xiaomi-beryllium-common.dtsi | 3 ++-
> arch/arm64/boot/dts/qcom/sdm845-xiaomi-polaris.dts | 3 ++-
> 5 files changed, 10 insertions(+), 5 deletions(-)
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH v2 2/2] arm64: dts: qcom: sdm845-oneplus: Deduplicate shared entries
2025-08-01 9:08 ` Krzysztof Kozlowski
@ 2025-08-01 9:38 ` David Heidelberg
2025-08-01 10:31 ` Konrad Dybcio
1 sibling, 0 replies; 8+ messages in thread
From: David Heidelberg @ 2025-08-01 9:38 UTC (permalink / raw)
To: Krzysztof Kozlowski, Bjorn Andersson, Konrad Dybcio, Rob Herring,
Krzysztof Kozlowski, Conor Dooley
Cc: linux-arm-msm, devicetree, linux-kernel
On 01/08/2025 11:08, Krzysztof Kozlowski wrote:
> On 01/08/2025 10:21, David Heidelberg via B4 Relay wrote:
>> From: David Heidelberg <david@ixit.cz>
>>
>> Use the definition for qcom,msm-id and put them into the common dtsi.
>>
>> Signed-off-by: David Heidelberg <david@ixit.cz>
>
> Interesting that they use same ID...
>
> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>
Thank you for the review.
More interestingly, Pixel 3 and Pixel 3 XL does use same qcom,board-id.
> Best regards,
> Krzysztof
--
David Heidelberg
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH v2 2/2] arm64: dts: qcom: sdm845-oneplus: Deduplicate shared entries
2025-08-01 9:08 ` Krzysztof Kozlowski
2025-08-01 9:38 ` David Heidelberg
@ 2025-08-01 10:31 ` Konrad Dybcio
1 sibling, 0 replies; 8+ messages in thread
From: Konrad Dybcio @ 2025-08-01 10:31 UTC (permalink / raw)
To: Krzysztof Kozlowski, david, Bjorn Andersson, Konrad Dybcio,
Rob Herring, Krzysztof Kozlowski, Conor Dooley
Cc: linux-arm-msm, devicetree, linux-kernel
On 8/1/25 11:08 AM, Krzysztof Kozlowski wrote:
> On 01/08/2025 10:21, David Heidelberg via B4 Relay wrote:
>> From: David Heidelberg <david@ixit.cz>
>>
>> Use the definition for qcom,msm-id and put them into the common dtsi.
>>
>> Signed-off-by: David Heidelberg <david@ixit.cz>
>
> Interesting that they use same ID...
msm-id is the SoC identifier
Konrad
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH v2 0/2] sdm845: Use definitions and deduplicate
2025-08-01 8:21 [PATCH v2 0/2] sdm845: Use definitions and deduplicate David Heidelberg via B4 Relay
2025-08-01 8:21 ` [PATCH v2 1/2] arm64: dts: qcom: sdm845*: Use definition for msm-id David Heidelberg via B4 Relay
2025-08-01 8:21 ` [PATCH v2 2/2] arm64: dts: qcom: sdm845-oneplus: Deduplicate shared entries David Heidelberg via B4 Relay
@ 2025-08-12 3:04 ` Bjorn Andersson
2 siblings, 0 replies; 8+ messages in thread
From: Bjorn Andersson @ 2025-08-12 3:04 UTC (permalink / raw)
To: Konrad Dybcio, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
David Heidelberg
Cc: linux-arm-msm, devicetree, linux-kernel
On Fri, 01 Aug 2025 10:21:38 +0200, David Heidelberg wrote:
> Small cleanup.
>
>
Applied, thanks!
[1/2] arm64: dts: qcom: sdm845*: Use definition for msm-id
commit: 285fee8c65efd7969f9376ed9798afece9a0ccc9
[2/2] arm64: dts: qcom: sdm845-oneplus: Deduplicate shared entries
commit: f72f3aac4a9a990701455a4759a49393cd5802d6
Best regards,
--
Bjorn Andersson <andersson@kernel.org>
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2025-08-12 3:04 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-08-01 8:21 [PATCH v2 0/2] sdm845: Use definitions and deduplicate David Heidelberg via B4 Relay
2025-08-01 8:21 ` [PATCH v2 1/2] arm64: dts: qcom: sdm845*: Use definition for msm-id David Heidelberg via B4 Relay
2025-08-01 9:08 ` Krzysztof Kozlowski
2025-08-01 8:21 ` [PATCH v2 2/2] arm64: dts: qcom: sdm845-oneplus: Deduplicate shared entries David Heidelberg via B4 Relay
2025-08-01 9:08 ` Krzysztof Kozlowski
2025-08-01 9:38 ` David Heidelberg
2025-08-01 10:31 ` Konrad Dybcio
2025-08-12 3:04 ` [PATCH v2 0/2] sdm845: Use definitions and deduplicate Bjorn Andersson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).