From: David Heidelberg <david@ixit.cz>
To: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>,
Paul Sajna <sajattack@postmarketos.org>,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konradybcio@kernel.org>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>
Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, phone-devel@vger.kernel.org,
~postmarketos/upstreaming@lists.sr.ht
Subject: Re: [PATCH v2] arm64: dts: qcom: sdm845-lg: Enable NFC
Date: Tue, 15 Sep 2026 21:11:55 +0200 [thread overview]
Message-ID: <a51ddd6e-cd20-4860-98a8-9cc759b7810b@ixit.cz> (raw)
In-Reply-To: <062d0fc6-dcae-4636-ae95-c8144317f0ff@oss.qualcomm.com>
On 09/09/2026 15:16, Konrad Dybcio wrote:
> On 9/6/26 11:32 PM, David Heidelberg wrote:
>> On 06/09/2026 23:11, Paul Sajna wrote:
>>> Add the i2c and tlmm nodes to support the NXP PN547 NFC chip
>>>
>>> Downstream dtsi for reference:
>>> https://github.com/LineageOS/android_kernel_lge_sdm845/blob/lineage-22.2/arch/arm64/boot/dts/lge/sdm845-judy/sdm845-judyln_lao_com/sdm845-judyln_lao_com-nfc.dtsi
>>>
>>> Signed-off-by: Paul Sajna <sajattack@postmarketos.org>
>>> ---
>
> [...]
>
>>> + nfc_default: nfc-default-state {
>>> + pins = "gpio12", "gpio62", "gpio63", "gpio116";
>>
>> here the verbosity may not be bad (device-tree functions as documentation too)
>> gpio116 is associated with eSE NFC part (just guessing, but... it worked before, so), and generally the pn547 doesn't need it at all to work.
>>
>> TBH not sure if there or what consensus is here about this. The eSE needs it, but we don't have the driver thus also no integration with NFC part.
>
> The eSE driver would still be acting on the NFC node, right?
So far that's the Android design. So, yes.
David
>
> Konrad
next prev parent reply other threads:[~2026-09-15 19:12 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-06 21:11 [PATCH v2] arm64: dts: qcom: sdm845-lg: Enable NFC Paul Sajna
2026-09-06 21:32 ` David Heidelberg
2026-09-09 13:16 ` Konrad Dybcio
2026-09-15 19:11 ` David Heidelberg [this message]
2026-09-30 12:37 ` Konrad Dybcio
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a51ddd6e-cd20-4860-98a8-9cc759b7810b@ixit.cz \
--to=david@ixit.cz \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=konrad.dybcio@oss.qualcomm.com \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=phone-devel@vger.kernel.org \
--cc=robh@kernel.org \
--cc=sajattack@postmarketos.org \
--cc=~postmarketos/upstreaming@lists.sr.ht \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox