devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Andreas Färber" <afaerber@suse.de>
To: Martyn Welch <martyn.welch@collabora.com>
Cc: "Shawn Guo" <shawnguo@kernel.org>,
	"Sascha Hauer" <s.hauer@pengutronix.de>,
	"Rob Herring" <robh+dt@kernel.org>,
	"Mark Rutland" <mark.rutland@arm.com>,
	"Fabio Estevam" <fabio.estevam@nxp.com>,
	devicetree@vger.kernel.org, "Christian Hemp" <c.hemp@phytec.de>,
	"Stefan Riedmüller" <s.riedmueller@phytec.de>,
	"Pengutronix Kernel Team" <kernel@pengutronix.de>,
	linux-arm-kernel@lists.infradead.org,
	"NXP Linux Team" <linux-imx@nxp.com>,
	"Rob Herring" <robh@kernel.org>,
	"Martin Blumenstingl" <martin.blumenstingl@googlemail.com>,
	"Thierry Reding" <treding@nvidia.com>,
	linux-kernel@vger.kernel.org,
	"Kevin Hilman" <khilman@baylibre.com>,
	"Johan Hovold" <johan@kernel.org>
Subject: Re: [PATCH v2 1/2] dt-bindings: Add vendor prefix for Catalyst Semiconductor
Date: Sat, 19 Jan 2019 12:30:14 +0100	[thread overview]
Message-ID: <a5349edd-015f-75da-c47d-90e931f99d43@suse.de> (raw)
In-Reply-To: <20190118194812.3319-1-martyn.welch@collabora.com>

Hi Martyn,

Am 18.01.19 um 20:48 schrieb Martyn Welch:
> Add vendor prefix "catalyst" for Catalyst Semiconductor which is
> already in use but undocumented.
> 
> Signed-off-by: Martyn Welch <martyn.welch@collabora.com>
> Reviewed-by: Rob Herring <robh@kernel.org>
> ---
> 
> Changes in v2: None
> 
>  Documentation/devicetree/bindings/vendor-prefixes.txt | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/Documentation/devicetree/bindings/vendor-prefixes.txt b/Documentation/devicetree/bindings/vendor-prefixes.txt
> index 389508584f48..d80b23b7771f 100644
> --- a/Documentation/devicetree/bindings/vendor-prefixes.txt
> +++ b/Documentation/devicetree/bindings/vendor-prefixes.txt
> @@ -65,6 +65,7 @@ bticino Bticino International
>  calxeda	Calxeda
>  capella	Capella Microsystems, Inc
>  cascoda	Cascoda, Ltd.
> +catalyst	Catalyst Semiconductor, Inc

"Inc" surely is an abbreviation for "Incorporated", so can you please
follow the below examples of writing "Inc." with trailing dot?

>  cavium	Cavium, Inc.
>  cdns	Cadence Design Systems Inc.
>  cdtech	CDTech(H.K.) Electronics Limited

Otherwise looks good. Thanks for fixing the undocumented use.

Regards,
Andreas

-- 
SUSE Linux GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG Nürnberg)

      parent reply	other threads:[~2019-01-19 11:30 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-01-18 19:48 [PATCH v2 1/2] dt-bindings: Add vendor prefix for Catalyst Semiconductor Martyn Welch
2019-01-18 19:48 ` [PATCH v2 2/2] ARM: dts: imx6: Add support for Phytec phyBOARD i.MX6UL Segin Martyn Welch
2019-01-18 21:18   ` Fabio Estevam
2019-01-21  9:40     ` Martyn Welch
2019-01-19 11:30 ` Andreas Färber [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a5349edd-015f-75da-c47d-90e931f99d43@suse.de \
    --to=afaerber@suse.de \
    --cc=c.hemp@phytec.de \
    --cc=devicetree@vger.kernel.org \
    --cc=fabio.estevam@nxp.com \
    --cc=johan@kernel.org \
    --cc=kernel@pengutronix.de \
    --cc=khilman@baylibre.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-imx@nxp.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=martin.blumenstingl@googlemail.com \
    --cc=martyn.welch@collabora.com \
    --cc=robh+dt@kernel.org \
    --cc=robh@kernel.org \
    --cc=s.hauer@pengutronix.de \
    --cc=s.riedmueller@phytec.de \
    --cc=shawnguo@kernel.org \
    --cc=treding@nvidia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).