From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Biju Das <biju.das.jz@bp.renesas.com>,
Alessandro Zummo <a.zummo@towertech.it>,
Alexandre Belloni <alexandre.belloni@bootlin.com>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>
Cc: Trent Piepho <tpiepho@gmail.com>,
linux-rtc@vger.kernel.org, devicetree@vger.kernel.org,
Geert Uytterhoeven <geert+renesas@glider.be>,
Fabrizio Castro <fabrizio.castro.jz@renesas.com>,
linux-renesas-soc@vger.kernel.org
Subject: Re: [PATCH v3] dt-bindings: rtc: isl1208: Convert to json-schema
Date: Fri, 5 May 2023 20:10:41 +0200 [thread overview]
Message-ID: <a55c7ac8-1037-4509-a16e-83c7894b1a4d@linaro.org> (raw)
In-Reply-To: <20230505091720.115675-1-biju.das.jz@bp.renesas.com>
On 05/05/2023 11:17, Biju Das wrote:
> Convert the isl1208 RTC device tree binding documentation to json-schema.
>
> Update the example to match reality.
>
> Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com>
Thank you for your patch. There is something to discuss/improve.
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/rtc/isil,isl1208.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Intersil ISL1209/19 I2C RTC/Alarm chip with event in
> +
> +maintainers:
> + - Trent Piepho <tpiepho@gmail.com>
> +
> +description: |
Do not need '|' unless you need to preserve formatting.
> + ISL12X9 have additional pins EVIN and #EVDET for tamper detection, while the
> + ISL1208 and ISL1218 do not.
> +
> +properties:
> + compatible:
> + oneOf:
It's not oneOf, but only enum.
> + - enum:
> + - isil,isl1208
> + - isil,isl1209
> + - isil,isl1218
> + - isil,isl1219
> +
With above fixed:
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Best regards,
Krzysztof
next prev parent reply other threads:[~2023-05-05 18:10 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-05 9:17 [PATCH v3] dt-bindings: rtc: isl1208: Convert to json-schema Biju Das
2023-05-05 18:10 ` Krzysztof Kozlowski [this message]
2023-05-09 10:48 ` Biju Das
2023-05-09 11:18 ` Biju Das
2023-05-09 12:59 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a55c7ac8-1037-4509-a16e-83c7894b1a4d@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=a.zummo@towertech.it \
--cc=alexandre.belloni@bootlin.com \
--cc=biju.das.jz@bp.renesas.com \
--cc=devicetree@vger.kernel.org \
--cc=fabrizio.castro.jz@renesas.com \
--cc=geert+renesas@glider.be \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=linux-rtc@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=tpiepho@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).