From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 34251C7EE24 for ; Fri, 5 May 2023 18:10:55 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233282AbjEESKx (ORCPT ); Fri, 5 May 2023 14:10:53 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37596 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233265AbjEESKv (ORCPT ); Fri, 5 May 2023 14:10:51 -0400 Received: from mail-ed1-x52f.google.com (mail-ed1-x52f.google.com [IPv6:2a00:1450:4864:20::52f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5AE251E9B6 for ; Fri, 5 May 2023 11:10:44 -0700 (PDT) Received: by mail-ed1-x52f.google.com with SMTP id 4fb4d7f45d1cf-50c8d87c775so1647838a12.3 for ; Fri, 05 May 2023 11:10:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1683310243; x=1685902243; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=DQBt9O9556cUDwM/8n6L+XNwPkEzkVWxHyZle1gkXm0=; b=dhCOOHqjNDYtwBV3y73eG5mx+qh8+rmCCbutjJWAHpGAuo3a1SADNxeP7V6Ej4h9O9 GRqFToP2+KM9688fe0iJg6slfqOGXJxkL4cNLxNnxbG6oeG/2hKLy/Jb7UeqfSVDR5MB fW0WGcWirra+BdzZDuYZcYUuB3rEDiVxH8XCLgOjQZ8ghU/AEOXxMg+HxeRQjfRJzduS ymW5eF5bXMX/goxPRjvg0Px9eeHwH6PDNPz12dGdqsIWgkgjhaIdRH+nC8Q11QRNljcV tqRtsROP7PV9wJzfuUtszTYN3vooF3cWh332P4iLzkRZHVaWmkeni38bXNidH6MnDFiO 0o/g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1683310243; x=1685902243; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=DQBt9O9556cUDwM/8n6L+XNwPkEzkVWxHyZle1gkXm0=; b=GDoCW6gdcTTCh41Oky90hBkbvlnlOriUt4b6od8PkReaEJg3AHIjiDUvW4yxxXwBC9 6uPIWkcSpj4nrLZLek04S4nGkKR16QQI3HaT9gTYRbT8iNQobUydLa5S40YBQP2kMrnf sK+BKwZVocJoKWXDWrAxA3LJ73WkFCSHzQOwnWqAh1QhfnRWNGvAlhy/ZD3KzSuiROMk KzrvDU4D636PXBMNSCVwkr6Zr1Z/O8SHrU1WSs9VM6bBPj/3PLHADTFRV+nwMcn1LFi1 3niHbhlMHM28jEJt4Gz0TeiFFga83UuPSzv+A61yFTlSGSBX3ucfIkBwYsrObJ4yY1vo QVDA== X-Gm-Message-State: AC+VfDzI+ZC/Z80q8b/nYJvnOq8Yf8HJgN4DQ5eudqwtuJqwv+GovRZh qwJo3gRDw9odOgRIbYbvQeOxcA== X-Google-Smtp-Source: ACHHUZ4CkUu61HPatWQxUGhsYIa4QfVRdHuzWrcLP3IPxF7Im7eghSPNTBdRv5T7vdAgjVLiF3c/nw== X-Received: by 2002:a17:907:3207:b0:957:48c8:b081 with SMTP id xg7-20020a170907320700b0095748c8b081mr1435683ejb.24.1683310242848; Fri, 05 May 2023 11:10:42 -0700 (PDT) Received: from ?IPV6:2a02:810d:15c0:828:52e:24ce:bbc1:127d? ([2a02:810d:15c0:828:52e:24ce:bbc1:127d]) by smtp.gmail.com with ESMTPSA id t26-20020a17090616da00b0094ee700d8e4sm1233010ejd.44.2023.05.05.11.10.41 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 05 May 2023 11:10:42 -0700 (PDT) Message-ID: Date: Fri, 5 May 2023 20:10:41 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.10.1 Subject: Re: [PATCH v3] dt-bindings: rtc: isl1208: Convert to json-schema Content-Language: en-US To: Biju Das , Alessandro Zummo , Alexandre Belloni , Rob Herring , Krzysztof Kozlowski Cc: Trent Piepho , linux-rtc@vger.kernel.org, devicetree@vger.kernel.org, Geert Uytterhoeven , Fabrizio Castro , linux-renesas-soc@vger.kernel.org References: <20230505091720.115675-1-biju.das.jz@bp.renesas.com> From: Krzysztof Kozlowski In-Reply-To: <20230505091720.115675-1-biju.das.jz@bp.renesas.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 05/05/2023 11:17, Biju Das wrote: > Convert the isl1208 RTC device tree binding documentation to json-schema. > > Update the example to match reality. > > Signed-off-by: Biju Das Thank you for your patch. There is something to discuss/improve. > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/rtc/isil,isl1208.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Intersil ISL1209/19 I2C RTC/Alarm chip with event in > + > +maintainers: > + - Trent Piepho > + > +description: | Do not need '|' unless you need to preserve formatting. > + ISL12X9 have additional pins EVIN and #EVDET for tamper detection, while the > + ISL1208 and ISL1218 do not. > + > +properties: > + compatible: > + oneOf: It's not oneOf, but only enum. > + - enum: > + - isil,isl1208 > + - isil,isl1209 > + - isil,isl1218 > + - isil,isl1219 > + With above fixed: Reviewed-by: Krzysztof Kozlowski Best regards, Krzysztof