Devicetree
 help / color / mirror / Atom feed
From: Frieder Schrempf <frieder.schrempf@kontron.de>
To: Frank Li <Frank.li@nxp.com>, Frieder Schrempf <frieder@fris.de>
Cc: linux-arm-kernel@lists.infradead.org,
	Conor Dooley <conor+dt@kernel.org>,
	devicetree@vger.kernel.org, imx@lists.linux.dev,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	linux-kernel@vger.kernel.org, Rob Herring <robh@kernel.org>,
	Sascha Hauer <s.hauer@pengutronix.de>,
	Shawn Guo <shawnguo@kernel.org>,
	Eberhard Stoll <eberhard.stoll@kontron.de>,
	Fabio Estevam <festevam@gmail.com>,
	Pengutronix Kernel Team <kernel@pengutronix.de>
Subject: Re: [PATCH v2 1/2] ARM: dts: imx6ul-kontron-sl-common: Add SPI NOR partitions
Date: Wed, 9 Jul 2025 09:18:21 +0200	[thread overview]
Message-ID: <a5712254-bb68-429d-9297-bd334ee568bd@kontron.de> (raw)
In-Reply-To: <aG1cCK1U7cs+Jf1n@lizhi-Precision-Tower-5810>

Am 08.07.25 um 19:57 schrieb Frank Li:
> On Tue, Jul 08, 2025 at 02:56:04PM +0200, Frieder Schrempf wrote:
>> From: Eberhard Stoll <eberhard.stoll@kontron.de>
>>
>> Describe the partitions for the bootloader and the environment
>> on the SPI NOR.
>>
>> Signed-off-by: Eberhard Stoll <eberhard.stoll@kontron.de>
>> Signed-off-by: Frieder Schrempf <frieder.schrempf@kontron.de>
>> ---
>> Changes for v2:
>> * Fix name order in SoB
>> ---
>>  .../dts/nxp/imx/imx6ul-kontron-sl-common.dtsi | 21 +++++++++++++++++++
>>  1 file changed, 21 insertions(+)
>>
>> diff --git a/arch/arm/boot/dts/nxp/imx/imx6ul-kontron-sl-common.dtsi b/arch/arm/boot/dts/nxp/imx/imx6ul-kontron-sl-common.dtsi
>> index dcf88f6103466..ab149c40a9cc1 100644
>> --- a/arch/arm/boot/dts/nxp/imx/imx6ul-kontron-sl-common.dtsi
>> +++ b/arch/arm/boot/dts/nxp/imx/imx6ul-kontron-sl-common.dtsi
>> @@ -28,6 +28,27 @@ flash@0 {
>>  		compatible = "mxicy,mx25v8035f", "jedec,spi-nor";
>>  		spi-max-frequency = <50000000>;
>>  		reg = <0>;
>> +
>> +		partitions {
>> +			compatible = "fixed-partitions";
>> +			#address-cells = <1>;
>> +			#size-cells = <1>;
>> +
>> +			partition@0 {
>> +				label = "u-boot";
>> +				reg = <0x0 0xf0000>;
> 
> I think reg should first property.
> first is 'compatible', the second is 'reg'.

Thanks! Now fixed in v3.

      reply	other threads:[~2025-07-09  7:18 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-07-08 12:56 [PATCH v2 1/2] ARM: dts: imx6ul-kontron-sl-common: Add SPI NOR partitions Frieder Schrempf
2025-07-08 12:56 ` [PATCH v2 2/2] ARM: dts: imx6ul-kontron-sl-common: Fix QSPI NAND node name Frieder Schrempf
2025-07-08 17:55   ` Frank Li
2025-07-08 17:57 ` [PATCH v2 1/2] ARM: dts: imx6ul-kontron-sl-common: Add SPI NOR partitions Frank Li
2025-07-09  7:18   ` Frieder Schrempf [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a5712254-bb68-429d-9297-bd334ee568bd@kontron.de \
    --to=frieder.schrempf@kontron.de \
    --cc=Frank.li@nxp.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=eberhard.stoll@kontron.de \
    --cc=festevam@gmail.com \
    --cc=frieder@fris.de \
    --cc=imx@lists.linux.dev \
    --cc=kernel@pengutronix.de \
    --cc=krzk+dt@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=robh@kernel.org \
    --cc=s.hauer@pengutronix.de \
    --cc=shawnguo@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox