[PATCH 1/1] add rgb888 pins to a20 to enable parallel rgb LCD

[PATCH 1/1] add rgb888 pins to a20 to enable parallel rgb LCD

[Giulio Benetti]

On sun7i-a20-* there's no way to enable PA00--PA27 as RGB888 LCD0 pins.

Add lcd_rgb888_pins in sun7i-a20.dtsi.

It can be used on sun7i-a20-olinuxino-lime.dts.
This patch gives possibility to set parallel lcd pins for RGB888.
To be used with tcon0 in your <target>.dts

Best regards
Giulio Benetti
Micronova srl

Signed-off-by: Giulio Benetti <giulio.benetti-W14uJ/fiAyBY2hyreNRi6g@public.gmane.org>
---
 arch/arm/boot/dts/sun7i-a20.dtsi | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/arch/arm/boot/dts/sun7i-a20.dtsi b/arch/arm/boot/dts/sun7i-a20.dtsi
index 228c368..b85a917 100644
--- a/arch/arm/boot/dts/sun7i-a20.dtsi
+++ b/arch/arm/boot/dts/sun7i-a20.dtsi
@@ -921,6 +921,14 @@
 				pins = "PI20", "PI21";
 				function = "uart7";
 			};
+
+			lcd_rgb888_pins: lcd-rgb888 {
+				pins = "PD0", "PD1", "PD2", "PD3", "PD4", "PD5", "PD6", "PD7", 
+					"PD8", "PD9", "PD10", "PD11", "PD12", "PD13", "PD14", "PD15",
+					"PD16", "PD17", "PD18", "PD19", "PD20", "PD21", "PD22", "PD23",
+					"PD24", "PD25", "PD26", "PD27";
+				function = "lcd0";
+			};
 		};
 
 		timer@1c20c00 {
-- 
2.7.4

Re: [PATCH 1/1] add rgb888 pins to a20 to enable parallel rgb LCD

[Maxime Ripard]

[-- Attachment #1: Type: text/plain, Size: 655 bytes --]

On Tue, Nov 07, 2017 at 01:49:59PM +0100, Giulio Benetti wrote:
> On sun7i-a20-* there's no way to enable PA00--PA27 as RGB888 LCD0 pins.
> 
> Add lcd_rgb888_pins in sun7i-a20.dtsi.
> 
> It can be used on sun7i-a20-olinuxino-lime.dts.
> This patch gives possibility to set parallel lcd pins for RGB888.
> To be used with tcon0 in your <target>.dts

My question was on which board do you want to use it right now. If the
answer is none, then we won't merge that patch, we have too many
pinctrl already to not add the unused ones.

Maxime

-- 
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 801 bytes --]

Re: [PATCH 1/1] add rgb888 pins to a20 to enable parallel rgb LCD

[Giulio Benetti]

Board could be any with A20,
for example Olinuxino A20.
Or our Q027, S027 boards, but final dts still are not complete.

-- 
Giulio Benetti
R&D Manager &
Advanced Research

MICRONOVA SRL
Sede: Via A. Niedda 3 - 35010 Vigonza (PD)
Tel. 049/8931563 - Fax 049/8931346
Cod.Fiscale - P.IVA 02663420285
Capitale Sociale € 26.000 i.v.
Iscritta al Reg. Imprese di Padova N. 02663420285
Numero R.E.A. 258642

Il 07/11/2017 14:03, Maxime Ripard ha scritto:
> On Tue, Nov 07, 2017 at 01:49:59PM +0100, Giulio Benetti wrote:
>> On sun7i-a20-* there's no way to enable PA00--PA27 as RGB888 LCD0 pins.
>>
>> Add lcd_rgb888_pins in sun7i-a20.dtsi.
>>
>> It can be used on sun7i-a20-olinuxino-lime.dts.
>> This patch gives possibility to set parallel lcd pins for RGB888.
>> To be used with tcon0 in your <target>.dts
> 
> My question was on which board do you want to use it right now. If the
> answer is none, then we won't merge that patch, we have too many
> pinctrl already to not add the unused ones.
> 
> Maxime
> 
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH 1/1] add rgb888 pins to a20 to enable parallel rgb LCD

[Maxime Ripard]

[-- Attachment #1: Type: text/plain, Size: 418 bytes --]

Hi,

On Tue, Nov 07, 2017 at 05:38:55PM +0100, Giulio Benetti wrote:
> Board could be any with A20,
> for example Olinuxino A20.
> Or our Q027, S027 boards, but final dts still are not complete.

Therefore no upstream boards are using it right now, so we'll merge it
when that will be the case.

Maxime

-- 
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 801 bytes --]

Re: [PATCH 1/1] add rgb888 pins to a20 to enable parallel rgb LCD

[Icenowy Zheng]

在 2017-11-08 18:56，Maxime Ripard 写道：
> Hi,
> 
> On Tue, Nov 07, 2017 at 05:38:55PM +0100, Giulio Benetti wrote:
>> Board could be any with A20,
>> for example Olinuxino A20.
>> Or our Q027, S027 boards, but final dts still are not complete.
> 
> Therefore no upstream boards are using it right now, so we'll merge it
> when that will be the case.

I think the LCD connector on Banana Pi's uses parallel interface,
although the LCD should be an external DT overlay.

> 
> Maxime
> 
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

-- 
You received this message because you are subscribed to the Google Groups "linux-sunxi" group.
To unsubscribe from this group and stop receiving emails from it, send an email to linux-sunxi+unsubscribe-/JYPxA39Uh5TLH3MbocFF+G/Ez6ZCGd0@public.gmane.org
For more options, visit https://groups.google.com/d/optout.

[PATCH 1/1] add rgb888 pins to a20 to enable parallel rgb LCD

[Giulio Benetti]

This patch gives possibility to set parallel lcd pins for RGB888.
To be used with tcon0 in your <target>.dts

Best regards
Giulio Benetti
Micronova srl

Signed-off-by: Giulio Benetti <giulio.benetti@micronovasrl.com>
---
 arch/arm/boot/dts/sun7i-a20.dtsi | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/arch/arm/boot/dts/sun7i-a20.dtsi b/arch/arm/boot/dts/sun7i-a20.dtsi
index 228c368..b85a917 100644
--- a/arch/arm/boot/dts/sun7i-a20.dtsi
+++ b/arch/arm/boot/dts/sun7i-a20.dtsi
@@ -921,6 +921,14 @@
 				pins = "PI20", "PI21";
 				function = "uart7";
 			};
+
+			lcd_rgb888_pins: lcd-rgb888@0 {
+				pins = "PD0", "PD1", "PD2", "PD3", "PD4", "PD5", "PD6", "PD7", 
+					"PD8", "PD9", "PD10", "PD11", "PD12", "PD13", "PD14", "PD15",
+					"PD16", "PD17", "PD18", "PD19", "PD20", "PD21", "PD22", "PD23",
+					"PD24", "PD25", "PD26", "PD27";
+				function = "lcd0";
+			};
 		};
 
 		timer@1c20c00 {
-- 
2.7.4

Re: [PATCH 1/1] add rgb888 pins to a20 to enable parallel rgb LCD

[Maxime Ripard]

[-- Attachment #1: Type: text/plain, Size: 518 bytes --]

Hi,

On Tue, Nov 07, 2017 at 11:32:39AM +0100, Giulio Benetti wrote:
> This patch gives possibility to set parallel lcd pins for RGB888.
> To be used with tcon0 in your <target>.dts
> 
> Best regards
> Giulio Benetti
> Micronova srl

This isn't a cover letter, but a commit log. You should document why
and how you did that change, nothing else.

On what board is this supposed to be used?

Maxime

-- 
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 801 bytes --]

[PATCH 1/1] add rgb888 pins to a20 to enable parallel rgb LCD

[Giulio Benetti]

This patch gives possibility to set parallel lcd pins for RGB888.
To be used with tcon0 in your <target>.dts

Best regards
Giulio Benetti
Micronova srl

Signed-off-by: Giulio Benetti <giulio.benetti@micronovasrl.com>
---
 arch/arm/boot/dts/sun7i-a20.dtsi | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/arch/arm/boot/dts/sun7i-a20.dtsi b/arch/arm/boot/dts/sun7i-a20.dtsi
index 228c368..2e38dd3 100644
--- a/arch/arm/boot/dts/sun7i-a20.dtsi
+++ b/arch/arm/boot/dts/sun7i-a20.dtsi
@@ -921,6 +921,14 @@
 				pins = "PI20", "PI21";
 				function = "uart7";
 			};
+
+			lcd_rgb888_pins: lcd-rgb888 {
+				pins = "PD0", "PD1", "PD2", "PD3", "PD4", "PD5", "PD6", "PD7", 
+					"PD8", "PD9", "PD10", "PD11", "PD12", "PD13", "PD14", "PD15",
+					"PD16", "PD17", "PD18", "PD19", "PD20", "PD21", "PD22", "PD23",
+					"PD24", "PD25", "PD26", "PD27";
+				function = "lcd0";
+			};
 		};
 
 		timer@1c20c00 {
-- 
2.7.4