From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9ED0FCCA47F for ; Wed, 8 Jun 2022 00:55:54 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232026AbiFHAso (ORCPT ); Tue, 7 Jun 2022 20:48:44 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54212 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1578222AbiFGXby (ORCPT ); Tue, 7 Jun 2022 19:31:54 -0400 Received: from mail-wr1-x42c.google.com (mail-wr1-x42c.google.com [IPv6:2a00:1450:4864:20::42c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8421E24DE45 for ; Tue, 7 Jun 2022 15:01:17 -0700 (PDT) Received: by mail-wr1-x42c.google.com with SMTP id q15so17851496wrc.11 for ; Tue, 07 Jun 2022 15:01:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=s6eUytmYYH9eaFCb5BVA3b/HOVsknK+p7KhgU38haew=; b=E2h+B4WVymgBM89H4QgZ9vQhnCsaEJYbb7lOrS2qb5RTeZ5udsn3fj8+TRDWNjFr1B bzmpDTl59hTJUgdcMAMeuT8IIA3506G3XtTcuS4+nSR0GjPFo2v6NpZ1DuTZPrACIBq/ BT3zVg9x5BSj2CnyZAzcsT4ugBeHosgk4olwwFTyuqvciybGgYXHmOpRVYP/rt4YduCh F9tzLl9uEcFV7XCPi+CciXIuAahblG3Jm92S383mljC54/d8p37XrGv04aN4SWskswK3 LMyL2+cVLgI7aZGhF1lo7sL95/JlS9B8EFTrOFZ+MgrI1PW9tvN5TVoKpmJkKKzXq2MI JIWg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=s6eUytmYYH9eaFCb5BVA3b/HOVsknK+p7KhgU38haew=; b=OlqmbY3tuKRsmN8uPqTmnGpI5OxzXj2npjQxO9T0oCEcD2CiI32x4tpOkzoVOe3KLx /G/dOeeoM8pH8AFjFI1t4KiX6aqrePTgPW+yxamFdUAg5ake56QqJcVtQIWdBvpJU3tZ NDlj6+pKMlx1DiAp3QoCUt5sKpJ+l8cDB57lDopLth/zPxam8Ybgjaw+X58NNnlAjR0c UV7o5lT8wS7GwSR7b24wrddNl4wln9UiZc/j/2KSP0BGK0PmveMBGHsfR0nr9slvoiSZ BjUqwSKtto9FTd5/N6W6dGdqPfHKUrm2/F6V7YQIv4vh6MvmEZHrChHxV+PxP3OVDV9y aF0A== X-Gm-Message-State: AOAM532W6ZjIvOmn1voIPA82Zj1w1T2GDO0/HrlDyfTZPiQxnezLMQzv i1Vow5yQ0NpJdUjgxBpnYGFMgw== X-Google-Smtp-Source: ABdhPJxZFR9ehraU6LkCn1t7uDVmpo6MoOSGm0Um+kWtjQ37jsrFZNmhCkkLVM0FY0gteaYaCbgGTA== X-Received: by 2002:a5d:64c1:0:b0:20f:d995:f896 with SMTP id f1-20020a5d64c1000000b0020fd995f896mr29438432wri.180.1654639275977; Tue, 07 Jun 2022 15:01:15 -0700 (PDT) Received: from [192.168.0.162] (188-141-3-169.dynamic.upc.ie. [188.141.3.169]) by smtp.gmail.com with ESMTPSA id z13-20020adfe54d000000b002103cfd2fbasm20129267wrm.65.2022.06.07.15.01.14 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 07 Jun 2022 15:01:15 -0700 (PDT) Message-ID: Date: Tue, 7 Jun 2022 23:01:14 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.9.0 Subject: Re: [PATCH 0/2] Add imx577 compatible to imx412 Content-Language: en-US To: Kieran Bingham , daniele.alessandrelli@intel.com, devicetree@vger.kernel.org, jacopo@jmondi.org, linux-media@vger.kernel.org, mchehab@kernel.org, paul.j.murphy@intel.com, sakari.ailus@iki.fi Cc: dmitry.baryshkov@linaro.org, konrad.dybcio@somainline.org, andrey.konovalov@linaro.org References: <20220607134057.2427663-1-bryan.odonoghue@linaro.org> <165463899225.186364.3363631428060807036@Monstersaurus> From: Bryan O'Donoghue In-Reply-To: <165463899225.186364.3363631428060807036@Monstersaurus> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 07/06/2022 22:56, Kieran Bingham wrote: > Quoting Bryan O'Donoghue (2022-06-07 14:40:55) >> Right now the imx412 and imx577 are code and pin compatible however, they >> are distinct pieces of silicon. >> >> Document imx577 as a compatible enum and add the compat string to imx412.c. >> This allows us to differentiate these chips in DTS and potentially to apply >> any future imx412 or imx577 specific changes appropriately. > While I think this is probably fine to get things working, there seems to > be quite a few extra features in the IMX577 [0] compared with the IMX412 [1]. > > [0]https://www.sony-semicon.co.jp/products/common/pdf/IMX412-AACK_Flyer03.pdf > [1]https://www.sony-semicon.co.jp/products/common/pdf/IMX577-AACK_Flyer.pdf > > I certainly agree though that it's better to declare the camera > correctly in the DT - so it's better to add this support than 'fake' the > DT to say it's an IMX412 on the platform. Agreed the specs differ but the only silicon enabling code I have access to - from the qcom camx release is a 1:1 for 412 and 577. The init process works for me on rb5 to obtain 10 bit bayer @ 30 fps. Agreed the 577 does a whole bunch of extra stuff I just have no reference either in PDF or code on how to do any of it. Its "good enough" for me in 412 mode. --- bod