From: Krzysztof Kozlowski <krzk@kernel.org>
To: "João Paulo Gonçalves" <jpaulo.silvagoncalves@gmail.com>,
"Nishanth Menon" <nm@ti.com>,
"Vignesh Raghavendra" <vigneshr@ti.com>,
"Tero Kristo" <kristo@kernel.org>,
"Rob Herring" <robh@kernel.org>,
"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
"Conor Dooley" <conor+dt@kernel.org>
Cc: "João Paulo Gonçalves" <joao.goncalves@toradex.com>,
linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1] arm64: dts: ti: k3-am62-verdin: Update tla2024 adc compatible
Date: Tue, 1 Oct 2024 13:54:56 +0200 [thread overview]
Message-ID: <a5890be6-914c-48cc-9abd-761961ccb7ca@kernel.org> (raw)
In-Reply-To: <20241001111413.10390-1-jpaulo.silvagoncalves@gmail.com>
On 01/10/2024 13:14, João Paulo Gonçalves wrote:
> From: João Paulo Gonçalves <joao.goncalves@toradex.com>
>
> With commit f1c9ce0ced2d ("iio: adc: ti-ads1015: Add TLA2024 support") a
> new compatible was introduced for TLA2024 ADC. Update the device
> tree to use the correct compatible for the Verdin-AM62 hardware.
>
> Signed-off-by: João Paulo Gonçalves <joao.goncalves@toradex.com>
> ---
> arch/arm64/boot/dts/ti/k3-am62-verdin.dtsi | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm64/boot/dts/ti/k3-am62-verdin.dtsi b/arch/arm64/boot/dts/ti/k3-am62-verdin.dtsi
> index 5bef31b8577b..f201722d81b3 100644
> --- a/arch/arm64/boot/dts/ti/k3-am62-verdin.dtsi
> +++ b/arch/arm64/boot/dts/ti/k3-am62-verdin.dtsi
> @@ -1220,7 +1220,7 @@ sensor@48 {
> };
>
> adc@49 {
> - compatible = "ti,ads1015";
> + compatible = "ti,tla2024";
So it is not always TI, who breaks their users. :) (as pointed out in
LPC DT BoF).
If you want to break users, sure, but at least explain in commit msg why.
Best regards,
Krzysztof
next prev parent reply other threads:[~2024-10-01 11:55 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-01 11:14 [PATCH v1] arm64: dts: ti: k3-am62-verdin: Update tla2024 adc compatible João Paulo Gonçalves
2024-10-01 11:26 ` Francesco Dolcini
2024-10-01 11:54 ` Krzysztof Kozlowski [this message]
2024-10-01 13:01 ` Francesco Dolcini
2024-10-01 13:59 ` Krzysztof Kozlowski
2024-10-01 14:13 ` Francesco Dolcini
2024-10-02 13:52 ` Nishanth Menon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a5890be6-914c-48cc-9abd-761961ccb7ca@kernel.org \
--to=krzk@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=joao.goncalves@toradex.com \
--cc=jpaulo.silvagoncalves@gmail.com \
--cc=kristo@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nm@ti.com \
--cc=robh@kernel.org \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).