From: Fabio Estevam <festevam@denx.de>
To: Conor Dooley <conor@kernel.org>
Cc: Fabio Estevam <festevam@gmail.com>,
daniel.lezcano@linaro.org, rafael@kernel.org,
krzysztof.kozlowski+dt@linaro.org, robh+dt@kernel.org,
conor+dt@kernel.org, linux-pm@vger.kernel.org,
devicetree@vger.kernel.org
Subject: Re: [PATCH v3] dt-bindings: thermal: qoriq-thermal: Adjust fsl,tmu-range min/maxItems
Date: Sat, 09 Dec 2023 17:59:17 -0300 [thread overview]
Message-ID: <a591318fbba10b764075e9395ddd9f7f@denx.de> (raw)
In-Reply-To: <20231209-singular-tighten-eef5f7909dcd@spud>
Hi Conor,
On 09/12/2023 17:23, Conor Dooley wrote:
> You're adding the constraints and items at the wrong level AFAICT.
> I think something like the below better matches your constraints?
Thanks for your example.
With your change the fsl,imx93-tmu case works correctly:
if I pass the number of fsl,tmu-range entries different than 7,
dt_binding_check correctly complains.
However, if I pass 7 entries to fsl,qoriq-tmu it should complain as it
expects 4, but it
does not.
On top of your patch:
--- a/Documentation/devicetree/bindings/thermal/qoriq-thermal.yaml
+++ b/Documentation/devicetree/bindings/thermal/qoriq-thermal.yaml
@@ -104,7 +104,7 @@ additionalProperties: false
examples:
- |
tmu@f0000 {
- compatible = "fsl,imx93-tmu";
+ compatible = "fsl,qoriq-tmu";
reg = <0xf0000 0x1000>;
interrupts = <18 2 0 0>;
fsl,tmu-range = <0x000a0000 0x00090026 0x0008004a 0x0001006a 0
0 0>;
make dt_binding_check DT_SCHEMA_FILES=qoriq-thermal.yaml
LINT Documentation/devicetree/bindings
DTEX
Documentation/devicetree/bindings/thermal/qoriq-thermal.example.dts
CHKDT Documentation/devicetree/bindings/processed-schema.json
SCHEMA Documentation/devicetree/bindings/processed-schema.json
DTC_CHK
Documentation/devicetree/bindings/thermal/qoriq-thermal.example.dtb
Any suggestions?
Thanks
next prev parent reply other threads:[~2023-12-09 20:59 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-28 22:21 [PATCH v3] dt-bindings: thermal: qoriq-thermal: Adjust fsl,tmu-range min/maxItems Fabio Estevam
2023-10-02 12:27 ` Conor Dooley
2023-12-09 19:22 ` Fabio Estevam
2023-12-09 20:23 ` Conor Dooley
2023-12-09 20:59 ` Fabio Estevam [this message]
2023-12-10 14:52 ` Conor Dooley
2023-12-10 15:37 ` Rob Herring
2023-12-14 17:13 ` Conor Dooley
2024-01-03 21:39 ` Rob Herring
2024-01-03 21:51 ` Fabio Estevam
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a591318fbba10b764075e9395ddd9f7f@denx.de \
--to=festevam@denx.de \
--cc=conor+dt@kernel.org \
--cc=conor@kernel.org \
--cc=daniel.lezcano@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=festevam@gmail.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-pm@vger.kernel.org \
--cc=rafael@kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).