Re: [PATCH v6 2/2] iio: light: isl76682: Add ISL76682 driver

[Marek Vasut <marex@denx.de>]

On 12/6/23 18:20, Jonathan Cameron wrote:
> On Tue, 5 Dec 2023 02:24:51 +0100
> Marek Vasut <marex@denx.de> wrote:
> 
>> On 12/4/23 15:35, Jonathan Cameron wrote:
>>> On Mon, 4 Dec 2023 12:23:06 +0100
>>> Marek Vasut <marex@denx.de> wrote:
>>>    
>>>> On 12/4/23 12:20, Jonathan Cameron wrote:
>>>>> On Mon, 27 Nov 2023 22:26:53 +0100
>>>>> Marek Vasut <marex@denx.de> wrote:
>>>>>       
>>>>>> The ISL76682 is very basic ALS which only supports ALS or IR mode
>>>>>> in four ranges, 1k/4k/16k/64k LUX. There is no IRQ support or any
>>>>>> other fancy functionality.
>>>>>>
>>>>>> Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
>>>>>> Reviewed-by: Matti Vaittinen <mazziesaccount@gmail.com>
>>>>>> Signed-off-by: Marek Vasut <marex@denx.de>
>>>>> Hi Marek,
>>>>>
>>>>> Discussion around available on v5 made me look closer at that aspect.
>>>>> You are providing all the available entries in the callback but they
>>>>> shouldn't be exposed to actually read unless the *_available bitmap
>>>>> bits corresponding to them are set.
>>>>>
>>>>> If you like I can just rip the unused code out whilst applying?
>>>>> Or if you'd prefer to send a v7 that's great too.
>>>>>
>>>>> Otherwise everything looks good to me.
>>>>
>>>> Maybe just do that while applying and I'll test it right after to see
>>>> whether something broke, that's probably fastest. Just let me know where
>>>> this got applied. I have the device on my desk .
>>>
>>> Diff is below.  Applied to the togreg
>>
>> I only found the commit in 'testing' branch , so I used that one .
> I messed up it seems and didn't actually push the updated version.
> Done so now along with squashing in the bracket tidy up.

Driver works just fine, still, thank you.