From: Sameer Pujar <dev.spujar@gmail.com>
To: Mark Brown <broonie@kernel.org>, Sameer Pujar <spujar@nvidia.com>
Cc: devicetree@vger.kernel.org, alsa-devel@alsa-project.org,
kuninori.morimoto.gx@renesas.com, lgirdwood@gmail.com,
robh+dt@kernel.org, jonathanh@nvidia.com, sharadg@nvidia.com,
thierry.reding@gmail.com, linux-tegra@vger.kernel.org
Subject: Re: [PATCH 4/8] ASoC: tegra: Select SND_SOC_RT5659
Date: Fri, 29 Jan 2021 22:15:51 +0530 [thread overview]
Message-ID: <a5a8df4b-21d1-0a12-df7d-9e94c353e2b5@gmail.com> (raw)
In-Reply-To: <20210129154858.GE4560@sirena.org.uk>
On 1/29/2021 9:18 PM, Mark Brown wrote:
> On Fri, Jan 29, 2021 at 09:02:52PM +0530, Sameer Pujar wrote:
>> On 1/29/2021 6:14 PM, Mark Brown wrote:
>>> This is a generic device, not something specific to Jetson, why force
>>> on a driver that may not be required on other boards using this driver?
>> Yes specific boards using 'SND_SOC_TEGRA_AUDIO_GRAPH_CARD' may require
>> 'SND_SOC_RT5659'. But there is no platform specific config. Is there a
>> better way to enable config 'SND_SOC_RT5659' conditionally?
> If the user wants a given CODEC driver then they should enable that
> driver.
Above card driver is intended to be used on multiple platforms. DT has
already a way for user to describe the CODEC connection required for
specific platform. So idea is enable these CODECs from driver point of
view for this card driver and platform DT can use what is required. Also
the CODEC driver will be a loadable module here.
If above does not seem fine, alternatively can I just enable CODEC
config independently from defconfig?
next parent reply other threads:[~2021-01-29 16:47 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1611920470-24225-1-git-send-email-spujar@nvidia.com>
[not found] ` <1611920470-24225-5-git-send-email-spujar@nvidia.com>
[not found] ` <20210129124454.GB4560@sirena.org.uk>
[not found] ` <d6cb9252-246e-d6c7-7500-5f1d1823325c@nvidia.com>
[not found] ` <20210129154858.GE4560@sirena.org.uk>
2021-01-29 16:45 ` Sameer Pujar [this message]
2021-01-29 17:19 ` [PATCH 4/8] ASoC: tegra: Select SND_SOC_RT5659 Mark Brown
2021-01-29 17:28 ` Sameer Pujar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a5a8df4b-21d1-0a12-df7d-9e94c353e2b5@gmail.com \
--to=dev.spujar@gmail.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=jonathanh@nvidia.com \
--cc=kuninori.morimoto.gx@renesas.com \
--cc=lgirdwood@gmail.com \
--cc=linux-tegra@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=sharadg@nvidia.com \
--cc=spujar@nvidia.com \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox