From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id BB006C77B76 for ; Fri, 14 Apr 2023 11:21:39 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229839AbjDNLVj (ORCPT ); Fri, 14 Apr 2023 07:21:39 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54114 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229497AbjDNLVi (ORCPT ); Fri, 14 Apr 2023 07:21:38 -0400 Received: from mail-ed1-x52d.google.com (mail-ed1-x52d.google.com [IPv6:2a00:1450:4864:20::52d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1614B198B for ; Fri, 14 Apr 2023 04:21:37 -0700 (PDT) Received: by mail-ed1-x52d.google.com with SMTP id 4fb4d7f45d1cf-50674656309so1031065a12.0 for ; Fri, 14 Apr 2023 04:21:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1681471295; x=1684063295; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=hWP16bG6uUr4pZjxU30nkO7zZOcUfB3YuG/344uIKNQ=; b=RS8Qhvt0joORbhPMbnrHe/IfmdjZ0uOTbrgCAmyBIgJ5m26eaqgonnlIyIeCxGL9Ry Sl5gOj9wsiAhkE1cmGC6DaE34pv5pyCSiV/ZeNaM0JMVh1ECH85kt4poSz76UCYPNF1O HI74UMYeOXFuaN5HwrTSGIMBX6C1tsDTKffPckyIBy4eNsgM3gfRRVmcd2Q9PfPUs9Ly nf0LEgk3MucrjFbylGBnuuPseNh6ewCWhS8Q25+/VTqwf6eo3Eex062iKP4pMjEq1AVQ z8DaOgVsAh1uAMsr4HY5m+nIVMOF7FyVIcgoLkMSxKQfSthOyXohvPvW/gSwIQMb0TzF TN5w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1681471295; x=1684063295; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=hWP16bG6uUr4pZjxU30nkO7zZOcUfB3YuG/344uIKNQ=; b=JfRWgkNqomCli+GvgS5BqIaiMx/FB3mJy/WJqRhAcqDUY1zrbsBAUb2Xs/yCNf3Lw8 jv/NTcVDlLyHNomKS5QwkHEgJzZctA+hnj30sogcx2QdS+11o3JLV/HNyGaTvtXtCRwv BfVOqtqgzyWIAV6Sy1PMAELL7a4H7ZV7n5nMIjbnMnZJ/OikM8DPM8Oc/D3kYNYZ7z19 0WoCW/cYgr0uIKOtxHGZY4nd+39WKG/eyYcSQ/+2GOee+SeqgeObv0zAJfaCOy+PlwkL Y5uNEL6ufxQCsQe/gAl9JR4qHqx9axiO2tJ6tqpz5th59CC6XOSSX2k3shF76Ad37x4N uuKQ== X-Gm-Message-State: AAQBX9dajV4sa50c9z/I8g4XyuGAaZZ+zS9iegMcfuksdrSsZK+jBlLo PKgDff4XiF0rQ1ctj0ZwKn/hOA== X-Google-Smtp-Source: AKy350aEZXq5vhpbcuIVMGc02L1mtWNHGPAkZUnP5pk7APNWBHnrMhr1AOTOpXrDzGDBYgbb0dLnkA== X-Received: by 2002:a50:ec84:0:b0:506:74d6:45aa with SMTP id e4-20020a50ec84000000b0050674d645aamr5212418edr.24.1681471295533; Fri, 14 Apr 2023 04:21:35 -0700 (PDT) Received: from ?IPV6:2a02:810d:15c0:828:40b9:8c57:b112:651d? ([2a02:810d:15c0:828:40b9:8c57:b112:651d]) by smtp.gmail.com with ESMTPSA id b11-20020a17090636cb00b00930aa50372csm2326194ejc.43.2023.04.14.04.21.34 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 14 Apr 2023 04:21:35 -0700 (PDT) Message-ID: Date: Fri, 14 Apr 2023 13:21:34 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.9.1 Subject: Re: [PATCH 1/2] dt-bindings: watchdog: marvell octeonTX2 GTI system atchdog driver Content-Language: en-US To: Bharat Bhushan , wim@linux-watchdog.org, linux@roeck-us.net, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, linux-watchdog@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20230414102342.23696-1-bbhushan2@marvell.com> From: Krzysztof Kozlowski In-Reply-To: <20230414102342.23696-1-bbhushan2@marvell.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 14/04/2023 12:23, Bharat Bhushan wrote: > Add binding documentation for the Marvell octeonTX2 > GTI system watchdog driver. Subject: typo: atchdog > > Signed-off-by: Bharat Bhushan > --- > .../watchdog/marvell-octeontx2-wdt.yaml | 49 +++++++++++++++++++ > 1 file changed, 49 insertions(+) > create mode 100644 Documentation/devicetree/bindings/watchdog/marvell-octeontx2-wdt.yaml > > diff --git a/Documentation/devicetree/bindings/watchdog/marvell-octeontx2-wdt.yaml b/Documentation/devicetree/bindings/watchdog/marvell-octeontx2-wdt.yaml > new file mode 100644 > index 000000000000..e509f26c61b9 > --- /dev/null > +++ b/Documentation/devicetree/bindings/watchdog/marvell-octeontx2-wdt.yaml > @@ -0,0 +1,49 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/watchdog/marvell-octeontx2-wdt.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Marvell OcteonTX2 GTI system watchdog > + > +allOf: > + - $ref: watchdog.yaml# > + > +maintainers: > + - Bharat Bhushan > + > +properties: > + compatible: > + const: marvell-octeontx2-wdt That's not correct compatible. marvell is a vendor prefix. Did you test the bindings before sending? > + > + reg: > + maxItems: 1 > + description: > + OcteonTX2 GTI system watchdog register space Drop description, it is obvious. > + > + interrupts: > + maxItems: 1 > + description: > + OcteonTX2 GTI system watchdog interrupt number Ditto > + > +required: > + - compatible > + - reg > + - interrupts > + > +additionalProperties: false unevaluatedProperties: false instead > + > +examples: > + - | > + soc { > + #address-cells = <2>; > + #size-cells = <2>; > + > + watchdog@802000040000 { > + compatible = "marvell-octeontx2-wdt"; > + reg = <0x8020 0x40000 0x0 0x20000>; Are you sure that this is correct DTS? 32-bit numbers are usually 8-digit long. Plus size of 0x20000 is crazy huge. And the unit address is a bit unusual. Are you sure dtc W=1 does not say about any errors in your DTS? > + interrupts = <0 38 1>; Use defines for common flags. > + }; > + }; > + > +... Best regards, Krzysztof