From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Vladimir Zapolskiy <vladimir.zapolskiy@linaro.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Bjorn Andersson <andersson@kernel.org>,
Herbert Xu <herbert@gondor.apana.org.au>,
Thara Gopinath <thara.gopinath@gmail.com>,
Bhupesh Sharma <bhupesh.sharma@linaro.org>
Cc: Rob Herring <robh+dt@kernel.org>,
Konrad Dybcio <konrad.dybcio@linaro.org>,
Andy Gross <agross@kernel.org>,
"David S. Miller" <davem@davemloft.net>,
devicetree@vger.kernel.org, linux-arm-msm@vger.kernel.org,
linux-crypto@vger.kernel.org
Subject: Re: [PATCH v9 05/14] dt-bindings: qcom-qce: Add new SoC compatible strings for qcom-qce
Date: Thu, 9 Feb 2023 10:19:39 +0100 [thread overview]
Message-ID: <a5c8355c-4181-d106-2f6b-a48126cb2b70@linaro.org> (raw)
In-Reply-To: <bc088534-ac1d-0504-9961-d3cd3740e2f3@linaro.org>
On 09/02/2023 10:18, Krzysztof Kozlowski wrote:
> On 08/02/2023 19:37, Vladimir Zapolskiy wrote:
>> Change QCE IP version specific compatible to two QCE IP family compatibles
>> based on SoC name and populate these two IP families with particular SoC
>> specific IP compatible names, which are known at the moment.
>>
>> Keep the old compatible 'qcom,crypto-v5.1' for backward compatibility
>> of DTB ABI, but mark it as deprecated.
>>
>> The change is based on the original one written by Bhupesh Sharma.
>>
>> Cc: Bhupesh Sharma <bhupesh.sharma@linaro.org>
>> Signed-off-by: Vladimir Zapolskiy <vladimir.zapolskiy@linaro.org>
>> ---
>> .../devicetree/bindings/crypto/qcom-qce.yaml | 24 +++++++++++++++++--
>> 1 file changed, 22 insertions(+), 2 deletions(-)
>>
>> diff --git a/Documentation/devicetree/bindings/crypto/qcom-qce.yaml b/Documentation/devicetree/bindings/crypto/qcom-qce.yaml
>> index 4e00e7925fed..f6f1759a2f6e 100644
>> --- a/Documentation/devicetree/bindings/crypto/qcom-qce.yaml
>> +++ b/Documentation/devicetree/bindings/crypto/qcom-qce.yaml
>> @@ -15,7 +15,27 @@ description:
>>
>> properties:
>> compatible:
>> - const: qcom,crypto-v5.1
>> + oneOf:
>> + - const: qcom,crypto-v5.1
>> + deprecated: true
>> + description: Kept only for ABI backward compatibility
>> + - const: qcom,crypto-v5.4
>
> You should mention in commit msg that you document existing compatible
> v5.4. Otherwise it looks unrelated/unexplained. Especially adding
> deprecated compatible is unexpected.
>
With commit msg adjustement for v5.4 compatible:
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Best regards,
Krzysztof
next prev parent reply other threads:[~2023-02-09 9:21 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-08 18:37 [PATCH v9 00/14] crypto: qcom-qce: Add YAML bindings & support for newer SoCs Vladimir Zapolskiy
2023-02-08 18:37 ` [PATCH v9 01/14] dt-bindings: qcom-qce: Convert bindings to yaml Vladimir Zapolskiy
2023-02-08 18:37 ` [PATCH v9 02/14] MAINTAINERS: Add qcom-qce dt-binding file to QUALCOMM CRYPTO DRIVERS section Vladimir Zapolskiy
2023-02-08 18:37 ` [PATCH v9 03/14] dt-bindings: qcom-qce: Add 'interconnects' and 'interconnect-names' Vladimir Zapolskiy
2023-02-08 18:37 ` [PATCH v9 04/14] dt-bindings: qcom-qce: Add 'iommus' to optional properties Vladimir Zapolskiy
2023-02-08 18:37 ` [PATCH v9 05/14] dt-bindings: qcom-qce: Add new SoC compatible strings for qcom-qce Vladimir Zapolskiy
2023-02-09 9:18 ` Krzysztof Kozlowski
2023-02-09 9:19 ` Krzysztof Kozlowski [this message]
2023-02-08 18:37 ` [PATCH v9 06/14] dt-bindings: qcom-qce: document optional clocks and clock-names properties Vladimir Zapolskiy
2023-02-09 9:20 ` Krzysztof Kozlowski
2023-02-10 11:17 ` Vladimir Zapolskiy
2023-02-10 11:30 ` Krzysztof Kozlowski
2023-02-08 18:37 ` [PATCH v9 07/14] arm: dts: qcom: ipq4019: update a compatible for QCE IP on IPQ4019 SoC Vladimir Zapolskiy
2023-02-09 9:22 ` Krzysztof Kozlowski
2023-02-08 18:37 ` [PATCH v9 08/14] arm64: dts: qcom: msm8996: update QCE compatible according to a new scheme Vladimir Zapolskiy
2023-02-09 9:23 ` Krzysztof Kozlowski
2023-02-08 18:37 ` [PATCH v9 09/14] arm64: dts: qcom: sdm845: " Vladimir Zapolskiy
2023-02-09 9:23 ` Krzysztof Kozlowski
2023-02-08 18:37 ` [PATCH v9 10/14] arm64: dts: qcom: sm8550: add a family compatible for QCE IP Vladimir Zapolskiy
2023-02-09 9:23 ` Krzysztof Kozlowski
2023-02-08 18:37 ` [PATCH v9 11/14] arm64: dts: qcom: sm8250: add description of Qualcomm Crypto Engine IP Vladimir Zapolskiy
2023-02-09 12:21 ` Bhupesh Sharma
2023-02-09 14:30 ` Vladimir Zapolskiy
2023-02-13 17:12 ` Bhupesh Sharma
2023-02-14 10:24 ` Vladimir Zapolskiy
2023-02-08 18:37 ` [PATCH v9 12/14] crypto: qce: core: Add support to initialize interconnect path Vladimir Zapolskiy
2023-02-08 18:37 ` [PATCH v9 13/14] crypto: qce: core: Make clocks optional Vladimir Zapolskiy
2023-02-08 18:37 ` [PATCH v9 14/14] crypto: qce: core: Add a compatible based on a SoC name Vladimir Zapolskiy
2023-02-09 9:26 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a5c8355c-4181-d106-2f6b-a48126cb2b70@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=bhupesh.sharma@linaro.org \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=herbert@gondor.apana.org.au \
--cc=konrad.dybcio@linaro.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-crypto@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=thara.gopinath@gmail.com \
--cc=vladimir.zapolskiy@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).