From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id AEB9BC636D4 for ; Thu, 9 Feb 2023 09:21:09 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230286AbjBIJVI (ORCPT ); Thu, 9 Feb 2023 04:21:08 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53734 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230106AbjBIJUt (ORCPT ); Thu, 9 Feb 2023 04:20:49 -0500 Received: from mail-wm1-x32b.google.com (mail-wm1-x32b.google.com [IPv6:2a00:1450:4864:20::32b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9784965EC4 for ; Thu, 9 Feb 2023 01:19:43 -0800 (PST) Received: by mail-wm1-x32b.google.com with SMTP id az4-20020a05600c600400b003dff767a1f1so1002567wmb.2 for ; Thu, 09 Feb 2023 01:19:43 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:references:cc:to:from :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=+lf8QLPCcyDvpw7oAginkoSV3mAKj3y/9VzlqPF8+0U=; b=V6UTmWV3UklUG+BCKfVbpD51PLxvQjUgRckjuijCqks573cOtprivY/CE341/dRA3v NxjFR8dLkFGCVDNDL00gCoMurLeBPxUHxBwVkcLbLVbR5dOcixpxl5nMtjq3383RW6bc xNzHeTYsh25RNmAoIIS6X1WYg3beRHXhBNGpfSCPh5QvHEW2ghaMecMtmkhYwjFWe+i7 U2Lo6LzfXzkPYsqiSKK884KWfJOrWJq8sma892RLZ7PC0VZ3Rcwjp5eKX7E+AdWSzaZb TwxBfnVrwBjcBYZ9hiHVOLu0NV9zXV47CFjALkBPotjd9tYzuhIc9fgw/3iBFgx/xDT/ nQ9Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:references:cc:to:from :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=+lf8QLPCcyDvpw7oAginkoSV3mAKj3y/9VzlqPF8+0U=; b=ujoVRmBMm0oLheI+SI5NqeIKgAcB4N/iRrqwcUY+nLkAAnLMYxYSYE40ni4ZkQ2Z1Y f15Z9ma7cZxJfXOTAEdMID5r2vMMwDQsUXskpPHzkclAQDyOOvHkhW2mVeuIJo7aRMdQ AoIz5RbLwGyNGd5LnN12fFYbge6ArjXMVfZjyhra+9lE/qd1VHRsW70paRM+WchAqaqH F6RtRA1yEc2he2VofIgQMynWBCdxybsRUGCrSTmtZ94haFjnRKoAIq5GedIwS0iL1tpW aeZOVLqU5gfNBs90A7gnD5e9z9xwKAIhDA+7ZXKrzOYHbZOHNu0abHtW+O5i4JCtszC5 uinw== X-Gm-Message-State: AO0yUKXtRfWVjw0ar7fcT265mXESGXRLfxcTGlWTIsObrbYrEoLTS0ic zcyKBqwS3D8nBVzu0aBQPnfmPQ== X-Google-Smtp-Source: AK7set8uToABk3UaRvkBw8DeoFe9DRIQaKr2AnU5CSys7VDnbZYgBchuU1hSCnSy3xb7kGjg2GKSwg== X-Received: by 2002:a05:600c:43d2:b0:3da:fc07:5e80 with SMTP id f18-20020a05600c43d200b003dafc075e80mr3817799wmn.12.1675934381973; Thu, 09 Feb 2023 01:19:41 -0800 (PST) Received: from [192.168.1.109] ([178.197.216.144]) by smtp.gmail.com with ESMTPSA id az10-20020a05600c600a00b003dc3f07c876sm4527444wmb.46.2023.02.09.01.19.40 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 09 Feb 2023 01:19:41 -0800 (PST) Message-ID: Date: Thu, 9 Feb 2023 10:19:39 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 Subject: Re: [PATCH v9 05/14] dt-bindings: qcom-qce: Add new SoC compatible strings for qcom-qce Content-Language: en-US From: Krzysztof Kozlowski To: Vladimir Zapolskiy , Krzysztof Kozlowski , Bjorn Andersson , Herbert Xu , Thara Gopinath , Bhupesh Sharma Cc: Rob Herring , Konrad Dybcio , Andy Gross , "David S. Miller" , devicetree@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-crypto@vger.kernel.org References: <20230208183755.2907771-1-vladimir.zapolskiy@linaro.org> <20230208183755.2907771-6-vladimir.zapolskiy@linaro.org> In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 09/02/2023 10:18, Krzysztof Kozlowski wrote: > On 08/02/2023 19:37, Vladimir Zapolskiy wrote: >> Change QCE IP version specific compatible to two QCE IP family compatibles >> based on SoC name and populate these two IP families with particular SoC >> specific IP compatible names, which are known at the moment. >> >> Keep the old compatible 'qcom,crypto-v5.1' for backward compatibility >> of DTB ABI, but mark it as deprecated. >> >> The change is based on the original one written by Bhupesh Sharma. >> >> Cc: Bhupesh Sharma >> Signed-off-by: Vladimir Zapolskiy >> --- >> .../devicetree/bindings/crypto/qcom-qce.yaml | 24 +++++++++++++++++-- >> 1 file changed, 22 insertions(+), 2 deletions(-) >> >> diff --git a/Documentation/devicetree/bindings/crypto/qcom-qce.yaml b/Documentation/devicetree/bindings/crypto/qcom-qce.yaml >> index 4e00e7925fed..f6f1759a2f6e 100644 >> --- a/Documentation/devicetree/bindings/crypto/qcom-qce.yaml >> +++ b/Documentation/devicetree/bindings/crypto/qcom-qce.yaml >> @@ -15,7 +15,27 @@ description: >> >> properties: >> compatible: >> - const: qcom,crypto-v5.1 >> + oneOf: >> + - const: qcom,crypto-v5.1 >> + deprecated: true >> + description: Kept only for ABI backward compatibility >> + - const: qcom,crypto-v5.4 > > You should mention in commit msg that you document existing compatible > v5.4. Otherwise it looks unrelated/unexplained. Especially adding > deprecated compatible is unexpected. > With commit msg adjustement for v5.4 compatible: Reviewed-by: Krzysztof Kozlowski Best regards, Krzysztof