From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9AA3CC433FE for ; Fri, 21 Oct 2022 23:59:46 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229955AbiJUX7n (ORCPT ); Fri, 21 Oct 2022 19:59:43 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41140 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229964AbiJUX7m (ORCPT ); Fri, 21 Oct 2022 19:59:42 -0400 Received: from mail-qt1-x833.google.com (mail-qt1-x833.google.com [IPv6:2607:f8b0:4864:20::833]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 250AE1C119 for ; Fri, 21 Oct 2022 16:59:29 -0700 (PDT) Received: by mail-qt1-x833.google.com with SMTP id c23so2655224qtw.8 for ; Fri, 21 Oct 2022 16:59:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=hLVewMwCQ3h+F5+iDKTi/kVuEV/htostHOaYdqOz1MU=; b=FCsq656tPxy0dYq9UdwTGLds/rUDSnPuGlDt1DHI33YL/+TaDy5/CoiBTQtYswo1h2 oQ3sfr9r+Z8F6b/NW6fGgZXBh/vIi2QEILNRt1Rl8dZkoMdDkx2mVupM732xhg2WjXMY r3GsEHyTVBqlf1YyifdJuAOVR6PBC1Ctrc5bUrwkpRf9StRDOADICUJZOEs7dOFQlq/U vhYAwcaSP1Sy3Wc3XuitegCqxOjcVZqzldS65e6xr0zKaeC3uaqiw83Hl2UZJR4Wrna5 fc6B7Y3qOs9OLOm/rTTRhHX+j28HBiGHNi1d2F8YdYnOuLjaxlOvUZYaHLWOIeKoQkUw NgFw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=hLVewMwCQ3h+F5+iDKTi/kVuEV/htostHOaYdqOz1MU=; b=cdop5qnkSCNtWziWoYwoCUYF6SIxrDlbvcSTqv0YOzTv33cYpbvxNGwN7qd2Vproj7 78avhavHZ5pDtJF2NzFZZgZFlwoFPvCdGRUDjgben1eMFnqH1S3MwueQh5NbyVj0QAGf 1/v/hp9KdN5CgEhVpHfdkKPpYG04mqd/XAKyeCbX0ccTQM0BKFDC7DMUD2D0lVytDnM1 pLoKB5vvdmkISF45+3wQUnQ2u2B+Ho5203MmiVhH3pXPIlybSTB0R7dIgPG011mSK8Ic WC9570KshHt7cICAo/AFjfV+4NpJNipmX4qcfX0ToRId5MixfYbBStkKdpIrK/bSvJIv 0r/w== X-Gm-Message-State: ACrzQf2uqf6GfT5XRwUhm3NxSs5TaRhQn0p8VK/m1aobtVjS+8O9Wzta VigpCMUITLIjqpRqSnzKB7V2g8/9Q/HQWg== X-Google-Smtp-Source: AMsMyM4O9Mesth8sJL91+uqMdsVpGCr0EH+jXYtIePpFvf0Wn0uk61byBiaPxCpzqSIQ3hDwH5Up9Q== X-Received: by 2002:ac8:5804:0:b0:39c:d63c:95b7 with SMTP id g4-20020ac85804000000b0039cd63c95b7mr18215800qtg.216.1666396768302; Fri, 21 Oct 2022 16:59:28 -0700 (PDT) Received: from [192.168.10.124] (pool-72-83-177-149.washdc.east.verizon.net. [72.83.177.149]) by smtp.gmail.com with ESMTPSA id u6-20020a05620a430600b006e16dcf99c8sm10739565qko.71.2022.10.21.16.59.27 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 21 Oct 2022 16:59:27 -0700 (PDT) Message-ID: Date: Fri, 21 Oct 2022 19:59:26 -0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.0 Subject: Re: [PATCH 1/1] dt-bindings: rtc: convert hym8563 bindings to json-schema To: Sebastian Reichel , Alexandre Belloni , Alessandro Zummo , Rob Herring , Krzysztof Kozlowski Cc: linux-rtc@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, kernel@collabora.com References: <20221021170605.85163-1-sebastian.reichel@collabora.com> Content-Language: en-US From: Krzysztof Kozlowski In-Reply-To: <20221021170605.85163-1-sebastian.reichel@collabora.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 21/10/2022 13:06, Sebastian Reichel wrote: > Convert RTC binding for Haoyu Microelectronics HYM8563 to Device Tree > Schema format. > > Signed-off-by: Sebastian Reichel > --- > .../devicetree/bindings/rtc/haoyu,hym8563.txt | 30 ---------- > .../bindings/rtc/haoyu,hym8563.yaml | 55 +++++++++++++++++++ > 2 files changed, 55 insertions(+), 30 deletions(-) > delete mode 100644 Documentation/devicetree/bindings/rtc/haoyu,hym8563.txt > create mode 100644 Documentation/devicetree/bindings/rtc/haoyu,hym8563.yaml > > diff --git a/Documentation/devicetree/bindings/rtc/haoyu,hym8563.txt b/Documentation/devicetree/bindings/rtc/haoyu,hym8563.txt > deleted file mode 100644 > index a8934fe2ab4c..000000000000 > --- a/Documentation/devicetree/bindings/rtc/haoyu,hym8563.txt > +++ /dev/null > @@ -1,30 +0,0 @@ > -Haoyu Microelectronics HYM8563 Real Time Clock > - > -The HYM8563 provides basic rtc and alarm functionality > -as well as a clock output of up to 32kHz. > - > -Required properties: > -- compatible: should be: "haoyu,hym8563" > -- reg: i2c address > -- #clock-cells: the value should be 0 > - > -Optional properties: > -- clock-output-names: From common clock binding > -- interrupts: rtc alarm/event interrupt > - > -Example: > - > -hym8563: hym8563@51 { > - compatible = "haoyu,hym8563"; > - reg = <0x51>; > - > - interrupts = <13 IRQ_TYPE_EDGE_FALLING>; > - > - #clock-cells = <0>; > -}; > - > -device { > -... > - clocks = <&hym8563>; > -... > -}; > diff --git a/Documentation/devicetree/bindings/rtc/haoyu,hym8563.yaml b/Documentation/devicetree/bindings/rtc/haoyu,hym8563.yaml > new file mode 100644 > index 000000000000..b0b6126b12dd > --- /dev/null > +++ b/Documentation/devicetree/bindings/rtc/haoyu,hym8563.yaml > @@ -0,0 +1,55 @@ > +# SPDX-License-Identifier: GPL-2.0 Dual license please. I don't think you copied any content from original bindings... unless the example? > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/rtc/haoyu,hym8563.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Haoyu Microelectronics HYM8563 RTC > + > +maintainers: > + - Alexandre Belloni > + > +properties: > + compatible: > + const: haoyu,hym8563 > + > + reg: > + maxItems: 1 > + > + interrupts: > + maxItems: 1 > + > + "#clock-cells": > + const: 0 > + > + clock-output-names: > + description: From common clock binding to override the default output clock name. You need maxItems for this. > + > + wakeup-source: > + description: Enables wake up of host system on alarm. > + > +allOf: > + - $ref: rtc.yaml > + > +unevaluatedProperties: false > + Would be great if you could also correct DTS using these bindings (see warning from Rob). Best regards, Krzysztof