From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f43.google.com (mail-wr1-f43.google.com [209.85.221.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E62F12DE200 for ; Tue, 7 Oct 2025 15:48:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.43 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1759852140; cv=none; b=CIDZO+G/Fre7d51157bpJ0AwqOxFX5LUexUI/5/N30BhQYOwJOiKJa2Pkfuyb/NW5qU5wwUQecDyJJAbvYS45OGlTEAJU9PIMm0wB3lMXALiD2xIxDJzteviX1DUHX0zyvWhDPeCT1uWFa0/DCaPZkD0mFdDuSQ1q7raoV4Ejd0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1759852140; c=relaxed/simple; bh=idsLDC2Nv76ap5anKli8m472glzZKQst8172esv0100=; h=Message-ID:Date:MIME-Version:From:Subject:To:Cc:References: In-Reply-To:Content-Type; b=txsCk6ylaSNfQpcgLiDuGXDtEnemVMhyGHrBsLv7zlNi4KzF8SbowUbTG10aUnZi444EcFcC/EBn7jhUrhiFB50mFOkmq/Wd4nmMN8jnIxSGgH5uZVUDQwXYiYvfERY5sHd+utdgXia5PmonTUouPdhX871Q5NgqJXaPhI8kU3M= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=ZFInhnsO; arc=none smtp.client-ip=209.85.221.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="ZFInhnsO" Received: by mail-wr1-f43.google.com with SMTP id ffacd0b85a97d-41174604d88so3468232f8f.2 for ; Tue, 07 Oct 2025 08:48:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1759852136; x=1760456936; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:references:cc:to:subject:reply-to:from:user-agent :mime-version:date:message-id:from:to:cc:subject:date:message-id :reply-to; bh=ujqZTrSIRL5Br3jVEaXKCPK1WTB5adLLumme0kdn1es=; b=ZFInhnsO9qhM3O/HHfNTgrDRYv8gVabeM8l4nUyFUgIWCzqtulABXukRNPi7k9GtEN ducrv5yeGokrvoM2TaIWAepIhkm2QT6AEDJAoxXEQ9lQIg7EtR3gIfsljhuFn/uLS0Qp wfiQaREyKXSRwhPMs23C23ICE5H2zT+JBX2zlgxHwtA6eDinW/ujEX6zbX/l2Wv7gPNA 7SV4joVUFwhunB1aP+iD52MfiNvoKAYRn+N5tCfzoGxW5QHQ74B1ADGVsNhnl+FIvsnp cIEtr/+QIBtp9cf0Vd+JQLJ5EL0qJMZKSW+VGJZDZHXhSl8GJ9W7DF1KaRkA9Dc4XKNM OcLA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1759852136; x=1760456936; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:references:cc:to:subject:reply-to:from:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=ujqZTrSIRL5Br3jVEaXKCPK1WTB5adLLumme0kdn1es=; b=EIbyqv60vVXFq12T19U8GFpAYVV7HPFGQB/S8Ugw++o/mQ0Flf6Y/XE0LQ4YAyxa1S t/qI74GmuRqPaxQyVqFJ+aIlILjEwD7EqrGTWW/LYPJENYLoK00BlwmU0IGrWiBDtzul jm2Uety3pAEaHvwZk3nBu7AJEjz87YQE5vRNpDgbATWxVlfaxdY6HtWVHIKcpV1S+jvw nWUTryQyWSXlA7reQIZqqwioah9sKhFtL1+kN8FXtqiv7HlSFsLXYxv4KNI9mvbfYV7e mj1yb8roR/19859N95pYPgrOMYpTx376JI+sIkZuQEcpvtLZ1wAWw7FCy7jTx20+uRg4 uxqQ== X-Forwarded-Encrypted: i=1; AJvYcCWSEmHFW38GqPRGXQ5iEGRrJJODNfQPO29a2CBXL52jwmMOQxKBPvqIe86064Obxon4pmjDSLHQu8Kk@vger.kernel.org X-Gm-Message-State: AOJu0Yx+as/MtdB2ju066MR9rNQNgJrcMhPfGRuW5ezMuCjHAO+TUd2f 1Kdk2+4C0x7+DdfFEWmif0Tdv7l27IXRWWjSuDurqRzcD1+h3T4hOZW4tflO2F8+a7o= X-Gm-Gg: ASbGnctVZouRWTRPEDqWoQaOAT3zL2VZEQWCngGeeC4rKwFwCJnu69bYY2+V0c9HSeT mf8ys5l7grlKLfg5Y1+vb9eHW5XJ5GBJ6eydVojsFWkPh0YhccLN1gsBMjgRfTwnnK5B8QkQb/0 GJcl72v1skaGJM+BcgqsQ1z5JbPnLFZH3/flE1ukYYSJx9smXjCBNDxv/lTVdhkBHV1L6l4aB53 qR1VTTNyGQBn151j+HDojw8x7Uny8ciXll8yc7r8sZkq/2aqjEZzvgAIcje7LIoE1kM18LzAsH5 joo2+XuPVI5AMP0HBOO+nEFuPZCtZQ9SqfVxzN5asrvpHCzPpO0E4wMfAqBJ6wGq6PgkY+/CtBg 7+8bnh3ECQh+tO6xeK23zM32nZhBklpUViGIFKSq+vdIb4ksfpqN2r4oOmopE+daloJ0PwccANX zCA9Kyvs0qqxFIHSZQoKxuQJe+hkg= X-Google-Smtp-Source: AGHT+IGlCt3WNje/lItmY3GQsKoJPUs6M1EHh44EgkG7EO1ZdmP5CqynBnMwr5jKEwAuFYo6Szge1Q== X-Received: by 2002:a05:6000:1a8b:b0:3fb:6f9d:2704 with SMTP id ffacd0b85a97d-42567174a0cmr10730399f8f.28.1759852136117; Tue, 07 Oct 2025 08:48:56 -0700 (PDT) Received: from ?IPV6:2a01:e0a:3d9:2080:bd88:41d2:33ce:f74a? ([2a01:e0a:3d9:2080:bd88:41d2:33ce:f74a]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-4255d8f0170sm26770403f8f.49.2025.10.07.08.48.55 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 07 Oct 2025 08:48:55 -0700 (PDT) Message-ID: Date: Tue, 7 Oct 2025 17:48:55 +0200 Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird From: Neil Armstrong Reply-To: Neil Armstrong Subject: Re: [PATCH RFC 3/6] ASoC: soc: qcom: sc8280xp: add support for I2S clocks To: Konrad Dybcio , Srinivas Kandagatla , Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Bjorn Andersson , Konrad Dybcio Cc: linux-sound@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org References: <20251006-topic-sm8x50-next-hdk-i2s-v1-0-184b15a87e0a@linaro.org> <20251006-topic-sm8x50-next-hdk-i2s-v1-3-184b15a87e0a@linaro.org> <6492e444-4196-4900-a741-a74a8c506a6d@kernel.org> <1eab5200-1292-4d39-bdf8-0c5084cfaab9@linaro.org> Content-Language: en-US, fr Autocrypt: addr=neil.armstrong@linaro.org; keydata= xsBNBE1ZBs8BCAD78xVLsXPwV/2qQx2FaO/7mhWL0Qodw8UcQJnkrWmgTFRobtTWxuRx8WWP GTjuhvbleoQ5Cxjr+v+1ARGCH46MxFP5DwauzPekwJUD5QKZlaw/bURTLmS2id5wWi3lqVH4 BVF2WzvGyyeV1o4RTCYDnZ9VLLylJ9bneEaIs/7cjCEbipGGFlfIML3sfqnIvMAxIMZrvcl9 qPV2k+KQ7q+aXavU5W+yLNn7QtXUB530Zlk/d2ETgzQ5FLYYnUDAaRl+8JUTjc0CNOTpCeik 80TZcE6f8M76Xa6yU8VcNko94Ck7iB4vj70q76P/J7kt98hklrr85/3NU3oti3nrIHmHABEB AAHNKk5laWwgQXJtc3Ryb25nIDxuZWlsLmFybXN0cm9uZ0BsaW5hcm8ub3JnPsLAkQQTAQoA OwIbIwULCQgHAwUVCgkICwUWAgMBAAIeAQIXgBYhBInsPQWERiF0UPIoSBaat7Gkz/iuBQJk Q5wSAhkBAAoJEBaat7Gkz/iuyhMIANiD94qDtUTJRfEW6GwXmtKWwl/mvqQtaTtZID2dos04 YqBbshiJbejgVJjy+HODcNUIKBB3PSLaln4ltdsV73SBcwUNdzebfKspAQunCM22Mn6FBIxQ GizsMLcP/0FX4en9NaKGfK6ZdKK6kN1GR9YffMJd2P08EO8mHowmSRe/ExAODhAs9W7XXExw UNCY4pVJyRPpEhv373vvff60bHxc1k/FF9WaPscMt7hlkbFLUs85kHtQAmr8pV5Hy9ezsSRa GzJmiVclkPc2BY592IGBXRDQ38urXeM4nfhhvqA50b/nAEXc6FzqgXqDkEIwR66/Gbp0t3+r yQzpKRyQif3OwE0ETVkGzwEIALyKDN/OGURaHBVzwjgYq+ZtifvekdrSNl8TIDH8g1xicBYp QTbPn6bbSZbdvfeQPNCcD4/EhXZuhQXMcoJsQQQnO4vwVULmPGgtGf8PVc7dxKOeta+qUh6+ SRh3vIcAUFHDT3f/Zdspz+e2E0hPV2hiSvICLk11qO6cyJE13zeNFoeY3ggrKY+IzbFomIZY 4yG6xI99NIPEVE9lNBXBKIlewIyVlkOaYvJWSV+p5gdJXOvScNN1epm5YHmf9aE2ZjnqZGoM Mtsyw18YoX9BqMFInxqYQQ3j/HpVgTSvmo5ea5qQDDUaCsaTf8UeDcwYOtgI8iL4oHcsGtUX oUk33HEAEQEAAcLAXwQYAQIACQUCTVkGzwIbDAAKCRAWmrexpM/4rrXiB/sGbkQ6itMrAIfn M7IbRuiSZS1unlySUVYu3SD6YBYnNi3G5EpbwfBNuT3H8//rVvtOFK4OD8cRYkxXRQmTvqa3 3eDIHu/zr1HMKErm+2SD6PO9umRef8V82o2oaCLvf4WeIssFjwB0b6a12opuRP7yo3E3gTCS KmbUuLv1CtxKQF+fUV1cVaTPMyT25Od+RC1K+iOR0F54oUJvJeq7fUzbn/KdlhA8XPGzwGRy 4zcsPWvwnXgfe5tk680fEKZVwOZKIEuJC3v+/yZpQzDvGYJvbyix0lHnrCzq43WefRHI5XTT QbM0WUIBIcGmq38+OgUsMYu4NzLu7uZFAcmp6h8g Organization: Linaro In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 10/7/25 12:23, Konrad Dybcio wrote: > On 10/7/25 9:02 AM, Neil Armstrong wrote: >> On 10/7/25 00:21, Srinivas Kandagatla wrote: >>> >>> >>> On 10/6/25 7:37 PM, Neil Armstrong wrote: >>>> Add support for getting the I2S clocks used for the MI2S >>>> interfaces, and enable/disable the clocks on the PCM >>>> startup and shutdown card callbacks. >>>> >>>> Signed-off-by: Neil Armstrong >>>> --- > > [...] > >>>> +static int sc8280xp_snd_startup(struct snd_pcm_substream *substream) >>>> +{ >>>> +    unsigned int codec_dai_fmt = SND_SOC_DAIFMT_BC_FC | SND_SOC_DAIFMT_NB_NF | SND_SOC_DAIFMT_I2S; >>>> +    struct snd_soc_pcm_runtime *rtd = substream->private_data; >>>> +    struct sc8280xp_snd_data *pdata = snd_soc_card_get_drvdata(rtd->card); >>>> +    struct snd_soc_dai *cpu_dai = snd_soc_rtd_to_cpu(rtd, 0); >>>> +    struct snd_soc_dai *codec_dai = snd_soc_rtd_to_codec(rtd, 0); >>>> +    int index; >>>> + >>>> +    switch (cpu_dai->id) { >>>> +    case PRIMARY_MI2S_RX...QUATERNARY_MI2S_TX: >>>> +    case QUINARY_MI2S_RX...QUINARY_MI2S_TX: >>>> +        index = sc8280xp_snd_i2s_index(cpu_dai); >>> >>> What is the mclk and bitclk rate set here, we can not rely on the >>> default rate. >> >> The default rates are set in DT: >> +        assigned-clocks = <&q6prmcc LPASS_CLK_ID_PRI_MI2S_IBIT LPASS_CLK_ATTRIBUTE_COUPLE_NO>, >> +                  <&q6prmcc LPASS_CLK_ID_MCLK_1 LPASS_CLK_ATTRIBUTE_COUPLE_NO>; >> +        assigned-clock-rates = <1536000>, >> +                       <24576000>; > > Is there a way to infer these rates based on the DT audio > connection graph? Good question, it's not done for pre-audioreach. Let me investigate. Neil > > Konrad