From: Sibi Sankar <sibis@codeaurora.org>
To: Stephen Boyd <swboyd@chromium.org>
Cc: bjorn.andersson@linaro.org, mka@chromium.org, robh+dt@kernel.org,
saiprakash.ranjan@codeaurora.org, will@kernel.org,
ohad@wizery.com, agross@kernel.org, mathieu.poirier@linaro.org,
robin.murphy@arm.com, joro@8bytes.org, p.zabel@pengutronix.de,
linux-arm-msm@vger.kernel.org, linux-remoteproc@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, evgreen@chromium.org,
dianders@chromium.org
Subject: Re: [PATCH v2 03/10] dt-bindings: remoteproc: qcom: Update Q6V5 Modem PIL binding
Date: Wed, 21 Jul 2021 22:34:24 +0530 [thread overview]
Message-ID: <a5e7af00a468166f3cff790f76c41fd7@codeaurora.org> (raw)
In-Reply-To: <CAE-0n51ujsHp+S9v2yTWVdFcWJswFyVyme8Bqp5i4w9Qv6GB6g@mail.gmail.com>
Hey Stephen,
Thanks for taking time to review
the series.
On 2021-07-21 11:09, Stephen Boyd wrote:
> Quoting Sibi Sankar (2021-07-20 03:12:53)
>> diff --git
>> a/Documentation/devicetree/bindings/remoteproc/qcom,q6v5.txt
>> b/Documentation/devicetree/bindings/remoteproc/qcom,q6v5.txt
>> index 494257010629..bc1394f5d677 100644
>> --- a/Documentation/devicetree/bindings/remoteproc/qcom,q6v5.txt
>> +++ b/Documentation/devicetree/bindings/remoteproc/qcom,q6v5.txt
>> @@ -198,6 +205,9 @@ For the compatible string below the following
>> supplies are required:
>> Definition: a phandle reference to a syscon representing TCSR
>> followed
>> by the three offsets within syscon for q6, modem
>> and nc
>> halt registers.
>> + a phandle reference to a syscon representing TCSR
>> followed
>> + by the four offsets within syscon for q6, modem,
>> nc and vq6
>> + halt registers on SC7280 SoCs.
>
> This seems to be duplicated? Maybe it should be combined with the
> previous sentence and sc7280 called out?
yeah noticed ^^ but that's the style
we've maintained till now. This
would get cleanup up when I do the
yaml conversion after the series
lands.
>
>>
>> For the compatible strings below the following phandle references are
>> required:
>> "qcom,sc7180-mss-pil"
--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project.
next prev parent reply other threads:[~2021-07-21 17:05 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-20 10:12 [PATCH v2 00/10] Add Modem support on SC7280 SoCs Sibi Sankar
2021-07-20 10:12 ` [PATCH v2 01/10] dt-bindings: remoteproc: qcom: pas: Add SC7280 MPSS support Sibi Sankar
2021-07-20 10:12 ` [PATCH v2 02/10] remoteproc: qcom: pas: Add SC7280 Modem support Sibi Sankar
2021-07-20 10:12 ` [PATCH v2 03/10] dt-bindings: remoteproc: qcom: Update Q6V5 Modem PIL binding Sibi Sankar
2021-07-21 5:39 ` Stephen Boyd
2021-07-21 17:04 ` Sibi Sankar [this message]
2021-07-20 10:12 ` [PATCH v2 04/10] iommu/arm-smmu-qcom: Request direct mapping for modem device Sibi Sankar
2021-07-21 5:39 ` Stephen Boyd
2021-07-20 10:12 ` [PATCH v2 05/10] remoteproc: mss: q6v5-mss: Add modem support on SC7280 Sibi Sankar
2021-07-20 10:12 ` [PATCH v2 06/10] arm64: dts: qcom: sc7280: Update reserved memory map Sibi Sankar
2021-07-21 5:42 ` Stephen Boyd
2021-07-20 10:12 ` [PATCH v2 07/10] arm64: dts: qcom: sc7280: Add/Delete/Update reserved memory nodes Sibi Sankar
2021-07-21 5:43 ` Stephen Boyd
2021-07-20 10:12 ` [PATCH v2 08/10] arm64: dts: qcom: sc7280: Add nodes to boot modem Sibi Sankar
2021-07-21 5:44 ` Stephen Boyd
2021-07-21 17:41 ` Sibi Sankar
2021-07-20 10:12 ` [PATCH v2 09/10] arm64: dts: qcom: sc7280: Add Q6V5 MSS node Sibi Sankar
2021-07-21 5:45 ` Stephen Boyd
2021-07-20 10:13 ` [PATCH v2 10/10] arm64: dts: qcom: sc7280: Update " Sibi Sankar
2021-07-21 5:47 ` Stephen Boyd
2021-07-21 17:16 ` Sibi Sankar
2021-07-21 22:53 ` Stephen Boyd
2021-07-22 17:34 ` Sibi Sankar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a5e7af00a468166f3cff790f76c41fd7@codeaurora.org \
--to=sibis@codeaurora.org \
--cc=agross@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=dianders@chromium.org \
--cc=evgreen@chromium.org \
--cc=joro@8bytes.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-remoteproc@vger.kernel.org \
--cc=mathieu.poirier@linaro.org \
--cc=mka@chromium.org \
--cc=ohad@wizery.com \
--cc=p.zabel@pengutronix.de \
--cc=robh+dt@kernel.org \
--cc=robin.murphy@arm.com \
--cc=saiprakash.ranjan@codeaurora.org \
--cc=swboyd@chromium.org \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).