Re: [PATCH v2 3/3] drm/panel: simple: Add PrimeView PM070WL4 support

[Neil Armstrong <neil.armstrong@linaro.org>]

On 06/06/2024 10:01, Primoz Fiser wrote:
> Add support for PrimeView PM070WL4 7.0" (800x480) TFT-LCD panel.
> Datasheet can be found at [1].
> 
> [1] https://www.beyondinfinite.com/lcd/Library/Pvi/PM070WL4-V1.0.pdf
> 
> Signed-off-by: Primoz Fiser <primoz.fiser@norik.com>
> ---
> Changes in v2:
> - sort alphabetically
> 
>   drivers/gpu/drm/panel/panel-simple.c | 29 ++++++++++++++++++++++++++++
>   1 file changed, 29 insertions(+)
> 
> diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c
> index dcb6d0b6ced0..80cca841db15 100644
> --- a/drivers/gpu/drm/panel/panel-simple.c
> +++ b/drivers/gpu/drm/panel/panel-simple.c
> @@ -3567,6 +3567,32 @@ static const struct panel_desc powertip_ph800480t013_idf02  = {
>   	.connector_type = DRM_MODE_CONNECTOR_DPI,
>   };
>   
> +static const struct drm_display_mode primeview_pm070wl4_mode = {
> +	.clock = 32000,
> +	.hdisplay = 800,
> +	.hsync_start = 800 + 42,
> +	.hsync_end = 800 + 42 + 128,
> +	.htotal = 800 + 42 + 128 + 86,
> +	.vdisplay = 480,
> +	.vsync_start = 480 + 10,
> +	.vsync_end = 480 + 10 + 2,
> +	.vtotal = 480 + 10 + 2 + 33,
> +	.flags = DRM_MODE_FLAG_NHSYNC | DRM_MODE_FLAG_NVSYNC,
> +};
> +
> +static const struct panel_desc primeview_pm070wl4 = {
> +	.modes = &primeview_pm070wl4_mode,
> +	.num_modes = 1,
> +	.bpc = 6,
> +	.size = {
> +		.width = 152,
> +		.height = 91,
> +	},
> +	.bus_flags = DRM_BUS_FLAG_DE_HIGH | DRM_BUS_FLAG_PIXDATA_SAMPLE_POSEDGE,
> +	.bus_format = MEDIA_BUS_FMT_RGB666_1X18,
> +	.connector_type = DRM_MODE_CONNECTOR_DPI,
> +};
> +
>   static const struct drm_display_mode qd43003c0_40_mode = {
>   	.clock = 9000,
>   	.hdisplay = 480,
> @@ -4725,6 +4751,9 @@ static const struct of_device_id platform_of_match[] = {
>   	}, {
>   		.compatible = "powertip,ph800480t013-idf02",
>   		.data = &powertip_ph800480t013_idf02,
> +	}, {
> +		.compatible = "primeview,pm070wl4",
> +		.data = &primeview_pm070wl4,
>   	}, {
>   		.compatible = "qiaodian,qd43003c0-40",
>   		.data = &qd43003c0_40,

Reviewed-by: Neil Armstrong <neil.armstrong@linaro.org>