From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 06738C25B4E for ; Sun, 22 Jan 2023 17:14:37 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230040AbjAVROg (ORCPT ); Sun, 22 Jan 2023 12:14:36 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36708 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229955AbjAVROf (ORCPT ); Sun, 22 Jan 2023 12:14:35 -0500 Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DE5354C26; Sun, 22 Jan 2023 09:14:32 -0800 (PST) Received: from [127.0.0.1] (p578adb1c.dip0.t-ipconnect.de [87.138.219.28]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: marex@denx.de) by phobos.denx.de (Postfix) with ESMTPSA id B04B685565; Sun, 22 Jan 2023 18:14:28 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=denx.de; s=phobos-20191101; t=1674407670; bh=qpvKbk0W1f539TSNkgyW7XATGGgOzHEwlUEFmsO6ZKg=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=jyVkpl1H7BgdVylsZAZ3tkofz9c+78/sh7bS8bAnx0wiWHV0bWUWhU1LQ04z+Dky1 G/7Is/tulu+1zBU+4cSPnM4s+S6J1spzQeRU/o+zSw0YNE+0qvlqWYwNQOIq1v5edu F73mWhVfnyUB6hSSwLSk9AZaDkyyCyIyDFNHs0YnCcd8mzDiizkLJ2wKmR2d0OJBWo dF58eUME7kcqRraF9zmmA89jTBkWISlsN+TMK/EUKtX2eOMvP9cn8yA7LT4tQ8o6Kj QjRPrwDEqcgv/KzNO2SrtXwqEBFGxQu9OATxHCLlVQZ5gZprN/otroBslxh/GdwdQb m3g3GD4ziju8Q== Message-ID: Date: Sun, 22 Jan 2023 18:14:28 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.0 Subject: Re: [PATCH v2 2/2] drm/bridge: fsl-ldb: Add i.MX93 LDB support Content-Language: en-US To: Liu Ying , dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Cc: andrzej.hajda@intel.com, neil.armstrong@linaro.org, robert.foss@linaro.org, Laurent.pinchart@ideasonboard.com, jonas@kwiboo.se, jernej.skrabec@gmail.com, airlied@gmail.com, daniel@ffwll.ch, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, linux-imx@nxp.com, krzysztof.kozlowski@linaro.org References: <20230122121836.778195-1-victor.liu@nxp.com> <20230122121836.778195-3-victor.liu@nxp.com> From: Marek Vasut In-Reply-To: <20230122121836.778195-3-victor.liu@nxp.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 1/22/23 13:18, Liu Ying wrote: > Same to i.MX8mp LDB, i.MX93 LDB is controlled by mediamix blk-ctrl > through LDB_CTRL and LVDS_CTRL registers. i.MX93 LDB supports only > one LVDS channel(channel 0) and it's LVDS_CTRL register bit1 is used > as LVDS_EN instead of CH1_EN. Add i.MX93 LDB support in the existing > i.MX8mp LDB bridge driver by adding i.MX93 LDB compatible string and > device data(to reflect different register offsets and LVDS_CTRL register > bit1 definition). > > Signed-off-by: Liu Ying > --- > v1->v2: > * No change. > > drivers/gpu/drm/bridge/fsl-ldb.c | 53 ++++++++++++++++++++++++++------ > 1 file changed, 44 insertions(+), 9 deletions(-) > > diff --git a/drivers/gpu/drm/bridge/fsl-ldb.c b/drivers/gpu/drm/bridge/fsl-ldb.c > index 9bcba8fc57e7..6ad63ac7367c 100644 > --- a/drivers/gpu/drm/bridge/fsl-ldb.c > +++ b/drivers/gpu/drm/bridge/fsl-ldb.c > @@ -18,7 +18,6 @@ > #include > #include > > -#define LDB_CTRL 0x5c > #define LDB_CTRL_CH0_ENABLE BIT(0) > #define LDB_CTRL_CH0_DI_SELECT BIT(1) > #define LDB_CTRL_CH1_ENABLE BIT(2) > @@ -35,9 +34,9 @@ > #define LDB_CTRL_ASYNC_FIFO_ENABLE BIT(24) > #define LDB_CTRL_ASYNC_FIFO_THRESHOLD_MASK GENMASK(27, 25) > > -#define LVDS_CTRL 0x128 > #define LVDS_CTRL_CH0_EN BIT(0) > #define LVDS_CTRL_CH1_EN BIT(1) It would be good to add a comment here that the bit is poorly named and that LVDS_CTRL_LVDS_EN=1 means DISABLE, while LVDS_CTRL_LVDS_EN=0 means ENABLE . > +#define LVDS_CTRL_LVDS_EN BIT(1) [...] With that fixed: Reviewed-by: Marek Vasut Thanks!