From: Krzysztof Kozlowski <krzk@kernel.org>
To: Doug Brown <doug@schmorgal.com>,
Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>
Cc: kbuild-all@lists.01.org, Jaroslav Kysela <perex@perex.cz>,
Takashi Iwai <tiwai@suse.com>, Rob Herring <robh+dt@kernel.org>,
patches@opensource.cirrus.com, alsa-devel@alsa-project.org,
devicetree@vger.kernel.org
Subject: Re: [PATCH 2/2] ASoC: wm8961: add support for devicetree
Date: Sun, 2 Oct 2022 10:35:27 +0200 [thread overview]
Message-ID: <a5f9ec49-f921-5efa-6721-d23671ec6bc0@kernel.org> (raw)
In-Reply-To: <a9a94d2d-5379-7e0b-b27c-cad0f569a773@schmorgal.com>
On 02/10/2022 07:04, Doug Brown wrote:
> On 10/1/2022 3:23 PM, kernel test robot wrote:
>
>>>> sound/soc/codecs/wm8961.c:974:34: warning: 'wm8961_of_match' defined but not used [-Wunused-const-variable=]
>> 974 | static const struct of_device_id wm8961_of_match[] = {
>> | ^~~~~~~~~~~~~~~
>
> Oops, nice catch by the kernel test robot. I will submit a V2 patch that
Now I see the report about issue I wrote to you. It's not particular
nice catch of robot... it's visible from the code and easily testable by
yourself. Even without compile test... The code was just not tested for
warnings.
> does this part exactly how the wm8960 driver does it, including
> .of_match_table in wm8961_i2c_driver. Waiting to see if I get any other
> feedback on V1 first.
maybe_unused instead of ifdefs.
Best regards,
Krzysztof
next prev parent reply other threads:[~2022-10-02 8:35 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-01 20:00 [PATCH 0/2] ASoC: add devicetree support for WM8961 codec Doug Brown
2022-10-01 20:00 ` [PATCH 1/2] ASoC: dt-bindings: add schema for WM8961 Doug Brown
2022-10-02 8:06 ` Krzysztof Kozlowski
2022-10-01 20:00 ` [PATCH 2/2] ASoC: wm8961: add support for devicetree Doug Brown
2022-10-01 22:23 ` kernel test robot
2022-10-02 5:04 ` Doug Brown
2022-10-02 8:35 ` Krzysztof Kozlowski [this message]
2022-10-02 17:54 ` Doug Brown
2022-10-02 8:08 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a5f9ec49-f921-5efa-6721-d23671ec6bc0@kernel.org \
--to=krzk@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=doug@schmorgal.com \
--cc=kbuild-all@lists.01.org \
--cc=lgirdwood@gmail.com \
--cc=patches@opensource.cirrus.com \
--cc=perex@perex.cz \
--cc=robh+dt@kernel.org \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).