From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BD8C82F549D for ; Wed, 17 Sep 2025 02:27:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1758076058; cv=none; b=pbryKrfpfwMnN3F8HTOd+dzWKk4g5pzJqM7QoHOvubCARey6/heVW1++BujGH/q5z6C5zFabrL3mXSXSOUCkTcv3fLQbwbeBO0evlzjkMhfh8rwaeCcXk7GHNOnJdQOXWyM8yCsk+F8gLLQPnzRu07+co8o05ca31qeL+iHR15Q= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1758076058; c=relaxed/simple; bh=ZVOSah7WyUCxAwtViCyBrw8IIhcxsA5kP+tsBwbzwsU=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=C9O6n3ap5i7/XEyABT2phnzc3079YUnF88USBGTm8VUfE83hQXFyD85w0maVxdqerKJH8LLkdkB+52nQUYB3FU2ItPJ1M8VMsNBeloSXxFElhVV4TH2oPL+QeEPLiMKYg0S6AzR+TcAjatddBYGJXPc2/3VWcoH3fx0zEeeQLnM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=gcO+71mJ; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="gcO+71mJ" Received: from pps.filterd (m0279867.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 58GLZiI8005453 for ; Wed, 17 Sep 2025 02:27:36 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= VYlZBe92chnYNBC11wB4N82uu0aHrj9AIx2n54JzLec=; b=gcO+71mJL/8mZHVd KTpDaJ5GD9zE9ZDehnMwHk6rKIja2rQLRRZgWlKeONk75jtlavNcmw90j2HVhWO8 8T+amM+VcWaGq8w9al1BypNRVR69vzy+Qn/xclMVMEvv9iXk2mscUkrrR/RLj66N ceztjk2EYqB0VrSlUOMiZ+lg17bsIFEIL1V3kJtgtA1kOut9FtPFqLbHwrO80YtF nzj8RUbROoDNrEPMJPV+Ct14KC9Gd5BzFw1jlJyptcEwmuPwCwgj1jVDSBoEjmqi uAOmauBBVSfhuvAJql51f6bLwfL37i5S7YkJZgv/THUzbOU8F5SQOy8xp4BOGXRD X84gvw== Received: from mail-pf1-f197.google.com (mail-pf1-f197.google.com [209.85.210.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 497fxu0k82-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Wed, 17 Sep 2025 02:27:35 +0000 (GMT) Received: by mail-pf1-f197.google.com with SMTP id d2e1a72fcca58-7725c995dd0so5618300b3a.3 for ; Tue, 16 Sep 2025 19:27:35 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1758076055; x=1758680855; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=VYlZBe92chnYNBC11wB4N82uu0aHrj9AIx2n54JzLec=; b=QqIBUGkAoQ4dsPwKPB8pkeZvXtsiV7nFZ7JClr365pTOn0yMU5E4hH0vucr5tNpzOD ioCHhto1oE2v8zsYNEdyELpx1ppw72eTAK+Zaqc3m4mVZUCzJ3ruG09XOLqlkj3/j33l fnDYNE4k3Xmu2vRsgda6hTlHjsiX9FTE81Z4s04i8eB/BZCyCGUFpY56lf5w4/JObihG CXU5e/2hP3Fn/51FnWXqrJHOv10Os9tPMfb5oJACf/68AxktSBx4f13ZjoL8O3OvqElg XD2Wf0dvcYnipyzCov9/NfdMcKd8vnUgjiT08MYJCG2I1sXvpbDI0jLpXRMZzllgB9y5 HLfw== X-Forwarded-Encrypted: i=1; AJvYcCW9hfv3WL7tcayaJ3bzit7XOTDBtMezhnWyF4q99/5fBuHZ5wQgDP/O01fhM6GD1Pvb45blC3GKmieo@vger.kernel.org X-Gm-Message-State: AOJu0YyUK796VrHh/GjNpgtVKofPbU01xh21kS27Q5y91FW9fq8VgKHf TqQijgo6XpYQAJ1iIGKx1FHRuhWnrAt0SlnyrmA07cPVMDaRSXFRbNmApY3LI2eUVUPbrFpzZjf UJD03KVWAjRzFRLqHy3vGsmUAVyE8VsvtvQuvz/g0KLuHVPoHT5jJpIHzfugVrOv3 X-Gm-Gg: ASbGnctt582cmJj97QdF79EdIuLOBINlLesBKjJjBGucWhr+JI+BtnLkJpINUVjXVmp 3M3U8ICAkzUeAh9tg1IF6K97A1qf/ABJszIWfKQSbzFJY7+06g4difAtmlS46sYO8pK9koWTjdn QVn78MmY/953x3GJgbxX4iRlWzPk2mmdyRDPTMgUsf6A3u6VpKNn70qvQZHK6Mt52vEycMarfA4 9dblaz9VJAevafFe+fe62LoE4Ft7uBSKd+mdup/GKtAgqi4nEAtEhzeOzWaJBvCuBZ7JpZFsKGh xtmweCO/i7nwu+FgDbc5xbWt8LDR4AeBfY6gNB+YDmAI+ho2PGRsb/agI3BEfk2t1aw1C7hhcri X4Dl5+u4YWJ1eHMbWOQBYO7GW2SR6f+Fjig== X-Received: by 2002:a05:6a00:228c:b0:771:e1bf:bddc with SMTP id d2e1a72fcca58-77bf75c1492mr538617b3a.13.1758076055082; Tue, 16 Sep 2025 19:27:35 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFa3nKVRZ5lcOuXaoBxQLObp2Qb9gc/ezSveqX2YOxEc/wcuth8hVIukLM4KDYuJgtiHtLYwA== X-Received: by 2002:a05:6a00:228c:b0:771:e1bf:bddc with SMTP id d2e1a72fcca58-77bf75c1492mr538603b3a.13.1758076054636; Tue, 16 Sep 2025 19:27:34 -0700 (PDT) Received: from [10.133.33.240] (tpe-colo-wan-fw-bordernet.qualcomm.com. [103.229.16.4]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-7761853866bsm14036121b3a.95.2025.09.16.19.27.29 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 16 Sep 2025 19:27:34 -0700 (PDT) Message-ID: Date: Wed, 17 Sep 2025 10:27:29 +0800 Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 5/8] power: supply: qcom_battmgr: update compats for SM8550 and X1E80100 To: Dmitry Baryshkov Cc: Sebastian Reichel , Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Heikki Krogerus , Greg Kroah-Hartman , Bryan O'Donoghue , Konrad Dybcio , Subbaraman Narayanamurthy , David Collins , =?UTF-8?Q?Gy=C3=B6rgy_Kurucz?= , linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, kernel@oss.qualcomm.com, devicetree@vger.kernel.org, linux-usb@vger.kernel.org, Neil Armstrong References: <20250915-qcom_battmgr_update-v4-0-6f6464a41afe@oss.qualcomm.com> <20250915-qcom_battmgr_update-v4-5-6f6464a41afe@oss.qualcomm.com> Content-Language: en-US From: Fenglin Wu In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUwOTE2MDIwMiBTYWx0ZWRfX8b5MUIfO3QKB GnC+ZbOn+7u10ZhX4LlInIdstZQWnsviQVz0Mzc+hzOUYNzcziN7byTwef5RCcPZh4gBVOainex NMeZTWbjSVnTQrPdA55lA46ipqoqhisUahL8U6eaFezSPOcnk/ZqwFpIiezl4GU43GAAsTr7h1N kS3KGpikPt7ZYLcM7ssV8mxHa6kq6XAH0uNZ41uOmIiv9rCZm/vtnrkqEMFIdLFu14NRC+3J5O1 F5W3OxjgYNLuBuudYY30bNsNS4BV9uPGMATyKNEG8k5G5fnzo7BJlZUZF1ZOmakXfSQgNA6OJ+w F4EkiE+Rns/qtvhIWUhrAibFO0vkVTL1nacJ2mZXZ8zzDRDiZhdfFXMXm2haj72nyTtO7LxOEzF 54u8OBkc X-Proofpoint-ORIG-GUID: bEnyacbb7r-uFucrFB466T8J_fEt0wzv X-Authority-Analysis: v=2.4 cv=R+UDGcRX c=1 sm=1 tr=0 ts=68ca1c98 cx=c_pps a=rEQLjTOiSrHUhVqRoksmgQ==:117 a=nuhDOHQX5FNHPW3J6Bj6AA==:17 a=IkcTkHD0fZMA:10 a=yJojWOMRYYMA:10 a=EUspDBNiAAAA:8 a=KKAkSRfTAAAA:8 a=lQXKqyNTGrdWrY9AsKwA:9 a=QEXdDO2ut3YA:10 a=2VI0MkxyNR6bbpdq8BZq:22 a=cvBusfyB2V15izCimMoJ:22 X-Proofpoint-GUID: bEnyacbb7r-uFucrFB466T8J_fEt0wzv X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1117,Hydra:6.1.9,FMLib:17.12.80.40 definitions=2025-09-16_02,2025-09-16_01,2025-03-28_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 phishscore=0 adultscore=0 clxscore=1015 priorityscore=1501 bulkscore=0 malwarescore=0 suspectscore=0 impostorscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.19.0-2507300000 definitions=main-2509160202 On 9/16/2025 6:16 PM, Dmitry Baryshkov wrote: > On Tue, Sep 16, 2025 at 10:40:03AM +0800, Fenglin Wu wrote: >> On 9/15/2025 6:19 PM, Dmitry Baryshkov wrote: >>> On Mon, Sep 15, 2025 at 04:49:57PM +0800, Fenglin Wu via B4 Relay wrote: >>>> From: Fenglin Wu >>>> >>>> Add variant definitions for SM8550 and X1E80100 platforms. Add a compat >>>> for SM8550 and update match data for X1E80100 specifically so that they >>>> could be handled differently in supporting charge control functionality. >>> Why? >> Is the question about why this was submitted as a separate patch, or about >> the need for the change itself? The reason for the change is explained in >> the commit text. > It's not, and that was my question. Why do you need to handle them > differently? > > Please always start your commit message with the description of the > issue that you are facing. > The simple answer is, the charge control functionality is only supported in battery management firmware starting from SM8550 and X1E80100. I will add this statement in the commit text. >> As for submitting it separately, that was done to address >> Bryan's comments to split out the compats changes. Anyway, I will address >> the further comments from Stephen to make the change bisectable. >>>> Tested-by: Neil Armstrong # on Thinkpad T14S OLED >>>> Signed-off-by: Fenglin Wu >>>> --- >>>> drivers/power/supply/qcom_battmgr.c | 7 +++++-- >>>> 1 file changed, 5 insertions(+), 2 deletions(-) >>>>