From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 835FA48F00F for ; Wed, 14 Oct 2026 12:39:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1791981547; cv=none; b=WeZjcnZckZMZfuYfeN1Pyd3ZTnS4+5krNUWFtEQBbvsvBCm6zwTXz2okjvfONYROafxwLHCOcD/1aGIs8OxMTF2EkYdgUkcjahvkmSKQBPPsEnKacrGuHB0NL/pglJ1Kac3ZgNbPTWyTWKSNRHjfbC4LT6zBz1X6RJZY7v15Epg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1791981547; c=relaxed/simple; bh=l1jRMWxG8RdouFaSgoCqrvZ1hJGAI4dQoynHDRwfyhk=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=jz9TbfHul1vB4hsEdclmCC0ho2IjXjdq3EC+QBsumXtnEUx9Xr8kSMMQghwScvbXH51+u/mHXqEYnwK5id8fwaHRlzF9Q+3+LbrDezmc+m4DIiP7F+KYBgpv7ZhlIqqWK+K4fSZps+ft+d5m0E7wckymZA4/TlTe+10Mq2g1iYg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=F09bMLUg; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=SrjmfvaL; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="F09bMLUg"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="SrjmfvaL" Received: from pps.filterd (m0279873.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 69EBSNFq3365345 for ; Wed, 14 Oct 2026 12:39:05 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= W8LWP4j+bIpY8MUEJUHYxf6cp4BonPSG9HyxtvJUqRY=; b=F09bMLUgmIud66IR bGEjfC8h0uO4+ZE471JhFlskW1uqinYqAfrBAyYuSv8Jyq5vFAG9M0ZIsYyuB4x9 JtqMhSipBbwmHPUFj9YFsoV6b6t5adWkKFl7bpE0G6LdJ0FTFc/np2nNJ+sh41qs p+UsDbvk+1yJHsTR+EkUsT7M6tMHtDpS07S6SiliFZSGDjepHAGvjz7PTpTfoUqo GYNUoSuflpNuU0FZrpOpVic2HN3MoL6i1/EDA/zlDzMUIPFSm9WDoj3CequkCi3k b9ji1OU1/2Fzzmpv1duEsOAnUXKHiNfdERnyakYUHq/PvBZhiFhkbLjVXh/46qMG ntzNlg== Received: from mail-pj1-f70.google.com (mail-pj1-f70.google.com [209.85.216.70]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4ha4621k88-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 14 Oct 2026 12:39:05 +0000 (GMT) Received: by mail-pj1-f70.google.com with SMTP id 98e67ed59e1d1-3a470ead068so4415616a91.3 for ; Wed, 14 Oct 2026 05:39:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1791981544; x=1792586344; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=W8LWP4j+bIpY8MUEJUHYxf6cp4BonPSG9HyxtvJUqRY=; b=SrjmfvaLsbgxhL19xxJyfbkzlCqOKZHIvTihkBexitVcOlmKUNcTFC7DzjjVNmMM9N xEHcGnVYUzcwvVcWvM2EcwZ3BMAfTjp8ApRzB3xH0vVAvpKu6JD+tKmJgt3fnwFSZFVo PQuJb35OTpePDKhC5RbNgMYplSxhV0yqVSRlnW/w4LpGyf6J/8Slbpr0LYw0kr1eqiq+ nzwTOH4/5Pwe/jgYqwgsgzORH1FGyEaArbCng1svIGuQgTOLklQlQkwghPRmKb3rtd2d YSS4PsGQGYzq7vOi2hgiZvrDn9cnESL66B9EF3mlikl2IkFyCGAtQ7v+Rv1AwlpoU8uc IesQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1791981544; x=1792586344; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=W8LWP4j+bIpY8MUEJUHYxf6cp4BonPSG9HyxtvJUqRY=; b=Mewd1O03TVJsAu7u0XhIQNGtv7lPvrD8T981123RnDPDtHTosxkfW2B1tqQLwk9PXr Kblv54pWrAFpsyRYjKPx62/2ZfqJNhpG+qDoxM67jjd+dyTmCd8gX3ClflTJTM1D2olb k+cZMNN/XBzkndT0vCksDmvY8J7elGai8yG0aRl3cHZ6fRmWUmlsDK+kbs2klEzueh/m Fp/e7UZFHBIfdHhQ0jsd3I/KjrAzG5nu/rHXsg3db1f1lNQh3MrHnq2gmUpMQvYwlKpu dl9c7wg5NVbpejRaRHipSuHoSv8pQrwqU12X4qhR3wHu6p2b3sryMSRnXSbBaYYSz7YI BdQw== X-Forwarded-Encrypted: i=1; AKwUvBxRNwjixf/30wTnJE6vQKSoJRbdqZajvoMkjSIud9KHSsh3mfPoH6A6nw7QyY2BbYuUVRYjpkKy0rpd@vger.kernel.org X-Gm-Message-State: AFq9FYLhyEB/gLQBA01D1AnMyn5Ld3ZmJ030Gao8Yf09Z0Pv5vKy4AQ1 8T6mDiReQ9D69+d1htDoGy3oDPu0BHw78L5PVjZb4P+uy3W18DYvSPCzsOMFmTRKl8RK7n0IEH+ +0ryNpZttgLZc1f4LKFjRU4GSD2iagU0u5ObBF/OZZXUnB0ToH9bbolXaLbMwVMP5 X-Gm-Gg: AYBFou0YuHaGSp3CYDA+MyAc2ksmNIwpWRUjwiw9Isroph8KMnw8WzQRL9+ze7R8ega v5ppzl4qt72adxD9GoZnwIVfxW2FXfCKRcYws5r60FqyW11tyE1Wylf+QhECdc0VpWN5Ng85CgL h5OPnxca1p5pp0Tkpi+b7HSXTK09pjHq9oop3PBD7R30S1cVm72fPc23VQLxsboghrDqsqolkph ZQHY/fzFJ1TwVJYwL5x2TRCEEotST+0AtThFpGWUZAnQagM5BY9QjVZlErtQjctcXlJ73jBKovD v+dOhXDoNBstfIvv0PwYL3FZjlHtCwND4E2jHHrIkbLatu8DURTeb96V8jwEvsdYHKu6FbQID9a 9UZ9FZQw884odBPCOrRRbpKGRzzNMU5U0qPZHU3KguqADU3/wJgEBafuXBuxYbaeAg55lfBxbaR KusE2J//ke+ebA6wKqwMFV0QJH0bo= X-Received: by 2002:a17:90b:3c8c:b0:3a4:967c:6947 with SMTP id 98e67ed59e1d1-3ab3a99b4d0mr11899807a91.21.1791981544206; Wed, 14 Oct 2026 05:39:04 -0700 (PDT) X-Received: by 2002:a17:90b:3c8c:b0:3a4:967c:6947 with SMTP id 98e67ed59e1d1-3ab3a99b4d0mr11899778a91.21.1791981543678; Wed, 14 Oct 2026 05:39:03 -0700 (PDT) Received: from [10.149.108.218] (blr-bdr-fw-01_GlobalNAT_AllZones-Outside.qualcomm.com. [103.229.18.19]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-3ac5f2ba9efsm4368806a91.16.2026.10.14.05.38.56 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 14 Oct 2026 05:39:03 -0700 (PDT) Message-ID: Date: Wed, 14 Oct 2026 18:08:54 +0530 Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 5/5] arm64: dts: qcom: Add Microsoft Surface Laptop 8th Edition To: Konrad Dybcio , Bjorn Andersson , Konrad Dybcio , Abel Vesa , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Maximilian Luz , Hans de Goede , =?UTF-8?Q?Ilpo_J=C3=A4rvinen?= , Douglas Anderson , Neil Armstrong , Jessica Zhang , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Sibi Sankar , Pankaj Patil Cc: Rajendra Nayak , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, platform-driver-x86@vger.kernel.org, dri-devel@lists.freedesktop.org References: <20261006-mahua-surface-laptop-v1-0-406fc042162a@oss.qualcomm.com> <20261006-mahua-surface-laptop-v1-5-406fc042162a@oss.qualcomm.com> <762978b8-72ce-4836-85f4-2cd3ee4dc5cf@oss.qualcomm.com> Content-Language: en-US From: Gopikrishna Garmidi In-Reply-To: <762978b8-72ce-4836-85f4-2cd3ee4dc5cf@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Proofpoint-ORIG-GUID: 3FWSvHMH_N6yO-S4wKvpNK1sN_WuCjkm X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYxMDE0MDA1MCBTYWx0ZWRfX0fiZZMgTtdEy 5fHcIWmrv69cifJbp3UEDNwyKCh6EUpVr+GeC3EAp3qCpKphXLSwkzkxukIfUs9Jji489IS8r49 nN+mc5xdKZUPoJhs0IBhuD5cF2a8imtprvOXGaaOWeMdTCUnYhs+RftypUW8d+CjkqanHI5fdnc UTGHqUhlhuXgj2nxujtC35G142zSuZJP0S8UEsFcSakRiutKcxuWAe8oqYSzdmvB+URuQ+pn0tC 1t4h6GPgeL63lfKgj03f6kbPobua3ylPIf6yAb3wr5ezCOLAuQXeef/XeVHLM6ruMt4gt1f7OPC 2f7t+x+9rlN/hj7zrG/dDIK4rMOW+LdcM+GPYvrXGh8RP0vMOgA2KVYgvAIfHzN6C/aLYm6WMSl dFd4gKOZJYAzU8FgXX3k2ThWVIznvFu+dMepQlZ3qB/hvcngCKwNJMVJJwG+mSBVyIbJK4SvSBU uUapjlnTuTbsIRLxVLg== X-Authority-Analysis: v=2.4 cv=ErZHPicA c=1 sm=1 tr=0 ts=6acf77e9 cx=c_pps a=0uOsjrqzRL749jD1oC5vDA==:117 a=Ou0eQOY4+eZoSc0qltEV5Q==:17 a=IkcTkHD0fZMA:10 a=660iZSQnnn4A:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=rJkE3RaqiGZ5pbrm-msn:22 a=VwQbUJbxAAAA:8 a=EUspDBNiAAAA:8 a=03qAMiCteCMXZj9sYoEA:9 a=QEXdDO2ut3YA:10 a=mQ_c8vxmzFEMiUWkPHU9:22 X-Proofpoint-Spam-Info: AW1haW4tMjYxMDE0MDA1MCBTYWx0ZWRfX3GPamef/1gaZ VEP8HCMA7TLUOlQCfEJhgEfltYKeomjBy2/dXXJ2SBN/FblJJP2AyelPGSTbVIRU0UIie0ZVZsS 4kdQrNAzBfQGhdyvMQLNght6aa8DdMw= X-Proofpoint-GUID: 3FWSvHMH_N6yO-S4wKvpNK1sN_WuCjkm X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-10-13_01,2026-10-09_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 phishscore=0 malwarescore=0 bulkscore=0 impostorscore=0 adultscore=0 suspectscore=0 clxscore=1015 lowpriorityscore=0 priorityscore=1501 spamscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2610080000 definitions=main-2610140050 Hi Konrad, On 10/13/2026 4:00 PM, Konrad Dybcio wrote: > On 10/6/26 11:50 AM, Gopikrishna Garmidi wrote: >> Add support for the Microsoft Surface Laptop 13.8" 8th Edition, which is >> built on the Mahua SoC. Most of the board follows the Qualcomm reference >> design. The keyboard, fan and platform profile sit behind the Surface >> Aggregator Module on uart22, same as on the Surface Laptop 7. > > [...] > >> +&mdss_dp3_out { >> + data-lanes = <0 1 2 3>; >> + /* HBR2 channel equalization fails, limit the link to HBR */ >> + link-frequencies = /bits/ 64 <1620000000 2700000000>; > > Oops, that's no good - is there a chance this helps? > > https://lore.kernel.org/linux-arm-msm/20260622-glymur-edp-phy-v1-2-814b45089ac9@oss.qualcomm.com/ > Thanks for the pointer. It helps, but doesn't get HBR2 working. The panel (SHP LQ138P1JX61) supports up to HBR2. With all rates allowed, clock recovery passes every time, and channel EQ goes like this: without patch with patch HBR2 x4 fail fail HBR2 x2 fail fail HBR2 x1 fail pass Without the patch the sink asks for swing 2 / pre-emphasis 2 on all lanes and never locks. With it, lane 0 settles at pre-emphasis 1, but lanes 1-3 still sit at 2 and fail. A single lane doesn't have enough bandwidth for the native mode, so it seems the PHY still needs more tuning at HBR2. Limited to HBR, 4 lanes train first time, so I'd like to keep that in v2 for now. Happy to test anything else you have in mind. > [...] > >> +&usb_0 { >> + dr_mode = "host"; > > OTG should work just fine on both ports Will drop dr_mode in v2. Thanks, Gopikrishna