From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E590EEB64DA for ; Sat, 17 Jun 2023 14:44:08 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235617AbjFQOoH (ORCPT ); Sat, 17 Jun 2023 10:44:07 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56166 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235476AbjFQOoF (ORCPT ); Sat, 17 Jun 2023 10:44:05 -0400 Received: from mail-ed1-x52f.google.com (mail-ed1-x52f.google.com [IPv6:2a00:1450:4864:20::52f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 897E21FE2 for ; Sat, 17 Jun 2023 07:44:03 -0700 (PDT) Received: by mail-ed1-x52f.google.com with SMTP id 4fb4d7f45d1cf-51a3e7a9127so2954247a12.1 for ; Sat, 17 Jun 2023 07:44:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1687013042; x=1689605042; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=KK2+YFUG/6HmL4tcdhB8f8ESWlAE0VcF40UXIVzAPuo=; b=uRkenpha2+Snmt2ZqLpbiOEu7lU0WybjKCO73iSIQE8Uu9AevsrBAAIbbG0jobIoie g1X3Pql5QlV4aL26S5MbUKVwefxWQP7+8omvrHKRjkh4H7ELph0Udn54Li/0lDgjwCjz PKR1MjnETnS7b9yTta1/+kYxnHiLBYp0cSv97Au6wdgGuNkOyQ+FLyNHRIHcaRlqoXuq abDbL99zb0WRxwoOpWlmA6KtJyPIbjBaamsFOCKdKIA82V2/tP9XCLWW6k+1D1V7hokN JvkjhCZb02tFrqVUb681zLCIW/9T8jSzsSTZxXO1zwQhBCFGCOfmfWJ/qWP3NzUOxo4h A2kA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1687013042; x=1689605042; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=KK2+YFUG/6HmL4tcdhB8f8ESWlAE0VcF40UXIVzAPuo=; b=jlQnp28PZQmcofAf6TenZ5voI3W8XYGgmSkuecLElKIs8bSaLmMA0Q0wwlPaYbTzq8 WQZO/24EQLaCUFdvt6TwrNXkc2gYqa6k4hS4mmpdTD1u36+6T1FqUt0vSGGi0dVUe6Rk 9eK4kp5c289FPyYY/4yNpCyw6hDR07xuWGpmbbEFOFF8nx+nX1T3oeHb0ryG1H+RZJ7e c9SBe2A4ePrPG68rzYpeFqK/Jtjt60rqHjp6UrzCXoHDJaMPIzJqjCdlWtkxADI5LIoi SLOVM+Rw/ttbJ5R1OPkHoqczpkWe4RBYkCyu4f0rK6YPGTXJxs3Oj+LN8DAqjm12pw0c wgkg== X-Gm-Message-State: AC+VfDxZlOXXfXf3tqbmgnqPVrAliph0iwj80IgrxGt2q7VCHkddF/a5 y/euTJg+r5OTMCogOxZYyfnpBw== X-Google-Smtp-Source: ACHHUZ5Fu0+bj+UPlLd3J6AJvxrm4h1iSaRendUhAIKFPorvmtKoMwQaDwq/rbuf4+ub5GoxYwYsTg== X-Received: by 2002:a05:6402:18c:b0:518:741e:9314 with SMTP id r12-20020a056402018c00b00518741e9314mr4660226edv.11.1687013042132; Sat, 17 Jun 2023 07:44:02 -0700 (PDT) Received: from [192.168.1.20] ([178.197.219.26]) by smtp.gmail.com with ESMTPSA id u3-20020aa7d543000000b00514bddcb87csm11293575edr.31.2023.06.17.07.44.00 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 17 Jun 2023 07:44:01 -0700 (PDT) Message-ID: Date: Sat, 17 Jun 2023 16:43:59 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 Subject: Re: [PATCH v3 2/9] clk: ralink: add clock and reset driver for MTMIPS SoCs Content-Language: en-US To: Sergio Paracuellos , Shiji Yang Cc: arinc.unal@arinc9.com, devicetree@vger.kernel.org, john@phrozen.org, krzysztof.kozlowski+dt@linaro.org, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mips@vger.kernel.org, matthias.bgg@gmail.com, mturquette@baylibre.com, p.zabel@pengutronix.de, robh+dt@kernel.org, sboyd@kernel.org, tsbogend@alpha.franken.de References: <20230617052435.359177-3-sergio.paracuellos@gmail.com> From: Krzysztof Kozlowski In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 17/06/2023 15:26, Sergio Paracuellos wrote: >>> void __init plat_time_init(void) >>> { >>> + struct of_phandle_args clkspec; >>> struct clk *clk; >>> + int cpu_clk_idx; >>> >>> ralink_of_remap(); >>> >>> - ralink_clk_init(); >>> - clk = clk_get_sys("cpu", NULL); >>> + cpu_clk_idx = clk_cpu_index(); >>> + if (cpu_clk_idx == -1) >>> + panic("unable to get CPU clock index"); >>> + >>> + of_clk_init(NULL); >>> + clkspec.np = of_find_node_by_name(NULL, "sysc"); >> >> The node name should be "syscon" as the example node name in the >> dt-bindings document is "syscon". > > sysc is label to get this node since it is the one shared by all > different dtsi files. If it is label, why do you use it to get by name? name != label. Best regards, Krzysztof