From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.1 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 219DDC433E7 for ; Thu, 3 Sep 2020 04:42:59 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id F02D620716 for ; Thu, 3 Sep 2020 04:42:58 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=aj.id.au header.i=@aj.id.au header.b="K3vW7dmx"; dkim=pass (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b="gD6XvDqk" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725919AbgICEm6 (ORCPT ); Thu, 3 Sep 2020 00:42:58 -0400 Received: from out2-smtp.messagingengine.com ([66.111.4.26]:33095 "EHLO out2-smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725851AbgICEm5 (ORCPT ); Thu, 3 Sep 2020 00:42:57 -0400 Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.nyi.internal (Postfix) with ESMTP id 5AF695C010D; Thu, 3 Sep 2020 00:42:56 -0400 (EDT) Received: from imap2 ([10.202.2.52]) by compute3.internal (MEProxy); Thu, 03 Sep 2020 00:42:56 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=aj.id.au; h= mime-version:message-id:in-reply-to:references:date:from:to:cc :subject:content-type; s=fm3; bh=em2gJ9qv2xaShz9T9qAmKSzyXIMr3uD xP9oDgcz1OBc=; b=K3vW7dmxebVbx2mlGf9mZ9zrgvsttX/8tMwUxsC0XM9+RWN u8paQVDMbD+4MM/4JysPAiHOqt/2JZfuWG8qywledeeaAGQDzWjLsaTQmSZCtruR c0IzrG0x+p4gOoXXYATcDMmLjatoQT/fCToxMpTDyKidFmBCO/zOySHT9RTWlTqc GnDqGcLImDVhGmr94UyMWrHZbOJG+a7hmmHEwy+FDiLaZBet/ykRDv18UJLxaBv1 voN3CLVijkw+xYSNxogYeNbMNYmN6aaYGG6zYOmGh8tbudHlHmnMLtr/Ar89zDzz hzzB48oRa17eSGOVrUXWjx1NMsHz7qo/hiKnO8g== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; bh=em2gJ9 qv2xaShz9T9qAmKSzyXIMr3uDxP9oDgcz1OBc=; b=gD6XvDqkN9/mt8hFDcN1yR m6Sma7YJroztK2r/UODvU26B89CRJViHz0/krCNIZCf2l8PqOCyqfXEg5DXjVFf+ Bnivd4sZSaWlcX516tBO8gsb89SVUOjT8e+8SlzgCAhvd8cHLUok55QJg8MPKnty kWrvgQsBYdoT1auRGDM5nyu8PsuTcUiEpJlSDFjJ5IL8SNL3oEWpVRYZhKkp2BcP xk4dWueIR9QmunZenmyb78Fp9r2LIyXGqrxZydlvzTx/hiW+r2Kr44POm81Gq/OY nsiDb+j4+qAt+R5/dkOSaG+c0UW6YNoHLxReSGiQkR510omFV1TV0Nu5thiiN5ig == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduiedrudegtddgkeeiucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepofgfggfkjghffffhvffutgesthdtredtreertdenucfhrhhomhepfdetnhgu rhgvficulfgvfhhfvghrhidfuceorghnughrvgifsegrjhdrihgurdgruheqnecuggftrf grthhtvghrnhephefhfeekgfekudevheffheeihedujeefjeevjeefudfgfeeutdeuvdeh hfevueffnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomh eprghnughrvgifsegrjhdrihgurdgruh X-ME-Proxy: Received: by mailuser.nyi.internal (Postfix, from userid 501) id 0417CE00DF; Thu, 3 Sep 2020 00:42:55 -0400 (EDT) X-Mailer: MessagingEngine.com Webmail Interface User-Agent: Cyrus-JMAP/3.3.0-257-g770afc8-fm-20200903.002-g770afc8a Mime-Version: 1.0 Message-Id: In-Reply-To: <20200728025527.174503-2-joel@jms.id.au> References: <20200728025527.174503-1-joel@jms.id.au> <20200728025527.174503-2-joel@jms.id.au> Date: Thu, 03 Sep 2020 14:12:34 +0930 From: "Andrew Jeffery" To: "Joel Stanley" , linux-fsi@lists.ozlabs.org, "Rob Herring" Cc: linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, "Eddie James" Subject: Re: [PATCH 1/5] dt-bindings: fsi: Document gpios Content-Type: text/plain Sender: devicetree-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Tue, 28 Jul 2020, at 12:25, Joel Stanley wrote: > The FSI master has some associated GPIOs that may be present on some > hardware configurations. > > Signed-off-by: Joel Stanley > --- > .../devicetree/bindings/fsi/fsi-master-aspeed.txt | 12 ++++++++++++ > 1 file changed, 12 insertions(+) > > diff --git > a/Documentation/devicetree/bindings/fsi/fsi-master-aspeed.txt > b/Documentation/devicetree/bindings/fsi/fsi-master-aspeed.txt > index b758f91914f7..a513e65ec0c9 100644 > --- a/Documentation/devicetree/bindings/fsi/fsi-master-aspeed.txt > +++ b/Documentation/devicetree/bindings/fsi/fsi-master-aspeed.txt > @@ -12,6 +12,13 @@ Required properties: > - pinctrl-0: phandle to pinctrl node > - pinctrl-names: pinctrl state > > +Optional properties: > + - cfam-reset-gpios: GPIO for CFAM reset > + > + - fsi-routing-gpios: GPIO for setting the FSI mux (internal or cabled) > + - fsi-mux-gpios: GPIO for detecting the desired FSI mux state > + > + Is the double-linebreak intentional? Anyway: Reviewed-by: Andrew Jeffery > Examples: > > fsi-master { > @@ -21,4 +28,9 @@ Examples: > pinctrl-names = "default"; > pinctrl-0 = <&pinctrl_fsi1_default>; > clocks = <&syscon ASPEED_CLK_GATE_FSICLK>; > + > + fsi-routing-gpios = <&gpio0 ASPEED_GPIO(Q, 7) GPIO_ACTIVE_HIGH>; > + fsi-mux-gpios = <&gpio0 ASPEED_GPIO(B, 0) GPIO_ACTIVE_HIGH>; > + > + cfam-reset-gpios = <&gpio0 ASPEED_GPIO(Q, 0) GPIO_ACTIVE_LOW>; > }; > -- > 2.27.0 > >