From: Taniya Das <quic_tdas@quicinc.com>
To: Konrad Dybcio <konrad.dybcio@linaro.org>,
Bjorn Andersson <andersson@kernel.org>,
Michael Turquette <mturquette@baylibre.com>,
"Stephen Boyd" <sboyd@kernel.org>, Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
Cc: <linux-arm-msm@vger.kernel.org>, <linux-clk@vger.kernel.org>,
<devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<quic_imrashai@quicinc.com>, <quic_jkona@quicinc.com>
Subject: Re: [PATCH v3 4/8] clk: qcom: Add support for Camera Clock Controller on SA8775P
Date: Fri, 16 Aug 2024 10:43:41 +0530 [thread overview]
Message-ID: <a619c8fa-e107-435d-a09f-487c31e68b86@quicinc.com> (raw)
In-Reply-To: <c3126e10-05f9-43a6-aa9d-d96354e27382@linaro.org>
On 7/16/2024 5:37 PM, Konrad Dybcio wrote:
> On 15.07.2024 10:23 AM, Taniya Das wrote:
>> Add support for Camera Clock Controller on SA8755P platform.
>>
>> Signed-off-by: Taniya Das <quic_tdas@quicinc.com>
>> ---
>
> [...]
>
>> +
>> +static struct gdsc cam_cc_titan_top_gdsc = {
>> + .gdscr = 0x131bc,
>> + .en_rest_wait_val = 0x2,
>> + .en_few_wait_val = 0x2,
>> + .clk_dis_wait_val = 0xf,
>
> Shouldn't this also have a .cxcs relating to GCC_CAMERA_AHB_CLK?
>
> Konrad
Not really required, this external GCC clock would be kept always
enabled from GCC driver.
--
Thanks & Regards,
Taniya Das.
next prev parent reply other threads:[~2024-08-16 5:13 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-15 8:23 [PATCH v3 0/8] Add support for SA8775P Multimedia clock controllers Taniya Das
2024-07-15 8:23 ` [PATCH v3 1/8] dt-bindings: clock: qcom: Add SA8775P video clock controller Taniya Das
2024-07-16 7:44 ` Krzysztof Kozlowski
2024-07-29 10:41 ` Tengfei Fan
2024-08-16 4:35 ` Taniya Das
2024-07-15 8:23 ` [PATCH v3 2/8] clk: qcom: Add support for Video clock controller on SA8775P Taniya Das
2024-07-16 12:05 ` Konrad Dybcio
2024-08-16 5:12 ` Taniya Das
2024-07-15 8:23 ` [PATCH v3 3/8] dt-bindings: clock: qcom: Add SA8775P camera clock controller Taniya Das
2024-07-15 8:23 ` [PATCH v3 4/8] clk: qcom: Add support for Camera Clock Controller on SA8775P Taniya Das
2024-07-16 12:07 ` Konrad Dybcio
2024-08-16 5:13 ` Taniya Das [this message]
2024-07-15 8:23 ` [PATCH v3 5/8] dt-bindings: clock: qcom: Add SA8775P display clock controllers Taniya Das
2024-07-15 8:23 ` [PATCH v3 6/8] clk: qcom: Add support for Display clock Controllers on SA8775P Taniya Das
2024-07-15 8:23 ` [PATCH v3 7/8] arm64: dts: qcom: Add support for multimedia clock controllers Taniya Das
2024-07-16 7:45 ` Krzysztof Kozlowski
2024-07-16 12:09 ` Konrad Dybcio
2024-07-29 10:42 ` Tengfei Fan
2024-08-16 5:18 ` Taniya Das
2024-07-15 8:23 ` [PATCH v3 8/8] arm64: dts: qcom: Update sleep_clk frequency to 32000 on SA8775P Taniya Das
2024-07-16 7:45 ` Krzysztof Kozlowski
2024-08-16 5:16 ` Taniya Das
2024-07-16 12:08 ` Konrad Dybcio
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a619c8fa-e107-435d-a09f-487c31e68b86@quicinc.com \
--to=quic_tdas@quicinc.com \
--cc=andersson@kernel.org \
--cc=bartosz.golaszewski@linaro.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=konrad.dybcio@linaro.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=quic_imrashai@quicinc.com \
--cc=quic_jkona@quicinc.com \
--cc=robh@kernel.org \
--cc=sboyd@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).