From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thor Thayer Subject: Re: [PATCHv2] arm64: dts: stratix10: Add QSPI support for Stratix10 Date: Tue, 15 May 2018 15:10:41 -0500 Message-ID: References: <1526055052-11371-1-git-send-email-thor.thayer@linux.intel.com> <20b33e1d-0609-78dd-dc9c-922658a11f18@kernel.org> Reply-To: thor.thayer@linux.intel.com Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20b33e1d-0609-78dd-dc9c-922658a11f18@kernel.org> Content-Language: en-US Sender: linux-kernel-owner@vger.kernel.org To: Dinh Nguyen , robh+dt@kernel.org, mark.rutland@arm.com Cc: catalin.marinas@arm.com, will.deacon@arm.com, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org List-Id: devicetree@vger.kernel.org On 05/15/2018 10:11 AM, Dinh Nguyen wrote: > > On 05/11/2018 11:10 AM, thor.thayer@linux.intel.com wrote: >> From: Thor Thayer >> >> Add qspi_clock >> The qspi_clk frequency is updated by U-Boot before starting Linux. >> Add QSPI interface node. >> Add QSPI flash memory child node. >> Setup the QSPI memory in 2 partitions. >> >> Signed-off-by: Thor Thayer >> --- >> v2 s/_/-/ in qspi-clk >> rename flash node. >> use partition child node notation>> + qspi: spi@ff8d2000 { >> + compatible = "cdns,qspi-nor"; >> + #address-cells = <1>; >> + #size-cells = <0>; >> + reg = <0xff8d2000 0x100>, >> + <0xff900000 0x100000>; >> + interrupts = <0 3 4>; >> + cdns,fifo-depth = <128>; >> + cdns,fifo-width = <4>; >> + cdns,trigger-address = <0x00000000>; >> + clocks = <&qspi_clk>; >> + bus-num = <1>; > > I don't you need "bus-num" anymore right? I don't see it getting used > anywhere in the driver. > > Dinh > Yes, I missed that holdover. Thanks, I'll correct that.