From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: "Jaewon Kim" <jaewon02.kim@samsung.com>,
"Thierry Reding" <thierry.reding@gmail.com>,
"Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>,
"Rob Herring" <robh+dt@kernel.org>,
"Krzysztof Kozlowski" <krzysztof.kozlowski+dt@linaro.org>,
"Conor Dooley" <conor+dt@kernel.org>,
"Alim Akhtar" <alim.akhtar@samsung.com>
Cc: linux-pwm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-samsung-soc@vger.kernel.org
Subject: Re: [PATCH v5 2/2] arm64: dts: exynos: add pwm node for exynosautov9-sadk
Date: Tue, 18 Jul 2023 08:06:29 +0200 [thread overview]
Message-ID: <a62141a9-a2c0-6568-cb05-5ef59250e10f@linaro.org> (raw)
In-Reply-To: <20230718034201.136800-3-jaewon02.kim@samsung.com>
On 18/07/2023 05:42, Jaewon Kim wrote:
> Add pwm node to support fan on exynosautov9-sadk board.
> PWM channel 3 of ExynosAutov9 is connected to fan for SoC cooling
> in SADK board.
>
> Signed-off-by: Jaewon Kim <jaewon02.kim@samsung.com>
> ---
> arch/arm64/boot/dts/exynos/exynosautov9-sadk.dts | 6 ++++++
> arch/arm64/boot/dts/exynos/exynosautov9.dtsi | 10 ++++++++++
> 2 files changed, 16 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/exynos/exynosautov9-sadk.dts b/arch/arm64/boot/dts/exynos/exynosautov9-sadk.dts
> index 101f51bf565a..bc1815f6ada2 100644
> --- a/arch/arm64/boot/dts/exynos/exynosautov9-sadk.dts
> +++ b/arch/arm64/boot/dts/exynos/exynosautov9-sadk.dts
> @@ -49,6 +49,12 @@
> };
> };
>
> +&pwm {
> + pinctrl-names = "default";
> + pinctrl-0 = <&pwm_tout3>;
> + status = "okay";
I think you miss disabling it.
> +};
Best regards,
Krzysztof
next prev parent reply other threads:[~2023-07-18 6:06 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20230718034723epcas2p4f50be7f8669579b6e37e50516dee5ae1@epcas2p4.samsung.com>
2023-07-18 3:41 ` [PATCH v5 0/2] support PWM for exynosautov9 Jaewon Kim
[not found] ` <CGME20230718034723epcas2p3913ad208c70659965b4ec204570aa0a1@epcas2p3.samsung.com>
2023-07-18 3:42 ` [PATCH v5 1/2] dt-bindings: pwm: samsung: add exynosautov9 compatible Jaewon Kim
2023-07-18 6:04 ` Krzysztof Kozlowski
2023-07-18 7:40 ` Thierry Reding
2023-07-18 7:42 ` Krzysztof Kozlowski
[not found] ` <CGME20230718034723epcas2p354fc5502d4ed212c7f748d2849e6b60a@epcas2p3.samsung.com>
2023-07-18 3:42 ` [PATCH v5 2/2] arm64: dts: exynos: add pwm node for exynosautov9-sadk Jaewon Kim
2023-07-18 6:06 ` Krzysztof Kozlowski [this message]
2023-07-18 6:09 ` Jaewon Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a62141a9-a2c0-6568-cb05-5ef59250e10f@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=alim.akhtar@samsung.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=jaewon02.kim@samsung.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pwm@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=thierry.reding@gmail.com \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).