From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: William Zhang <william.zhang@broadcom.com>,
Linux ARM List <linux-arm-kernel@lists.infradead.org>
Cc: joel.peshkin@broadcom.com, dan.beygelman@broadcom.com,
"Rob Herring" <robh+dt@kernel.org>,
"Krzysztof Kozlowski" <krzysztof.kozlowski+dt@linaro.org>,
"Anand Gore" <anand.gore@broadcom.com>,
"Kursad Oney" <kursad.oney@broadcom.com>,
"Florian Fainelli" <f.fainelli@gmail.com>,
"Rafał Miłecki" <rafal@milecki.pl>,
"Broadcom internal kernel review list"
<bcm-kernel-feedback-list@broadcom.com>,
"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
<devicetree@vger.kernel.org>,
"open list" <linux-kernel@vger.kernel.org>
Subject: Re: [RESEND PATCH 2/9] dt-bindings: arm64: bcmbca: Update BCM4908 description
Date: Thu, 21 Jul 2022 08:44:18 +0200 [thread overview]
Message-ID: <a635754e-bf41-4058-5fbb-57ead36b7128@linaro.org> (raw)
In-Reply-To: <20220721000658.29537-1-william.zhang@broadcom.com>
On 21/07/2022 02:06, William Zhang wrote:
> Append "brcm,bcmbca" to BCM4908 chip family compatible strings. Add
> generic 4908 board entry.
This does not explain at all why you are doing it. Improve your commit
messages.
The explanation you gave here:
https://lore.kernel.org/all/b8eda882-6838-ab7d-6e2e-131e3125b16f@broadcom.com/
is also not really sufficient (and is not in commit msg). Moving things
around in Linux Kconfig does not justify adding some new compatibles.
To be - clear - this is not a review, so you cannot add Rb tag. If you
insist on a tag, then it as counted as NAK.
Best regards,
Krzysztof
next prev parent reply other threads:[~2022-07-21 6:44 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-21 0:06 [RESEND PATCH 2/9] dt-bindings: arm64: bcmbca: Update BCM4908 description William Zhang
2022-07-21 6:11 ` Rafał Miłecki
2022-07-21 6:44 ` Krzysztof Kozlowski [this message]
2022-07-21 6:51 ` Rafał Miłecki
2022-07-21 7:01 ` Krzysztof Kozlowski
2022-07-21 7:13 ` Rafał Miłecki
2022-07-21 7:36 ` Krzysztof Kozlowski
2022-07-21 7:50 ` Rafał Miłecki
2022-07-21 16:43 ` Florian Fainelli
2022-07-21 19:35 ` William Zhang
2022-07-22 18:22 ` Krzysztof Kozlowski
2022-07-25 6:00 ` William Zhang
2022-07-22 0:07 ` William Zhang
2022-07-22 18:24 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a635754e-bf41-4058-5fbb-57ead36b7128@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=anand.gore@broadcom.com \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=dan.beygelman@broadcom.com \
--cc=devicetree@vger.kernel.org \
--cc=f.fainelli@gmail.com \
--cc=joel.peshkin@broadcom.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=kursad.oney@broadcom.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rafal@milecki.pl \
--cc=robh+dt@kernel.org \
--cc=william.zhang@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).