From: Srinivasa Rao Mandadapu <srivasam@codeaurora.org>
To: Mark Brown <broonie@kernel.org>
Cc: agross@kernel.org, bjorn.andersson@linaro.org,
lgirdwood@gmail.com, robh+dt@kernel.org, plai@codeaurora.org,
bgoswami@codeaurora.org, perex@perex.cz, tiwai@suse.com,
srinivas.kandagatla@linaro.org, rohitkr@codeaurora.org,
linux-arm-msm@vger.kernel.org, alsa-devel@alsa-project.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
swboyd@chromium.org, judyhsiao@chromium.org
Subject: Re: [PATCH] ASoC: qcom: lpass-cpu: Fix pop noise during audio capture begin
Date: Fri, 14 May 2021 12:20:46 +0530 [thread overview]
Message-ID: <a6649fad-c2ca-1808-4227-8bcb373f66bd@codeaurora.org> (raw)
In-Reply-To: <20210513133132.GC5813@sirena.org.uk>
Hi Brown,
Thanks for your review comments!!!
On 5/13/2021 7:01 PM, Mark Brown wrote:
> On Thu, May 13, 2021 at 05:15:39PM +0530, Srinivasa Rao Mandadapu wrote:
>
>> + if (substream->stream == SNDRV_PCM_STREAM_PLAYBACK) {
>> + ret = regmap_fields_write(i2sctl->spken, id,
>> + LPAIF_I2SCTL_SPKEN_ENABLE);
>> + } else {
>> + ret = regmap_fields_write(i2sctl->micen, id,
>> + LPAIF_I2SCTL_MICEN_ENABLE);
>> + }
> This commit doesn't remove the matching update in triger() so we'd have
> two redundant updates. I guess it's unlikely to be harmful but it looks
> wrong/confusing.
Yes, It's not harmful, as clk_prepare_enable is enabling clock only once
but maintaining count.
As Some times in Suspend/resume Sequence not hitting startup/shutdown,
but Trigger, so for maintaining
consistency not removed in trigger.
--
Qualcomm India Private Limited, on behalf of Qualcomm Innovation Center, Inc.,
is a member of Code Aurora Forum, a Linux Foundation Collaborative Project.
next prev parent reply other threads:[~2021-05-14 6:50 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-13 11:45 [PATCH] ASoC: qcom: lpass-cpu: Fix pop noise during audio capture begin Srinivasa Rao Mandadapu
2021-05-13 13:31 ` Mark Brown
2021-05-14 6:50 ` Srinivasa Rao Mandadapu [this message]
2021-05-14 15:30 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a6649fad-c2ca-1808-4227-8bcb373f66bd@codeaurora.org \
--to=srivasam@codeaurora.org \
--cc=agross@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=bgoswami@codeaurora.org \
--cc=bjorn.andersson@linaro.org \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=judyhsiao@chromium.org \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=perex@perex.cz \
--cc=plai@codeaurora.org \
--cc=robh+dt@kernel.org \
--cc=rohitkr@codeaurora.org \
--cc=srinivas.kandagatla@linaro.org \
--cc=swboyd@chromium.org \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).