Re: [PATCH v3 09/20] nvmem: core: introduce NVMEM layouts

["Rafał Miłecki" <rafal@milecki.pl>]

On 2023-03-10 11:55, Srinivas Kandagatla wrote:
> On 08/03/2023 15:31, Miquel Raynal wrote:
>> +const void *nvmem_layout_get_match_data(struct nvmem_device *nvmem,
>> +					struct nvmem_layout *layout)
>> +{
>> +	struct device_node __maybe_unused *layout_np;
>> +	const struct of_device_id *match;
>> +
>> +	layout_np = of_nvmem_layout_get_container(nvmem);
>> +	match = of_match_node(layout->of_match_table, layout_np);
>> +
>> +	return match ? match->data : NULL;
>> +}
>> +EXPORT_SYMBOL_GPL(nvmem_layout_get_match_data);
> 
> who is the user of this function, in the current patchset I see none?

This will be required for the U-Boot env layout, see:
[PATCH V3 4/6] nvmem: u-boot-env: convert to layout driver


> On the other hand interpretation of match data is pretty much driver
> specific i see no reason for this to be in core.

Interpretation: yes. It's driver specific.

Getting that struct however belongs to the core. We have all kind of
helpers for getting driver private data. Those helpers live in some core
code of subsystems.