From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Mubin Sayyed <mubin.sayyed@amd.com>,
krzysztof.kozlowski+dt@linaro.org,
u.kleine-koenig@pengutronix.de, thierry.reding@gmail.com,
robh+dt@kernel.org, conor+dt@kernel.org, tglx@linutronix.de,
daniel.lezcano@linaro.org, michal.simek@amd.com
Cc: linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
linux-pwm@vger.kernel.org, git@amd.com, mubin10@gmail.com
Subject: Re: [LINUX PATCH v2 2/3] dt-bindings: timer: Add bindings for TTC PWM
Date: Tue, 14 Nov 2023 22:08:31 +0100 [thread overview]
Message-ID: <a68ffc93-1ba7-433d-87b5-a6f2bed0173a@linaro.org> (raw)
In-Reply-To: <20231114124748.581850-3-mubin.sayyed@amd.com>
On 14/11/2023 13:47, Mubin Sayyed wrote:
> Cadence TTC can act as PWM device, it is supported through
> separate PWM framework based driver. Decision to configure
> specific TTC device as PWM or clocksource/clockevent would
> be done based on presence of "#pwm-cells" property.
This is a friendly reminder during the review process.
It seems my or other reviewer's previous comments were not fully
addressed. Maybe the feedback got lost between the quotes, maybe you
just forgot to apply it. Please go back to the previous discussion and
either implement all requested changes or keep discussing them.
Thank you.
Missed comments: subject. I don't understand why Cadence was dropped,
but "bindings" stayed. Opposite of what I asked.
Rest looks good, so with above fixed:
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
This is an automated instruction, just in case, because many review tags
are being ignored. If you know the process, you can skip it (please do
not feel offended by me posting it here - no bad intentions intended).
If you do not know the process, here is a short explanation:
Please add Acked-by/Reviewed-by/Tested-by tags when posting new
versions, under or above your Signed-off-by tag. Tag is "received", when
provided in a message replied to you on the mailing list. Tools like b4
can help here. However, there's no need to repost patches *only* to add
the tags. The upstream maintainer will do that for tags received on the
version they apply.
https://elixir.bootlin.com/linux/v6.5-rc3/source/Documentation/process/submitting-patches.rst#L577
Best regards,
Krzysztof
next prev parent reply other threads:[~2023-11-14 21:08 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-14 12:47 [LINUX PATCH v2 0/3] Add initial support for TTC PWM driver Mubin Sayyed
2023-11-14 12:47 ` [LINUX PATCH v2 1/3] clocksource: timer-cadence-ttc: Do not probe TTC device configured as PWM Mubin Sayyed
2023-11-14 21:10 ` Krzysztof Kozlowski
2023-11-15 5:55 ` Sayyed, Mubin
2023-11-15 12:11 ` Krzysztof Kozlowski
2023-11-24 11:03 ` Sayyed, Mubin
2023-11-24 11:35 ` Krzysztof Kozlowski
2023-11-24 11:59 ` Michal Simek
2023-11-24 12:07 ` Sayyed, Mubin
2023-11-24 16:24 ` Krzysztof Kozlowski
2023-11-24 16:29 ` Krzysztof Kozlowski
2023-11-14 12:47 ` [LINUX PATCH v2 2/3] dt-bindings: timer: Add bindings for TTC PWM Mubin Sayyed
2023-11-14 21:08 ` Krzysztof Kozlowski [this message]
2023-11-14 12:47 ` [LINUX PATCH v2 3/3] pwm: pwm-cadence: Add support " Mubin Sayyed
2023-11-14 21:59 ` Uwe Kleine-König
2023-11-24 11:34 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a68ffc93-1ba7-433d-87b5-a6f2bed0173a@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=conor+dt@kernel.org \
--cc=daniel.lezcano@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=git@amd.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pwm@vger.kernel.org \
--cc=michal.simek@amd.com \
--cc=mubin.sayyed@amd.com \
--cc=mubin10@gmail.com \
--cc=robh+dt@kernel.org \
--cc=tglx@linutronix.de \
--cc=thierry.reding@gmail.com \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).