From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2C3B1C4332F for ; Thu, 20 Oct 2022 08:18:27 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231224AbiJTIS0 (ORCPT ); Thu, 20 Oct 2022 04:18:26 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48550 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231255AbiJTISZ (ORCPT ); Thu, 20 Oct 2022 04:18:25 -0400 Received: from mail-wr1-x42c.google.com (mail-wr1-x42c.google.com [IPv6:2a00:1450:4864:20::42c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E0013150FA9 for ; Thu, 20 Oct 2022 01:18:21 -0700 (PDT) Received: by mail-wr1-x42c.google.com with SMTP id bu30so33107185wrb.8 for ; Thu, 20 Oct 2022 01:18:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:organization:references:cc:to :content-language:subject:reply-to:from:user-agent:mime-version:date :message-id:from:to:cc:subject:date:message-id:reply-to; bh=Fsj+8WfOAZfb/OmR4M1+8IvYvMPpVpcsoTV/p/XqqZI=; b=qh1bsgdxEeRCQ6hZldQMcr3aLqpWdd1Clao0b8Ya5qOdGGbjkC94KnXF1WtRGghZA9 kiCXAtUNfsM0/UJskrvFZvEjSjPHQHp8+w05atY2PKLSkHNQeqYq8rMnyIf7kp5yGD8g 18dqXvtWAUjToox+VWRTYw2x1amBzMLfYOi20j2ybIQIU5SgiealQ0r7JKAzSpbFGSOQ g7MwnhfWhXcZSQVeYnUr8ynUaAfaxSvapGRddFhcinqCWnlAllOLxfCXSKSC/Y465mHt x2qon43dtp8zWqeV42EtzH2vZOW1Yft19khX2huV6LD49oCR6/WoDRQJNReRqi27KCAq +c+A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:organization:references:cc:to :content-language:subject:reply-to:from:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=Fsj+8WfOAZfb/OmR4M1+8IvYvMPpVpcsoTV/p/XqqZI=; b=amw42C1VSrjBN3nbSCaLbHyk+6t+IpJgYhBcXn0FI/MMonYis04khHLFtN5zBz9X66 wCsWZqZasawU9y/0pqvwMtuVPrn3HE0jN/iHygBbLZrlGtc99aqAQ2gwYgL1QVYWA0Zz 0BLYciEkaXXSlcc+9QkuBhKng1eLSrjAwj7ATlBhhimGAslM2yHYYDFZ3b5mpn2296I1 Kx3IELR6f0MjXfQKgkxE2lwZ0duPdJoVHyMlescHIn6Z/WXqUOqzaiCwkM+O3znFArAT QsJJJb1IrU4HPaU8LR0CocHe5sReWNlaWu2F0lTAq+cD8uhMXuPqUSnfYaIsANcY77lg m7oQ== X-Gm-Message-State: ACrzQf1XoMTLjZhATqnu6CEDxeWvdDyz/baLEXz5IhW49dwsgYYMjU8W uYImrZ6pN4ZdQYztH/3rX5UpSA== X-Google-Smtp-Source: AMsMyM6UKfTDoyvlxHH9d/C28T5MXbvxRFj4MQ89o3ZziE5fhA0V9cNBU3VXeKSyrS1ckZcMeT35uA== X-Received: by 2002:a5d:59a7:0:b0:230:3652:1aa with SMTP id p7-20020a5d59a7000000b00230365201aamr7627500wrr.308.1666253899934; Thu, 20 Oct 2022 01:18:19 -0700 (PDT) Received: from ?IPV6:2a01:e0a:982:cbb0:ef2:f28d:311f:c84b? ([2a01:e0a:982:cbb0:ef2:f28d:311f:c84b]) by smtp.gmail.com with ESMTPSA id o13-20020adfe80d000000b0023580e7a2c4sm1462948wrm.86.2022.10.20.01.18.19 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 20 Oct 2022 01:18:19 -0700 (PDT) Message-ID: Date: Thu, 20 Oct 2022 10:18:18 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.3.1 From: Neil Armstrong Reply-To: neil.armstrong@linaro.org Subject: Re: [PATCH v3 2/2] spi: meson-spicc: Use pinctrl to drive CLK line when idle Content-Language: en-US To: Martin Blumenstingl , Amjad Ouled-Ameur Cc: Mark Brown , Krzysztof Kozlowski , Jerome Brunet , Kevin Hilman , Rob Herring , Da Xue , linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-amlogic@lists.infradead.org, linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org References: <20221004-up-aml-fix-spi-v3-0-89de126fd163@baylibre.com> <20221004-up-aml-fix-spi-v3-2-89de126fd163@baylibre.com> Organization: Linaro Developer Services In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 19/10/2022 22:50, Martin Blumenstingl wrote: > Hi Amjad, > > On Wed, Oct 19, 2022 at 4:03 PM Amjad Ouled-Ameur > wrote: > [...] >> diff --git a/arch/arm64/boot/dts/amlogic/meson-gxl.dtsi b/arch/arm64/boot/dts/amlogic/meson-gxl.dtsi >> index c3ac531c4f84..04e9d0f1bde0 100644 >> --- a/arch/arm64/boot/dts/amlogic/meson-gxl.dtsi >> +++ b/arch/arm64/boot/dts/amlogic/meson-gxl.dtsi >> @@ -429,6 +429,20 @@ mux { >> }; >> }; >> >> + spi_idle_high_pins: spi-idle-high-pins { >> + mux { >> + groups = "spi_sclk"; >> + bias-pull-up; >> + }; >> + }; >> + >> + spi_idle_low_pins: spi-idle-low-pins { >> + mux { >> + groups = "spi_sclk"; >> + bias-pull-down; >> + }; >> + }; >> + > We typically have the .dts{,i} changes in a separate patch. I suggest > doing the same here. > I also have two questions about this part: > - why are these not referenced by the SPICC controller node? Because it's up to the board to use or not those states, if some pull-up/downs are already present on the lines no need to use those special states. > - is there a particular reason why meson-gxl.dtsi is updated but > meson-gxbb.dtsi is not? (my understanding is that GXBB is also lacking > hardware OEN support) Good question indeed, so indeed they should be added in meson-gxbb.dtsi in a separate patch. > > > Best regards, > Martin Thanks, Neil