Re: [PATCH 04/13] ARM: remove legacy pxa board files

["Arnd Bergmann" <arnd@kernel.org>]

On Tue, Sep 8, 2026, at 18:01, sashiko-bot@kernel.org wrote:
>> diff --git a/arch/arm/mach-pxa/Kconfig b/arch/arm/mach-pxa/Kconfig
>> index 2fb29b9ef7446..354e3dc177763 100644
>> --- a/arch/arm/mach-pxa/Kconfig
>> +++ b/arch/arm/mach-pxa/Kconfig
> [ ... ]
>> -config GUMSTIX_AM200EPD
>> -	bool "Enable AM200EPD board support"
>> -
>> -config GUMSTIX_AM300EPD
>> -	bool "Enable AM300EPD board support"
>> -
>> -endchoice
>> -
>> -config PXA_SHARPSL
>> -	bool "SHARP Zaurus SL-5600, SL-C7xx and SL-Cxx00 Models (DEPRECATED)"
>
> [Severity: Medium]
> Since PXA_SHARPSL and related configs are removed here, does this leave
> unmet dependencies in other subsystems?
>
> For example, in drivers/pcmcia/Kconfig, PCMCIA_PXA2XX has:
>     depends on ARM && ARCH_PXA && PCMCIA && PXA_SHARPSL

These are addressed in a later patch.

> For instance, drivers/pcmcia/pxa2xx_sharpsl.c,
> drivers/video/backlight/corgi_lcd.c, and sound/soc/pxa/spitz.c appear
> to be specific to the removed Sharp SL and Spitz boards. The sharpsl-nand
> device probed in drivers/mtd/nand/raw/sharpsl.c is also no longer
> registered.
>
> Additionally, there are leftover ifdef blocks, such as
> #ifdef CONFIG_GUMSTIX_AM200EPD in drivers/video/fbdev/core/fbmem.c
> (inside register_framebuffer) and include/linux/fb.h, as well as
> #ifdef CONFIG_SHARPSL_PM in drivers/hwmon/max1111.c (in max1111_read_channel).
>
> Could these drivers and dead ifdef blocks be cleaned up in a follow-up?

I have patches for all these, yes.

> [Severity: Low]
> With the implementations of these platform data setters removed, should
> their corresponding external declarations be cleaned up from the
> subsystem headers to prevent dangling prototypes?
>
> For example:
> - pxa_set_fb_info() in include/linux/platform_data/video-pxafb.h
> - pxa_set_ohci_info() in include/linux/platform_data/usb-ohci-pxa27x.h
> - pxa_set_mci_info() in include/linux/platform_data/mmc-pxamci.h

I have separate patches to remove those three files, either as part of
removing the drivers, or changing them to DT-only.

         Arnd