From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9B27CC77B7D for ; Sat, 13 May 2023 18:42:25 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232006AbjEMSmY (ORCPT ); Sat, 13 May 2023 14:42:24 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35410 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229508AbjEMSmX (ORCPT ); Sat, 13 May 2023 14:42:23 -0400 Received: from mail-ej1-x633.google.com (mail-ej1-x633.google.com [IPv6:2a00:1450:4864:20::633]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0939D1FE7 for ; Sat, 13 May 2023 11:42:21 -0700 (PDT) Received: by mail-ej1-x633.google.com with SMTP id a640c23a62f3a-9659443fb56so1753421366b.2 for ; Sat, 13 May 2023 11:42:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1684003339; x=1686595339; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=n+4YRB2fAb6S5ZQss3vm44TC9IZxgw87qep5+W+Me9o=; b=SyH0NzgPiy0IIvqbAedILCHmuD/6u9Wq/iN/NwQxsc6KmxNtiJZilMYP80CWi8o/dv e5CsqPIPy4Uyud4VlYujfC6SMtv6N5HX+LmeUoctoNUe4h7dzC8qDSQ5naT0/Z7M50n0 KmUEJBe2VizyU2xyM3Pwcu76aLpGBB9ywCMT3Z1le/eEJ9Jm/rq6dLOitFItqiXP+FGw ig8kE8FMCCI72G+el8MVyLpx5aGKIMtraxvbk4RCM39tVH3tN4sVthWK5ent2JQ+oZS5 mOq0ZPueDdyC2jtEUvI7ZbtXV6WEl9qjYjaBdAHgv+yUuC7o+nfZuArb1BdSWQMY+SXB zMow== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1684003339; x=1686595339; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=n+4YRB2fAb6S5ZQss3vm44TC9IZxgw87qep5+W+Me9o=; b=Udn+opTWuY1ZbUKG3CFgtfVY8UB2tfgn2U5Fk6uSn2U22UEkWb8wJDCc+RizzEPAHP Pysx67vftQ1ZE8qA3aWaQm0AsFUA7sUPubh1cbXylCDjCXJjCY82j9kcdhm7tdpJ52Y5 HQ5AtJfJGwgsxWW1pb3MEax9cuCaVHNBjs2muRpJjfBcohmThQQC0HJVj2L5RrxD0pJN gh/ETwQbEPAdduazigM1FQFpgxFK+8dMvgXUiPSSX2nHRo8UIRT8T4W+cjUZWMARWgfv kGn8kgGg5qZ6T6dZGatcJrMTBsDZs7nbMfDLUyvtd94mHVVapWfBkFPA3hCmzVEVvTyU e1Dw== X-Gm-Message-State: AC+VfDx2gycZz50oulgfRmu17Ak3VACtc5QtxuQxBFaXVcMzBSlqOP0S poOr4R1D2CfBK9JBSZ0cERj33Q== X-Google-Smtp-Source: ACHHUZ77iaulugNkUAzkaRKxvRt4Umoyd3WapFnrN1bo4XgCe7thSF7VUawmgcobdnnDS8/p3XsuTg== X-Received: by 2002:a17:907:9706:b0:965:eb5d:3b26 with SMTP id jg6-20020a170907970600b00965eb5d3b26mr30399521ejc.52.1684003339477; Sat, 13 May 2023 11:42:19 -0700 (PDT) Received: from ?IPV6:2a02:810d:15c0:828:ba68:e5c9:694e:c6e4? ([2a02:810d:15c0:828:ba68:e5c9:694e:c6e4]) by smtp.gmail.com with ESMTPSA id p1-20020a170906838100b009662b4230cesm7229864ejx.148.2023.05.13.11.42.18 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 13 May 2023 11:42:18 -0700 (PDT) Message-ID: Date: Sat, 13 May 2023 20:42:18 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.11.0 Subject: Re: [PATCH v2 1/2] dt-bindings: cdns,usb3: Add clock and reset Content-Language: en-US To: Minda Chen , Roger Quadros , Rob Herring , Krzysztof Kozlowski , Pawel Laszczak , Greg Kroah-Hartman , Peter Chen , Philipp Zabel Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org References: <20230510132816.108820-1-minda.chen@starfivetech.com> <20230510132816.108820-2-minda.chen@starfivetech.com> <9cf5965a-8290-dfff-9f92-07ed2df66650@linaro.org> <05057f6d-cb38-8e4a-5d30-82863e0cda44@kernel.org> <028fb8ac-d6cc-6fee-f50b-b965e69e7d0c@linaro.org> From: Krzysztof Kozlowski In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 12/05/2023 12:22, Minda Chen wrote: > > > On 2023/5/11 22:49, Krzysztof Kozlowski wrote: >> On 11/05/2023 14:16, Roger Quadros wrote: >>> >>> >>> On 11/05/2023 12:26, Krzysztof Kozlowski wrote: >>>> On 10/05/2023 15:28, Minda Chen wrote: >>>>> To support generic clock and reset init in Cadence USBSS >>>>> controller, add clock and reset dts configuration. >>>>> >>>>> Signed-off-by: Minda Chen >>>>> --- >>>>> .../devicetree/bindings/usb/cdns,usb3.yaml | 14 ++++++++++++++ >>>>> 1 file changed, 14 insertions(+) >>>>> >>>>> diff --git a/Documentation/devicetree/bindings/usb/cdns,usb3.yaml b/Documentation/devicetree/bindings/usb/cdns,usb3.yaml >>>>> index cae46c4982ad..623c6b34dee3 100644 >>>>> --- a/Documentation/devicetree/bindings/usb/cdns,usb3.yaml >>>>> +++ b/Documentation/devicetree/bindings/usb/cdns,usb3.yaml >>>>> @@ -42,6 +42,18 @@ properties: >>>>> - const: otg >>>>> - const: wakeup >>>>> >>>>> + clocks: >>>>> + minItems: 1 >>>>> + maxItems: 8 >>>>> + description: >>>>> + USB controller clocks. >>>> >>>> You need to list the items. And why is it variable? Your clock choice in >>>> the example is poor, I doubt it is real. >>>> >>>>> + >>>>> + resets: >>>>> + minItems: 1 >>>>> + maxItems: 8 >>>>> + description: >>>>> + USB controller generic resets. >>>> >>>> Here as well. >>>> >>>> You had one clock last time, thus the review was - drop the names. Now >>>> you changed it to 8 clocks... I don't understand. >>>> >>> >>> Different platforms may have different number of clocks/resets or none. >>> So I don't think minItems/maxItems should be specified. >> >> Yeah, but we want the clocks to be specific per platform. Not anything >> anywhere. >> >> Best regards, >> Krzysztof >> > > I can change like these. Are these changes can be approved? > lpm , bus clock and "pwrup" reset can be specific cases. (The changes are from snps,dwc3.yaml.) > > clocks: > description: > In general the core supports two types of clocks. bus is a SoC Bus > Clock(AHB/AXI/APB). lpm is a link power management clock. But particular > cases may differ from that having less or more clock sources with > another names. > > clock-names: > contains: > anyOf: > - enum: [bus, lpm] > - true > No because this does not solve my concern. You allow here anything, which is not desired. The device bindings should specify what clocks (and resets) you have here. Order is also fixed (with exceptions). Now, if this is generic IP block used by different SoC vendors and it has different clocks in different implementations, it means one compatible for all of them is not enough anymore. Best regards, Krzysztof