Re: [PATCH v2 05/14] media: qcom: camss: Add camss-isp-bufq helper

Krzysztof Kozlowski
2026-04-28T06:46:10Z

On 27/04/2026 14:43, Loic Poulain wrote:
> +
> +struct camss_isp_bufq *camss_isp_bufq_init(unsigned int num_queues)
> +{
> + struct camss_isp_bufq *bufq;
> + unsigned int i;
> +
> + bufq = kzalloc(struct_size(bufq, entries, num_queues), GFP_KERNEL);
> + if (!bufq)
> + return ERR_PTR(-ENOMEM);
> +
> + bufq->num_queues = num_queues;
> +
> + for (i = 0; i < num_queues; i++) {
> + INIT_LIST_HEAD(&bufq->entries[i].rdy_queue);
> + spin_lock_init(&bufq->entries[i].rdy_spinlock);
> + }
> +
> + return bufq;
> +}
> +EXPORT_SYMBOL_GPL(camss_isp_bufq_init);

You need kerneldocs for all of exported functions.

> +
> +void camss_isp_bufq_release(struct camss_isp_bufq *bufq)
> +{
> + kfree(bufq);
> +}
> +EXPORT_SYMBOL_GPL(camss_isp_bufq_release);
> +

Best regards,
Krzysztof