Re: [PATCH v2 05/14] media: qcom: camss: Add camss-isp-bufq helper

Loic Poulain
2026-04-28T11:29:56Z

On Tue, Apr 28, 2026 at 8:56 AM Bryan O'Donoghue <bod@kernel.org> wrote:
>
> On 27/04/2026 13:43, Loic Poulain wrote:
> > Add a per-queue ready-buffer FIFO helper for CAMSS offline ISP drivers.
> > camss_isp_bufq provides N spinlock-protected FIFO lists of ready vb2
> > buffers, one per queue index. This can help multi-queues management
> > and synchronization in ISP context.
> >
> > Signed-off-by: Loic Poulain <loic.poulain@oss.qualcomm.com>
> > ---
> > drivers/media/platform/qcom/camss/Kconfig | 14 +++
> > drivers/media/platform/qcom/camss/Makefile | 5 +
> > drivers/media/platform/qcom/camss/camss-isp-bufq.c | 101 +++++++++++++++++++++
> > drivers/media/platform/qcom/camss/camss-isp-bufq.h | 85 +++++++++++++++++
> What is the purpose of this and the next three patches - why not just do
> it inside the OPE ?

The goal is to improve reusability and avoid an complicated/large OPE
driver by moving non‑OPE‑specific logic out of the driver. This would
allow it to serve as a common framework for both offline and inline
CAMSS processing engines. Looking further ahead, some parts could be
further generalized or refined to fit within the v4l2‑isp framework,
although that is a longer‑term discussion.

For now, since OPE is the only consumer, and to keep related logic
localized within its respective files, should these components
initially be built as part of the OPE module? They can then be moved
out later if and when additional users appear.

Regards,
Loic