Re: [PATCH v2 11/14] dt-bindings: media: qcom,qcm2290-camss: Add OPE ISP subnode

Krzysztof Kozlowski
2026-04-28T09:54:09Z

On 28/04/2026 11:50, Konrad Dybcio wrote:
>>> diff --git a/Documentation/devicetree/bindings/media/qcom,qcm2290-camss.yaml b/Documentation/devicetree/bindings/media/qcom,qcm2290-camss.yaml
>>> index 391d0f6f67ef5fdfea31dd3683477561516b1556..d8b356028e24c3c5b2e9b7f20e220db7d491ad68 100644
>>> --- a/Documentation/devicetree/bindings/media/qcom,qcm2290-camss.yaml
>>> +++ b/Documentation/devicetree/bindings/media/qcom,qcm2290-camss.yaml
>>> @@ -52,6 +52,14 @@ properties:
>>> - const: vfe1
>>> - const: vfe1_cphy_rx
>>>
>>> + '#address-cells':
>>
>> Please use consistent quotes, either ' or "
>>
>>> + const: 2
>>
>> This means the child will use 64-bit addressing, but does it need that?
>> Or do you need that to have 36-bit DMA addressing? If there are true no
>> needs for above, usually recommendation is to use narrowe address space
>> for children, so only 32-bit.
>
> I can't find data for this platform, but on e.g. Hamoa, most camera
> components can address 36b

If this is a conscious choice, should be mentioned in commit msg or as
comment in the code with such explanation.

Best regards,
Krzysztof